From c1a304febfb6b2b6248c918c3443988cf8f85903 Mon Sep 17 00:00:00 2001 From: Aaron Ware Date: Sun, 17 Jul 2022 12:23:37 -0400 Subject: [PATCH 1/2] Update tabs.js --- packages/tabs/src/tabs.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/tabs/src/tabs.js b/packages/tabs/src/tabs.js index 632a96e..072db51 100644 --- a/packages/tabs/src/tabs.js +++ b/packages/tabs/src/tabs.js @@ -197,7 +197,7 @@ export default class Tabs { this.addEventListener(tabLink, 'click', (event) => { event.preventDefault(); - if (!event.target.parentNode.classList.contains('is-active')) { + if (!event.currentTarget.parentNode.classList.contains('is-active')) { this.goToTab(event, tabArea); } }); From 28bc0cf8d2e8a77db696975f50c6b4235dfaa035 Mon Sep 17 00:00:00 2001 From: Aaron Ware Date: Sun, 17 Jul 2022 13:10:26 -0400 Subject: [PATCH 2/2] Update tabs.js improve: Found an additional place where target was being used instead of currentTarget --- packages/tabs/src/tabs.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/tabs/src/tabs.js b/packages/tabs/src/tabs.js index 072db51..4e3c761 100644 --- a/packages/tabs/src/tabs.js +++ b/packages/tabs/src/tabs.js @@ -321,7 +321,7 @@ export default class Tabs { } // Change state of newly selected tab. - const newTab = isEvent ? tab.target : tabItems[tab]; + const newTab = isEvent ? tab.currentTarget : tabItems[tab]; if (newTab) { const newTabId = newTab.getAttribute('aria-controls');