From 32151b0a5eb9ebbfa1a1159d36988c489712d450 Mon Sep 17 00:00:00 2001 From: Alex Dimitrov Date: Thu, 21 Oct 2021 16:16:11 +0300 Subject: [PATCH 1/4] Navigation: Add to callback Fixes #28 --- packages/navigation/src/navigation.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/navigation/src/navigation.js b/packages/navigation/src/navigation.js index 1683db3..c81ec2b 100644 --- a/packages/navigation/src/navigation.js +++ b/packages/navigation/src/navigation.js @@ -305,7 +305,7 @@ export default class Navigation { * @callback onSubmenuOpen - optional. */ if (this.settings.onSubmenuOpen && typeof this.settings.onSubmenuOpen === 'function') { - this.settings.onSubmenuOpen.call(); + this.settings.onSubmenuOpen.call(this, $submenu); } } From 3389e7aa8233ea50da023fa6e3f42319b4427d23 Mon Sep 17 00:00:00 2001 From: Ajay Maurya Date: Thu, 13 Jan 2022 23:26:54 +0530 Subject: [PATCH 2/4] SubMenu Item: Add to onSubmenuClose callback --- packages/navigation/src/navigation.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/navigation/src/navigation.js b/packages/navigation/src/navigation.js index c81ec2b..3c7e32f 100644 --- a/packages/navigation/src/navigation.js +++ b/packages/navigation/src/navigation.js @@ -337,7 +337,7 @@ export default class Navigation { * @callback onSubmenuClose - optional. */ if (this.settings.onSubmenuClose && typeof this.settings.onSubmenuClose === 'function') { - this.settings.onSubmenuClose.call(); + this.settings.onSubmenuClose.call(this, $submenu); } } From c5510e3f2848137943730c9685495f96e3801405 Mon Sep 17 00:00:00 2001 From: Joe Snell Date: Fri, 4 Feb 2022 14:11:16 -0800 Subject: [PATCH 3/4] Navigation package update --- packages/navigation/CHANGELOG.md | 3 +++ packages/navigation/package.json | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/navigation/CHANGELOG.md b/packages/navigation/CHANGELOG.md index 9e4693e..5a4873b 100644 --- a/packages/navigation/CHANGELOG.md +++ b/packages/navigation/CHANGELOG.md @@ -2,6 +2,9 @@ All notable changes to this project will be documented in this file, per [the Keep a Changelog standard](http://keepachangelog.com/). +## [2.1.3] +- [#92](https://github.com/10up/component-library/pull/92) + - Add $submenu reference to onSubmenuOpen callback ## [2.1.2] - [#89](https://github.com/10up/component-library/pull/89) - Fix hover state opening subnavigation not working when the default nav is selected. diff --git a/packages/navigation/package.json b/packages/navigation/package.json index 98b0318..c537173 100644 --- a/packages/navigation/package.json +++ b/packages/navigation/package.json @@ -1,6 +1,6 @@ { "name": "@10up/component-navigation", - "version": "2.1.2", + "version": "2.1.3", "author": "10up", "description": "Accessible navigation component.", "main": "dist/index.js", From 4ac2a6c88e5cf16c6825f900855b6f29c677ee77 Mon Sep 17 00:00:00 2001 From: Joe Snell Date: Fri, 4 Feb 2022 14:23:08 -0800 Subject: [PATCH 4/4] revert changes to release --- packages/navigation/CHANGELOG.md | 3 --- packages/navigation/package.json | 2 +- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/packages/navigation/CHANGELOG.md b/packages/navigation/CHANGELOG.md index 5a4873b..9e4693e 100644 --- a/packages/navigation/CHANGELOG.md +++ b/packages/navigation/CHANGELOG.md @@ -2,9 +2,6 @@ All notable changes to this project will be documented in this file, per [the Keep a Changelog standard](http://keepachangelog.com/). -## [2.1.3] -- [#92](https://github.com/10up/component-library/pull/92) - - Add $submenu reference to onSubmenuOpen callback ## [2.1.2] - [#89](https://github.com/10up/component-library/pull/89) - Fix hover state opening subnavigation not working when the default nav is selected. diff --git a/packages/navigation/package.json b/packages/navigation/package.json index c537173..98b0318 100644 --- a/packages/navigation/package.json +++ b/packages/navigation/package.json @@ -1,6 +1,6 @@ { "name": "@10up/component-navigation", - "version": "2.1.3", + "version": "2.1.2", "author": "10up", "description": "Accessible navigation component.", "main": "dist/index.js",