update to galaxy lint standards bump:patch

Author: otakup0pe

.ansible-lint

@@ -6,11 +6,6 @@ exclude_paths:
   - .github/
   - molecule/*/tests/
 
-skip_list:
-  - yaml[line-length]
-  - fqcn[action-core]  # todo this one is probably worth fixing
-  - package-latest
-
 offline: false
 
 supported_ansible_also:

.yamllint

@@ -11,7 +11,7 @@ ignore: |
 
 rules:
   line-length:
-    max: 120
+    max: 160
     level: warning
 
   indentation:

Makefile

@@ -73,6 +73,9 @@ test_workflow: act-download ## Run GitHub workflows, but locally
 
 test: molecule
 
+molecule-destroy:
+	$(molecule) destroy
+
 clean: molecule-destroy ## Clean up molecule instances and temporary files
 	@echo "Cleaning up..."
 	find . -name "*.pyc" -delete
@@ -82,4 +85,5 @@ clean: molecule-destroy ## Clean up molecule instances and temporary files
 
 distclean: clean
 	@echo "Dist cleaning..."
-	rm -rf $(shell pwd)/.act
+	find . -name "*.log" -exec rm {} + 2> /dev/null || true
+	find . -name ".act" -exec rm -rf {} + 2> /dev/null || true

meta/main.yml

@@ -3,7 +3,7 @@ galaxy_info:
   author: "ANXS crew"
   company: "ANXS"
   description: "Installs python, pip, virtualenv, and uv"
-  min_ansible_version: "2.9"
+  min_ansible_version: "2.13"
   license: "MIT"
   namespace: "anxs"
   role_name: "python"

molecule/default/converge.yml

@@ -3,5 +3,5 @@
   hosts: all
   tasks:
     - name: "Include ANXS Role"
-      include_role:
+      ansible.builtin.include_role:
         name: "{{ lookup('env', 'MOLECULE_PROJECT_DIRECTORY') | basename }}"

tasks/main.yml

@@ -1,6 +1,6 @@
 ---
 - name: "Get the distribution specific variables"
-  include_vars: "{{ lookup('ansible.builtin.first_found', params) }}"
+  ansible.builtin.include_vars: "{{ lookup('ansible.builtin.first_found', params) }}"
   vars:
     params:
       files:
@@ -10,11 +10,11 @@
         - "{{ role_path }}/vars"
 
 - name: "Install python and accesory packages"
-  include_tasks: "package.yml"
+  ansible.builtin.include_tasks: "package.yml"
 
 - name: "Ensure pip is properly installed"
-  include_tasks: "pip.yml"
+  ansible.builtin.include_tasks: "pip.yml"
 
 - name: "Ensure uv is available if desired"
-  include_tasks: "uv.yml"
+  ansible.builtin.include_tasks: "uv.yml"
   when: python_uv_install

tasks/package.yml

@@ -1,40 +1,40 @@
 ---
 - name: "Make sure PPA is enabled"
-  apt_repository:
+  ansible.builtin.apt_repository:
     repo: "ppa:deadsnakes/ppa"
     mode: "0644"
   when: python_versions|length > 0
 
 - name: "Make sure the packages are installed"
-  apt:
+  ansible.builtin.apt:
     pkg: "{{ python_packages_add }}"
-    state: "latest"
+    state: "present"
     update_cache: true
   when: python_packages_add|default([])|length > 0
 
 - name: "Make sure old packages are removed"
-  apt:
+  ansible.builtin.apt:
     pkg: "{{ python_packages_remove }}"
     state: "absent"
   when: python_packages_remove|default([])|length > 0
 
 - name: "Install additional (legacy) python versions, if requested"
-  apt:
+  ansible.builtin.apt:
     pkg:
       - "python{{ item }}"
       - "python{{ item }}-distutils"
       - "python{{ item }}-dev"
       - "python{{ item }}-venv"
-    state: "latest"
+    state: "present"
   with_items: "{{ python_versions }}"
   when: item|float < 3.12
 
 - name: "Install additional python versions, if requested"
-  apt:
+  ansible.builtin.apt:
     pkg:
       - "python{{ item }}"
       - "python{{ item }}-dev"
       - "python{{ item }}-venv"
-    state: "latest"
+    state: "present"
   with_items: "{{ python_versions }}"
   when: item|float >= 3.12

tasks/pip.yml

@@ -1,6 +1,6 @@
 ---
 - name: "Install pip the new way"
-  apt:
+  ansible.builtin.apt:
     pkg: "python3-pip"
-    state: "latest"
+    state: "present"
   when: ansible_lsb.id == "Ubuntu"

tests/prepare.yml

@@ -6,32 +6,35 @@
   tasks:
 
     - name: Update apt cache
-      apt:
+      ansible.builtin.apt:
         update_cache: true
         cache_valid_time: 86400
       when: ansible_os_family == "Debian"
 
     - name: Install essential packages
-      apt:
+      ansible.builtin.apt:
         name:
           - curl
           - ca-certificates
           - gnupg
-          - "{{ 'software-properties-common' if (ansible_distribution != 'Debian' or (ansible_distribution == 'Debian' and (ansible_distribution_major_version | int) < 13)) else omit }}"
+          - |
+            {{ 'software-properties-common' if (ansible_distribution != 'Debian'
+            or (ansible_distribution == 'Debian'
+            and (ansible_distribution_major_version | int) < 13)) else omit }}
           - "lsb-release"
         state: present
         update_cache: yes
       when: ansible_os_family == "Debian"
 
     - name: Create test user for permission tests
-      user:
+      ansible.builtin.user:
         name: testuser
         shell: /bin/bash
         create_home: true
         state: present
 
     - name: Ensure target directories exist
-      file:
+      ansible.builtin.file:
         path: "{{ item }}"
         state: directory
         mode: "0755"
@@ -41,5 +44,5 @@
         - /tmp/test-downloads
 
     - name: Set up mock network conditions (for testing error handling)
-      debug:
+      ansible.builtin.debug:
         msg: "Environment prepared for anxs-python role testing"

tests/verify.yml

@@ -10,12 +10,12 @@
   tasks:
     # Python Installation Verification
     - name: Check Python is installed
-      command: python3 --version
+      ansible.builtin.command: python3 --version
       register: python_version
       changed_when: false
 
     - name: Verify Python version output
-      assert:
+      ansible.builtin.assert:
         that:
           - python_version.rc == 0
           - "'Python 3.' in python_version.stdout"
@@ -24,12 +24,12 @@
 
     # Pip Installation Verification
     - name: Check pip is installed
-      command: pip3 --version
+      ansible.builtin.command: pip3 --version
       register: pip_version
       changed_when: false
 
     - name: Verify pip version output
-      assert:
+      ansible.builtin.assert:
         that:
           - pip_version.rc == 0
           - "'pip' in pip_version.stdout"
@@ -38,17 +38,17 @@
 
     # UV Installation Verification (when enabled)
     - name: Check if uv should be installed
-      set_fact:
+      ansible.builtin.set_fact:
         uv_should_be_installed: "{{ python_uv_install | default(false) }}"
 
     - name: Check uv binary exists
-      stat:
+      ansible.builtin.stat:
         path: "{{ python_prefix_dir | default('/usr/local') }}/bin/uv"
       register: uv_binary
       when: uv_should_be_installed
 
     - name: Verify uv binary is executable
-      assert:
+      ansible.builtin.assert:
         that:
           - uv_binary.stat.exists
           - uv_binary.stat.executable
@@ -58,13 +58,13 @@
       when: uv_should_be_installed
 
     - name: Check uvx binary exists
-      stat:
+      ansible.builtin.stat:
         path: "{{ python_prefix_dir | default('/usr/local') }}/bin/uvx"
       register: uvx_binary
       when: uv_should_be_installed
 
     - name: Verify uvx binary is executable
-      assert:
+      ansible.builtin.assert:
         that:
           - uvx_binary.stat.exists
           - uvx_binary.stat.executable
@@ -74,13 +74,13 @@
       when: uv_should_be_installed
 
     - name: Test uv command execution
-      command: "{{ python_prefix_dir | default('/usr/local') }}/bin/uv --version"
+      ansible.builtin.command: "{{ python_prefix_dir | default('/usr/local') }}/bin/uv --version"
       register: uv_version_check
       changed_when: false
       when: uv_should_be_installed
 
     - name: Verify uv version output
-      assert:
+      ansible.builtin.assert:
         that:
           - uv_version_check.rc == 0
           - "'uv' in uv_version_check.stdout"
@@ -90,13 +90,13 @@
       when: uv_should_be_installed
 
     - name: Test uvx command execution
-      command: "{{ python_prefix_dir | default('/usr/local') }}/bin/uvx --version"
+      ansible.builtin.command: "{{ python_prefix_dir | default('/usr/local') }}/bin/uvx --version"
       register: uvx_version_check
       changed_when: false
       when: uv_should_be_installed
 
     - name: Verify uvx version output
-      assert:
+      ansible.builtin.assert:
         that:
           - uvx_version_check.rc == 0
           - "'uvx' in uvx_version_check.stdout"
@@ -106,24 +106,24 @@
 
     # Architecture Detection Verification
     - name: Get system architecture
-      command: uname -m
+      ansible.builtin.command: uname -m
       register: system_arch
       changed_when: false
 
     - name: Verify architecture was detected correctly
-      debug:
+      ansible.builtin.debug:
         msg: "System architecture detected as: {{ system_arch.stdout }}"
 
     # Permissions Verification
     - name: Check file permissions in install directory
-      find:
+      ansible.builtin.find:
         paths: "{{ python_prefix_dir | default('/usr/local') }}/bin"
         patterns: "uv*"
       register: uv_files
       when: uv_should_be_installed
 
     - name: Verify all uv files have correct permissions
-      assert:
+      ansible.builtin.assert:
         that:
           - "item.mode is defined and (item.mode | string) | regex_search('755$')"
         fail_msg: "UV file {{ item.path }} has incorrect permissions: {{ item.mode }}"
@@ -133,22 +133,22 @@
 
     # Idempotency Test Setup (verify no temp files left behind)
     - name: Check for leftover temporary files
-      find:
+      ansible.builtin.find:
         paths: /tmp
         patterns: "*uv*"
         file_type: any
       register: temp_uv_files
 
     - name: Verify no temporary UV files left behind
-      assert:
+      ansible.builtin.assert:
         that:
           - temp_uv_files.files | length == 0
         fail_msg: "Temporary UV files found: {{ temp_uv_files.files | map(attribute='path') | list }}"
         success_msg: "No temporary UV files left behind - good cleanup"
 
     # Final Success Summary
     - name: Display verification summary
-      debug:
+      ansible.builtin.debug:
         msg: |
           ✅ anxs-python Role Verification Complete!