GPU: Do not use printf in GPU code if GPUCA_GPU_DEBUG_PRINT is not defined

Author: davidrohr

Common/MathUtils/include/MathUtils/SMatrixGPU.h

@@ -32,6 +32,7 @@
 #include "GPUCommonArray.h"
 #include "GPUCommonMath.h"
 #include "GPUCommonAlgorithm.h"
+#include "GPUCommonLogger.h"
 
 namespace o2::math_utils
 {
@@ -980,7 +981,7 @@ GPUdi() void Inverter<D, N>::InvertBunchKaufman(MatRepSymGPU<T, D>& rhs, int& if
         // invert D(j:j+1,j:j+1)
         temp2 = *mjj * *(mjj + j + 1) - *(mjj + j) * *(mjj + j);
         if (temp2 == 0) {
-          printf("SymMatrix::bunch_invert: error in pivot choice");
+          LOGF(error, "SymMatrix::bunch_invert: error in pivot choice");
         }
         temp2 = 1. / temp2;
         // this quotient is guaranteed to exist by the choice
@@ -1070,7 +1071,7 @@ GPUdi() void Inverter<D, N>::InvertBunchKaufman(MatRepSymGPU<T, D>& rhs, int& if
     } else // 2x2 pivot, compute columns j and j-1 of the inverse
     {
       if (piv[j - 1] != 0) {
-        printf("error in piv %lf \n", static_cast<T>(piv[j - 1]));
+        LOGF(error, "error in piv %lf \n", static_cast<T>(piv[j - 1]));
       }
       s = 2;
       if (j < nrow) {

DataFormats/Reconstruction/src/TrackParametrization.cxx

@@ -589,15 +589,9 @@ GPUd() void TrackParametrization<value_T>::printParam() const
   // print parameters
 #ifndef GPUCA_ALIGPUCODE
   printf("%s\n", asString().c_str());
-#else
+#elif !defined(GPUCA_GPUCODE_DEVICE) || (!defined(__OPENCL__) && defined(GPUCA_GPU_DEBUG_PRINT))
   printf("X:%+.4e Alp:%+.3e Par: %+.4e %+.4e %+.4e %+.4e %+.4e |Q|:%d %s",
-         getX(), getAlpha(), getY(), getZ(), getSnp(), getTgl(), getQ2Pt(), getAbsCharge(),
-#if !defined(__OPENCL__) && defined(GPUCA_GPU_DEBUG_PRINT)
-         getPID().getName()
-#else
-         ""
-#endif
-  );
+         getX(), getAlpha(), getY(), getZ(), getSnp(), getTgl(), getQ2Pt(), getAbsCharge(), getPID().getName());
 #endif
 }
 
@@ -608,7 +602,7 @@ GPUd() void TrackParametrization<value_T>::printParamHexadecimal()
   // print parameters
 #ifndef GPUCA_ALIGPUCODE
   printf("%s\n", asStringHexadecimal().c_str());
-#else
+#elif !defined(GPUCA_GPUCODE_DEVICE) || (!defined(__OPENCL__) && defined(GPUCA_GPU_DEBUG_PRINT))
   printf("X:%x Alp:%x Par: %x %x %x %x %x |Q|:%x %s",
          gpu::CAMath::Float2UIntReint(getX()),
          gpu::CAMath::Float2UIntReint(getAlpha()),
@@ -618,12 +612,7 @@ GPUd() void TrackParametrization<value_T>::printParamHexadecimal()
          gpu::CAMath::Float2UIntReint(getTgl()),
          gpu::CAMath::Float2UIntReint(getQ2Pt()),
          gpu::CAMath::Float2UIntReint(getAbsCharge()),
-#if !defined(__OPENCL__) && defined(GPUCA_GPU_DEBUG_PRINT)
-         getPID().getName()
-#else
-         ""
-#endif
-  );
+         getPID().getName());
 #endif
 }
 

DataFormats/Reconstruction/src/TrackParametrizationWithError.cxx

@@ -1214,7 +1214,7 @@ GPUd() void TrackParametrizationWithError<value_T>::print() const
   // print parameters
 #ifndef GPUCA_ALIGPUCODE
   printf("%s\n", asString().c_str());
-#else
+#elif !defined(GPUCA_GPUCODE_DEVICE) || (!defined(__OPENCL__) && defined(GPUCA_GPU_DEBUG_PRINT))
   TrackParametrization<value_T>::printParam();
   printf(
     "\nCov: [%+.3e] [%+.3e %+.3e] [%+.3e %+.3e %+.3e] [%+.3e %+.3e %+.3e %+.3e] [%+.3e %+.3e %+.3e %+.3e %+.3e]",
@@ -1231,7 +1231,7 @@ GPUd() void TrackParametrizationWithError<value_T>::printHexadecimal()
   // print parameters
 #ifndef GPUCA_ALIGPUCODE
   printf("%s\n", asStringHexadecimal().c_str());
-#else
+#elif !defined(GPUCA_GPUCODE_DEVICE) || (!defined(__OPENCL__) && defined(GPUCA_GPU_DEBUG_PRINT))
   TrackParametrization<value_T>::printParamHexadecimal();
   printf(
     "\nCov: [%x] [%x %x] [%x %x %x] [%x %x %x %x] [%x %x %x %x %x]",

Detectors/ITSMFT/ITS/tracking/include/ITStracking/Cluster.h

@@ -54,7 +54,9 @@ struct Cluster final {
 
 GPUhdi() void Cluster::print() const
 {
+#if !defined(GPUCA_GPUCODE_DEVICE) || (!defined(__OPENCL__) && defined(GPUCA_GPU_DEBUG_PRINT))
   printf("Cluster: %f %f %f %f %f %d %d\n", xCoordinate, yCoordinate, zCoordinate, phi, radius, clusterId, indexTableBinIndex);
+#endif
 }
 
 struct TrackingFrameInfo {
@@ -70,10 +72,12 @@ struct TrackingFrameInfo {
   o2::gpu::gpustd::array<float, 3> covarianceTrackingFrame = {999., 999., 999.};
   GPUdi() void print() const
   {
+#if !defined(GPUCA_GPUCODE_DEVICE) || (!defined(__OPENCL__) && defined(GPUCA_GPU_DEBUG_PRINT))
     printf("x: %f y: %f z: %f xTF: %f alphaTF: %f posTF: %f %f covTF: %f %f %f\n",
            xCoordinate, yCoordinate, zCoordinate, xTrackingFrame, alphaTrackingFrame,
            positionTrackingFrame[0], positionTrackingFrame[1],
            covarianceTrackingFrame[0], covarianceTrackingFrame[1], covarianceTrackingFrame[2]);
+#endif
   }
 
   ClassDefNV(TrackingFrameInfo, 1);