Skip to content

Commit 01db2aa

Browse files
committed
adopt namespaced fairmq api consistently
see FairRootGroup/FairMQ#423
1 parent 91c775e commit 01db2aa

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

42 files changed

+135
-137
lines changed

CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ message(STATUS "CMAKE_CXX_STANDARD = ${CMAKE_CXX_STANDARD}")
7979
list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_LIST_DIR}/cmake")
8080

8181
find_package(Threads REQUIRED)
82-
find_package(FairMQ 1.4 REQUIRED)
82+
find_package(FairMQ 1.4.41 REQUIRED)
8383
find_package(FairLogger ${FairMQ_FairLogger_VERSION} REQUIRED)
8484
message(STATUS "Looking for FairLogger dependencies: ${FairLogger_PACKAGE_DEPENDENCIES}" )
8585
foreach(dep IN LISTS FairLogger_PACKAGE_DEPENDENCIES)

src/ReadoutEmulator/CruEmulator.cxx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313

1414
#include <ConcurrentQueue.h>
1515

16-
#include <options/FairMQProgOptions.h>
16+
#include <fairmq/ProgOptions.h>
1717

1818
#include <chrono>
1919
#include <thread>

src/ReadoutEmulator/CruMemoryHandler.cxx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@
1414

1515
#include <ConcurrentQueue.h>
1616

17-
#include <fairmq/FairMQUnmanagedRegion.h>
18-
#include <fairmq/FairMQDevice.h> /* NewUnmanagedRegionFor */
19-
#include <options/FairMQProgOptions.h>
17+
#include <fairmq/UnmanagedRegion.h>
18+
#include <fairmq/Device.h> /* NewUnmanagedRegionFor */
19+
#include <fairmq/ProgOptions.h>
2020

2121
#include <chrono>
2222
#include <thread>
@@ -40,7 +40,7 @@ void CruMemoryHandler::teardown()
4040
}
4141
}
4242

43-
void CruMemoryHandler::init(FairMQUnmanagedRegion* pDataRegion, std::size_t pSuperPageSize)
43+
void CruMemoryHandler::init(fair::mq::UnmanagedRegion* pDataRegion, std::size_t pSuperPageSize)
4444
{
4545
mSuperpageSize = pSuperPageSize;
4646
mDataRegion = pDataRegion;

src/ReadoutEmulator/CruMemoryHandler.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
#include "Headers/DataHeader.h"
1818

19-
#include <fairmq/FairMQUnmanagedRegion.h>
19+
#include <fairmq/UnmanagedRegion.h>
2020

2121
#include <stack>
2222
#include <map>
@@ -43,7 +43,7 @@ struct CRUSuperpage {
4343
};
4444

4545
struct CruDmaPacket {
46-
FairMQUnmanagedRegion* mDataSHMRegion = nullptr;
46+
fair::mq::UnmanagedRegion* mDataSHMRegion = nullptr;
4747
char* mDataPtr = nullptr;
4848
size_t mDataSize = size_t(0);
4949
};
@@ -62,7 +62,7 @@ class CruMemoryHandler
6262
teardown();
6363
}
6464

65-
void init(FairMQUnmanagedRegion* pDataRegion, std::size_t pSuperPageSize);
65+
void init(fair::mq::UnmanagedRegion* pDataRegion, std::size_t pSuperPageSize);
6666
void teardown();
6767

6868
std::size_t getSuperpageSize() const
@@ -117,7 +117,7 @@ class CruMemoryHandler
117117
}
118118

119119
private:
120-
FairMQUnmanagedRegion* mDataRegion;
120+
fair::mq::UnmanagedRegion* mDataRegion;
121121

122122
std::size_t mSuperpageSize;
123123

src/ReadoutEmulator/ReadoutDevice.cxx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313

1414
#include <ReadoutDataModel.h>
1515

16-
#include <options/FairMQProgOptions.h>
16+
#include <fairmq/ProgOptions.h>
1717

1818
#include <chrono>
1919
#include <thread>
@@ -60,7 +60,7 @@ void ReadoutDevice::InitTask()
6060
mDataRegion = NewUnmanagedRegionFor(
6161
mOutChannelName, 0,
6262
mDataRegionSize + mSuperpageSize,
63-
[this](const std::vector<FairMQRegionBlock>& pBlkVect) { // callback to be called when message buffers no longer needed by transport
63+
[this](const std::vector<fair::mq::RegionBlock>& pBlkVect) { // callback to be called when message buffers no longer needed by transport
6464
for (const auto &lBlk : pBlkVect) {
6565
mCruMemoryHandler->put_data_buffer(static_cast<char*>(lBlk.ptr), lBlk.size);
6666
}

src/ReadoutEmulator/ReadoutDevice.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,8 @@ class ReadoutDevice : public DataDistDevice
5757
void SendingThread();
5858

5959
// data and Descriptor regions
60-
// must be here because NewUnmanagedRegionFor() is a method of FairMQDevice...
61-
FairMQUnmanagedRegionPtr mDataRegion;
60+
// must be here because NewUnmanagedRegionFor() is a method of fair::mq::Device...
61+
fair::mq::UnmanagedRegionPtr mDataRegion;
6262

6363
std::string mOutChannelName;
6464
std::size_t mDataRegionSize;
@@ -75,7 +75,7 @@ class ReadoutDevice : public DataDistDevice
7575
std::vector<std::unique_ptr<CruLinkEmulator>> mCruLinks;
7676

7777
// messages to send
78-
std::vector<FairMQMessagePtr> mDataBlockMsgs;
78+
std::vector<fair::mq::MessagePtr> mDataBlockMsgs;
7979
std::thread mSendingThread;
8080

8181
/// Observables

src/ReadoutEmulator/runReadoutEmulatorDevice.cxx

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,7 @@
1010

1111
#include "ReadoutDevice.h"
1212

13-
#include <options/FairMQProgOptions.h>
14-
15-
#include "runFairMQDevice.h"
13+
#include <fairmq/runDevice.h>
1614

1715
namespace bpo = boost::program_options;
1816
template class std::basic_string<char, std::char_traits<char>, std::allocator<char> >; // Workaround for bug in CC7 devtoolset7
@@ -40,7 +38,7 @@ void addCustomOptions(bpo::options_description& options)
4038
"Input throughput per link (bits per second).");
4139
}
4240

43-
FairMQDevicePtr getDevice(const FairMQProgOptions& /*config*/)
41+
std::unqiue_ptr<fair::mq::Device> getDevice(FairMQProgOptions& /*config*/)
4442
{
45-
return new o2::DataDistribution::ReadoutDevice();
43+
return std::make_unique<o2::DataDistribution::ReadoutDevice>();
4644
}

src/StfBuilder/StfBuilderDevice.cxx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323

2424
#include <Headers/DataHeader.h>
2525

26-
#include <options/FairMQProgOptions.h>
26+
#include <fairmq/ProgOptions.h>
2727

2828
#include <chrono>
2929
#include <thread>

src/StfBuilder/StfBuilderInput.cxx

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
#include <DataDistLogger.h>
2222
#include <DataDistributionOptions.h>
2323

24-
#include <FairMQDevice.h>
24+
#include <fairmq/Device.h>
2525

2626
#include <vector>
2727
#include <queue>
@@ -37,7 +37,7 @@ void StfInputInterface::start(bool pBuildStf, std::shared_ptr<ConsulStfBuilder>
3737
mBuildStf = pBuildStf;
3838
mDiscoveryConfig = pStfBuilderConfig;
3939

40-
mBuilderInputQueue = std::make_unique<ConcurrentFifo<std::vector<FairMQMessagePtr>>>();
40+
mBuilderInputQueue = std::make_unique<ConcurrentFifo<std::vector<fair::mq::MessagePtr>>>();
4141
mStfBuilder = std::make_unique<SubTimeFrameReadoutBuilder>(mDevice.MemI());
4242

4343
// sequence thread only needed when building physics STFs
@@ -87,7 +87,7 @@ mRunning = false;
8787
void StfInputInterface::StfReceiverThread()
8888
{
8989
using namespace std::chrono_literals;
90-
std::vector<FairMQMessagePtr> lReadoutMsgs;
90+
std::vector<fair::mq::MessagePtr> lReadoutMsgs;
9191
lReadoutMsgs.reserve(4096);
9292

9393
// Reference to the input channel
@@ -191,7 +191,7 @@ void StfInputInterface::StfBuilderThread()
191191
using namespace std::chrono_literals;
192192

193193
bool lStarted = false;
194-
std::vector<FairMQMessagePtr> lReadoutMsgs;
194+
std::vector<fair::mq::MessagePtr> lReadoutMsgs;
195195
lReadoutMsgs.reserve(1U << 20);
196196

197197
// support FEEID masking
@@ -217,7 +217,7 @@ void StfInputInterface::StfBuilderThread()
217217
// insert and mask the feeid
218218
auto lInsertWithFeeIdMasking = [&lStfBuilder, lFeeIdMask] (const header::DataOrigin &pDataOrigin,
219219
const header::DataHeader::SubSpecificationType &pSubSpec, const ReadoutSubTimeframeHeader &pRdoHeader,
220-
const FairMQParts::iterator pStartHbf, const std::size_t pInsertCnt) {
220+
const fair::mq::Parts::iterator pStartHbf, const std::size_t pInsertCnt) {
221221

222222
// mask the subspecification if the fee mode is used
223223
auto lMaskedSubspec = pSubSpec;
@@ -402,7 +402,7 @@ void StfInputInterface::TopologicalStfBuilderThread()
402402
using namespace std::chrono_literals;
403403

404404
bool lStarted = false;
405-
std::vector<FairMQMessagePtr> lReadoutMsgs(1U << 20);
405+
std::vector<fair::mq::MessagePtr> lReadoutMsgs(1U << 20);
406406
lReadoutMsgs.clear();
407407

408408
// per equipment data cache
@@ -447,7 +447,7 @@ void StfInputInterface::TopologicalStfBuilderThread()
447447
const header::DataOrigin &pDataOrigin,
448448
const header::DataHeader::SubSpecificationType &pSubSpec,
449449
const ReadoutSubTimeframeHeader &pRdoHeader,
450-
FairMQParts::iterator &pStartHbf /* in/out */,
450+
fair::mq::Parts::iterator &pStartHbf /* in/out */,
451451
std::size_t &pInsertCnt /* in/out */) -> std::optional<std::unique_ptr<SubTimeFrame> > {
452452

453453
// mask the subspecification if the fee mode is used

src/StfBuilder/StfBuilderInput.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ class StfInputInterface
7777
std::thread mInputThread;
7878

7979
/// StfBuilding thread and queues
80-
std::unique_ptr<ConcurrentFifo<std::vector<FairMQMessagePtr>>> mBuilderInputQueue = nullptr;
80+
std::unique_ptr<ConcurrentFifo<std::vector<fair::mq::MessagePtr>>> mBuilderInputQueue = nullptr;
8181
std::unique_ptr<SubTimeFrameReadoutBuilder> mStfBuilder = nullptr;
8282
std::uint32_t mStfIdBuilding = 0;
8383
std::thread mBuilderThread;

0 commit comments

Comments
 (0)