Skip to content

Commit 4b19e59

Browse files
committed
ucx: check for completion before going to sleep
1 parent febfed0 commit 4b19e59

File tree

2 files changed

+181
-132
lines changed

2 files changed

+181
-132
lines changed

src/TfBuilder/TfBuilderInputUCX.cxx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,7 @@ void TfBuilderInputUCX::ListenerThread()
204204

205205
bool TfBuilderInputUCX::start()
206206
{
207-
DDDLOG("TfBuilderInputUCX::start()");
207+
DDDLOG("TfBuilderInputUCX::start");
208208
// setting configuration options
209209
mThreadPoolSize = std::clamp(mConfig->getUInt64Param(UcxTfBuilderThreadPoolSizeKey, UcxTfBuilderThreadPoolSizeDefault), std::size_t(1), std::size_t(256));
210210
mRdmaPollingWait = mConfig->getBoolParam(UcxPollForRDMACompletionKey, UcxPollForRDMACompletionDefault);
@@ -245,7 +245,7 @@ bool TfBuilderInputUCX::start()
245245
return false;
246246
}
247247
// register the am handler for stf meta
248-
DDDLOG("ListenerThread: ucx::util::register_am_callback() ...");
248+
DDDLOG("TfBuilderInputUCX::start: ucx::util::register_am_callback() ...");
249249
if (!ucx::util::register_am_callback(mDataWorkers.back(), ucx::io::AM_STF_META, ucp_am_data_cb, this)) {
250250
return false;
251251
}
@@ -276,7 +276,7 @@ bool TfBuilderInputUCX::start()
276276
listen_conn_handle_cb, &dd_ucp_listen_context)) {
277277
return false;
278278
}
279-
DDDLOG("TfBuilderInputUCX::start(): ucp_listener created.");
279+
DDDLOG("TfBuilderInputUCX::start: ucp_listener created.");
280280

281281
// Start the Listener thread
282282
mListenerThread = create_thread_member("ucx_listener", &TfBuilderInputUCX::ListenerThread, this);
@@ -773,7 +773,7 @@ void TfBuilderInputUCX::DataHandlerThread(const unsigned pThreadIdx)
773773
clock::time_point lRmaGetStart = clock::now();
774774
{
775775
if (!lStfMeta.stf_txg_iov().empty()) {
776-
ucx::io::dd_ucp_multi_req_v2 lRmaReqSem;
776+
ucx::io::dd_ucp_multi_req lRmaReqSem;
777777

778778
auto lRunRdmaLoop = [&]() -> void {
779779
// It's safe to use shared key lock because preprocess thread created required keys for this stf

0 commit comments

Comments
 (0)