From b09e6808382c5ed6373174058ab457b63d72dd08 Mon Sep 17 00:00:00 2001 From: Barbara Chytla Date: Sun, 3 Aug 2025 22:18:09 +0200 Subject: [PATCH 1/2] Removing double QA histos, unused valiable, changing comments --- .../Core/FemtoUniverseCascadeSelection.h | 14 ++++---- ...toUniversePairTaskTrackCascadeExtended.cxx | 32 +++++-------------- 2 files changed, 15 insertions(+), 31 deletions(-) diff --git a/PWGCF/FemtoUniverse/Core/FemtoUniverseCascadeSelection.h b/PWGCF/FemtoUniverse/Core/FemtoUniverseCascadeSelection.h index 3a389da705e..ff8206ea551 100644 --- a/PWGCF/FemtoUniverse/Core/FemtoUniverseCascadeSelection.h +++ b/PWGCF/FemtoUniverse/Core/FemtoUniverseCascadeSelection.h @@ -252,9 +252,9 @@ class FemtoUniverseCascadeSelection femto_universe_selection::kLowerLimit, // cascade tran rad min femto_universe_selection::kUpperLimit, // cascade tran rad max femto_universe_selection::kUpperLimit, // cascade maximum distance of decay vertex to PV - femto_universe_selection::kLowerLimit, // DCA pos to PV max - femto_universe_selection::kLowerLimit, // DCA neg to PV max - femto_universe_selection::kLowerLimit, // DCA bach to PV max + femto_universe_selection::kLowerLimit, // DCA pos to PV min + femto_universe_selection::kLowerLimit, // DCA neg to PV min + femto_universe_selection::kLowerLimit, // DCA bach to PV min femto_universe_selection::kLowerLimit, // DCA v0 to PV max femto_universe_selection::kLowerLimit, // v0 mass min femto_universe_selection::kUpperLimit, // v0 mass max @@ -276,10 +276,10 @@ class FemtoUniverseCascadeSelection "Minimum cascade transverse radius (cm)", "Maximum cascade transverse radius (cm)", "Maximum distance of cascade from primary vertex", - "Maximum DCA of positive track form primary vertex", - "Maximum DCA of negative track form primary vertex", - "Maximum DCA of bachelor track form primary vertex", - "Maximum DCA of v0 form primary vertex", + "Minimum DCA of positive track form primary vertex", + "Minimum DCA of negative track form primary vertex", + "Minimum DCA of bachelor track form primary vertex", + "Minimum DCA of v0 form primary vertex", "Minimum V0 mass", "Maximum V0 mass"}; ///< Helper information for the ///< different selections diff --git a/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx b/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx index 11d1bf2418e..fd4f20701db 100644 --- a/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx +++ b/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx @@ -54,7 +54,6 @@ struct femtoUniversePairTaskTrackCascadeExtended { ConfigurableAxis confChildTempFitVarBins{"confChildTempFitVarBins", {300, -0.15, 0.15}, "V0 child: binning of the TempFitVar in the pT vs. TempFitVar plot"}; Configurable confCascInvMassLowLimit{"confCascInvMassLowLimit", 1.315, "Lower limit of the Casc invariant mass"}; Configurable confCascInvMassUpLimit{"confCascInvMassUpLimit", 1.325, "Upper limit of the Casc invariant mass"}; - Configurable confCascTranRad{"confCascTranRad", 0.5, "Cascade transverse radius"}; Configurable confNSigmaTPCPion{"confNSigmaTPCPion", 4, "NSigmaTPCPion"}; Configurable confNSigmaTPCProton{"confNSigmaTPCProton", 4, "NSigmaTPCProton"}; @@ -299,29 +298,18 @@ struct femtoUniversePairTaskTrackCascadeExtended { } } - void processCascades([[maybe_unused]] const FilteredFDCollision& col, const FemtoFullParticles& parts, const aod::FDCascParticles& fdcascs) + void processCascadeQA([[maybe_unused]] const FilteredFDCollision& col, const FemtoFullParticles& parts, const aod::FDCascParticles& fdcascs) { - // auto groupCascs = cascs->sliceByCached(aod::femtouniverseparticle::fdCollisionId, col.globalIndex(), cache); - // const int multCol = col.multNtr(); - for (const auto& casc : fdcascs) { const auto& part = casc.fdParticle_as(); rXiQA.fill(HIST("hMassXi"), part.mLambda()); - // if (!invMCascade(casc.mLambda(), casc.mAntiLambda())) - // continue; - const auto& posChild = parts.iteratorAt(part.globalIndex() - 3 - parts.begin().globalIndex()); const auto& negChild = parts.iteratorAt(part.globalIndex() - 2 - parts.begin().globalIndex()); const auto& bachelor = parts.iteratorAt(part.globalIndex() - 1 - parts.begin().globalIndex()); - // if (casc.transRadius() < confCascTranRad) - // continue; - // std::cout< confNSigmaTPCProton) { continue; @@ -356,13 +344,9 @@ struct femtoUniversePairTaskTrackCascadeExtended { rXiQA.fill(HIST("hDcaBachtoPV"), casc.dcabachtopv()); rXiQA.fill(HIST("hDcaV0toPV"), casc.dcav0topv()); rXiQA.fill(HIST("hInvMpT"), part.pt(), part.mLambda()); - - posChildHistos.fillQA(posChild); - negChildHistos.fillQA(negChild); - bachHistos.fillQABase(bachelor, HIST("hBachelor")); } } - PROCESS_SWITCH(femtoUniversePairTaskTrackCascadeExtended, processCascades, "Enable processing cascades", false); + PROCESS_SWITCH(femtoUniversePairTaskTrackCascadeExtended, processCascadeQA, "Enable processing cascades", false); template using hasSigma = decltype(std::declval().tpcNSigmaStorePr()); @@ -383,11 +367,6 @@ struct femtoUniversePairTaskTrackCascadeExtended { if (!invMCascade(part.mLambda(), part.mAntiLambda(), confCascType1)) /// mLambda stores Xi mass, mAntiLambda stores Omega mass continue; - if constexpr (std::experimental::is_detected::value) - cascQAHistos.fillQA(part); - else - cascQAHistos.fillQA(part); - const auto& posChild = parts.iteratorAt(part.globalIndex() - 3 - parts.begin().globalIndex()); const auto& negChild = parts.iteratorAt(part.globalIndex() - 2 - parts.begin().globalIndex()); const auto& bachelor = parts.iteratorAt(part.globalIndex() - 1 - parts.begin().globalIndex()); @@ -409,6 +388,11 @@ struct femtoUniversePairTaskTrackCascadeExtended { if ((!confCheckTOFBachelorOnly && ((posChild.pidCut() & (8u << CascChildTable[confCascType1][0])) == 0 || (negChild.pidCut() & (8u << CascChildTable[confCascType1][1])) == 0)) || (bachelor.pidCut() & (8u << CascChildTable[confCascType1][2])) == 0) continue; + if constexpr (std::experimental::is_detected::value) + cascQAHistos.fillQA(part); + else + cascQAHistos.fillQA(part); + posChildHistos.fillQA(posChild); negChildHistos.fillQA(negChild); bachHistos.fillQABase(bachelor, HIST("hBachelor")); From da06be3aafad26a083da25dcd8e849a080eeefd7 Mon Sep 17 00:00:00 2001 From: ALICE Action Bot Date: Sun, 3 Aug 2025 20:22:10 +0000 Subject: [PATCH 2/2] Please consider the following formatting changes --- .../Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx | 1 - 1 file changed, 1 deletion(-) diff --git a/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx b/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx index fd4f20701db..63decd49fbe 100644 --- a/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx +++ b/PWGCF/FemtoUniverse/Tasks/femtoUniversePairTaskTrackCascadeExtended.cxx @@ -308,7 +308,6 @@ struct femtoUniversePairTaskTrackCascadeExtended { const auto& negChild = parts.iteratorAt(part.globalIndex() - 2 - parts.begin().globalIndex()); const auto& bachelor = parts.iteratorAt(part.globalIndex() - 1 - parts.begin().globalIndex()); - // nSigma selection for daughter and bachelor tracks if (part.sign() < 0) { if (std::abs(posChild.tpcNSigmaPr()) > confNSigmaTPCProton) {