From 3adf4d2a130a0db9754d737d259561b1c63a2a5e Mon Sep 17 00:00:00 2001 From: Mikhail Filimonov Date: Tue, 14 Oct 2025 00:35:27 +0200 Subject: [PATCH 1/2] looked like a bug... --- src/Storages/ObjectStorage/DataLakes/IDataLakeMetadata.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Storages/ObjectStorage/DataLakes/IDataLakeMetadata.cpp b/src/Storages/ObjectStorage/DataLakes/IDataLakeMetadata.cpp index 4a1a09969d99..f524d946a8af 100644 --- a/src/Storages/ObjectStorage/DataLakes/IDataLakeMetadata.cpp +++ b/src/Storages/ObjectStorage/DataLakes/IDataLakeMetadata.cpp @@ -141,9 +141,9 @@ void DataFileMetaInfo::serialize(WriteBuffer & out) const size_t field_mask = 0; if (column.second.rows_count.has_value()) field_mask |= FIELD_MASK_ROWS; - if (column.second.rows_count.has_value()) + if (column.second.nulls_count.has_value()) field_mask |= FIELD_MASK_NULLS; - if (column.second.rows_count.has_value()) + if (column.second.hyperrectangle.has_value()) field_mask |= FIELD_MASK_RECT; writeIntBinary(field_mask, out); From a732f751543c3adb622038c43e64751d9f7eed8e Mon Sep 17 00:00:00 2001 From: Mikhail Filimonov Date: Tue, 14 Oct 2025 00:34:16 +0200 Subject: [PATCH 2/2] maybe fix fast build --- .../DataLakes/Iceberg/ManifestFile.h | 25 +++++++++++++------ 1 file changed, 17 insertions(+), 8 deletions(-) diff --git a/src/Storages/ObjectStorage/DataLakes/Iceberg/ManifestFile.h b/src/Storages/ObjectStorage/DataLakes/Iceberg/ManifestFile.h index 0bfdb758ee22..97098811c015 100644 --- a/src/Storages/ObjectStorage/DataLakes/Iceberg/ManifestFile.h +++ b/src/Storages/ObjectStorage/DataLakes/Iceberg/ManifestFile.h @@ -1,6 +1,23 @@ #pragma once #include "config.h" +#include +#include + +#include + +namespace DB::Iceberg +{ + +struct ColumnInfo +{ + std::optional rows_count; + std::optional bytes_size; + std::optional nulls_count; + std::optional hyperrectangle; +}; + +} #if USE_AVRO @@ -38,14 +55,6 @@ enum class ManifestFileContentType String FileContentTypeToString(FileContentType type); -struct ColumnInfo -{ - std::optional rows_count; - std::optional bytes_size; - std::optional nulls_count; - std::optional hyperrectangle; -}; - struct PartitionSpecsEntry { Int32 source_id;