From a6cf920671f764c4333bafd38c7670e97fa97751 Mon Sep 17 00:00:00 2001 From: Arthur Passos Date: Thu, 6 Mar 2025 20:05:38 -0300 Subject: [PATCH 1/4] Metadata cache on by default part 2 --- src/Core/FormatFactorySettings.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Core/FormatFactorySettings.h b/src/Core/FormatFactorySettings.h index 8b3ed4a56922..c9b515f83f5a 100644 --- a/src/Core/FormatFactorySettings.h +++ b/src/Core/FormatFactorySettings.h @@ -1251,7 +1251,7 @@ Set the quoting rule for identifiers in SHOW CREATE query DECLARE(IdentifierQuotingStyle, show_create_query_identifier_quoting_style, IdentifierQuotingStyle::Backticks, R"( Set the quoting style for identifiers in SHOW CREATE query )", 0) \ - DECLARE(Bool, input_format_parquet_use_metadata_cache, false, R"(Enable parquet file metadata caching)", 1) \ + DECLARE(Bool, input_format_parquet_use_metadata_cache, true, R"(Enable parquet file metadata caching)", 0) \ // End of FORMAT_FACTORY_SETTINGS #define OBSOLETE_FORMAT_SETTINGS(M, ALIAS) \ From 8b25f5297c17a2c3f2b7348afc1ceb0cd49ed4e2 Mon Sep 17 00:00:00 2001 From: Arthur Passos Date: Thu, 6 Mar 2025 20:34:59 -0300 Subject: [PATCH 2/4] Update SettingsChangesHistory.cpp --- src/Core/SettingsChangesHistory.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/Core/SettingsChangesHistory.cpp b/src/Core/SettingsChangesHistory.cpp index 2f3f9c32f7d8..70f62d697cfd 100644 --- a/src/Core/SettingsChangesHistory.cpp +++ b/src/Core/SettingsChangesHistory.cpp @@ -78,6 +78,7 @@ static std::initializer_list Date: Fri, 7 Mar 2025 00:41:56 +0100 Subject: [PATCH 3/4] Update SettingsChangesHistory.cpp --- src/Core/SettingsChangesHistory.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/Core/SettingsChangesHistory.cpp b/src/Core/SettingsChangesHistory.cpp index 70f62d697cfd..1867392b4b97 100644 --- a/src/Core/SettingsChangesHistory.cpp +++ b/src/Core/SettingsChangesHistory.cpp @@ -59,8 +59,10 @@ String ClickHouseVersion::toString() const static std::initializer_list> settings_changes_history_initializer = { {"24.12.2.20000", + // Altinity Antalya modifications { {"input_format_parquet_use_metadata_cache", false, false, "New setting"}, // https://github.com/Altinity/ClickHouse/pull/586 + {"input_format_parquet_use_metadata_cache", false, true, "Turn optimization ON by default"}, } }, {"24.12", @@ -78,7 +80,6 @@ static std::initializer_list Date: Fri, 7 Mar 2025 00:42:55 +0100 Subject: [PATCH 4/4] Update SettingsChangesHistory.cpp --- src/Core/SettingsChangesHistory.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/Core/SettingsChangesHistory.cpp b/src/Core/SettingsChangesHistory.cpp index 1867392b4b97..1ec6ac0090e0 100644 --- a/src/Core/SettingsChangesHistory.cpp +++ b/src/Core/SettingsChangesHistory.cpp @@ -61,8 +61,7 @@ static std::initializer_list