From 403e883630dddc1634a97f79d3547301b2ec451b Mon Sep 17 00:00:00 2001 From: Charlie Kim Date: Tue, 22 Feb 2022 11:35:08 -0500 Subject: [PATCH 1/4] comment out id in AoSIPPool ip_pool --- aos/resources.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/aos/resources.py b/aos/resources.py index 8fd7093..6b8634f 100644 --- a/aos/resources.py +++ b/aos/resources.py @@ -71,7 +71,7 @@ def create( "subnets": [{"network": net} for net in subnets], "tags": tags, "display_name": name, - "id": name, + # "id": name, # generate to be compliant } created = self.rest.json_resp_post("/api/resources/ip-pools", data=ip_pool) From aa8230f96fabbba5f3e11df1d520ec35683b9c3d Mon Sep 17 00:00:00 2001 From: Charlie Kim Date: Tue, 22 Feb 2022 11:45:49 -0500 Subject: [PATCH 2/4] The method put has zero data with status_code 204 --- aos/aos.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/aos/aos.py b/aos/aos.py index 5b9b69e..2440651 100644 --- a/aos/aos.py +++ b/aos/aos.py @@ -122,6 +122,8 @@ def raw_request_json(self, method, uri, params, data, headers): try: if method == "GET" and resp.status_code == 404: return None + if method == "PUT" and resp.status_code == 204: + return None if resp.ok: return resp.json() except (TypeError, ValueError) as e: From a2e54d96bba6c7b9265c763a0d61f723d1f17543 Mon Sep 17 00:00:00 2001 From: Charlie Kim Date: Tue, 22 Feb 2022 12:21:49 -0500 Subject: [PATCH 3/4] increase the version number --- setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.py b/setup.py index 5080078..c96da54 100644 --- a/setup.py +++ b/setup.py @@ -9,7 +9,7 @@ NAME = "aos-api-client" -VERSION = '0.1.8' +VERSION = '0.1.9' REQUIRES = (["requests==2.24.0"],) From 543e1efe7b4e7f5bf5e27e3366b2556170721297 Mon Sep 17 00:00:00 2001 From: Charlie Kim Date: Wed, 23 Feb 2022 10:03:39 -0500 Subject: [PATCH 4/4] id takes name with space replaced. --- aos/resources.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/aos/resources.py b/aos/resources.py index 6b8634f..fd90d6c 100644 --- a/aos/resources.py +++ b/aos/resources.py @@ -71,7 +71,7 @@ def create( "subnets": [{"network": net} for net in subnets], "tags": tags, "display_name": name, - # "id": name, # generate to be compliant + "id": name.replace(' ', '-'), } created = self.rest.json_resp_post("/api/resources/ip-pools", data=ip_pool)