Better handling of large files

Author: Aptimex

README.md

@@ -4,7 +4,7 @@ Relatively simple Python server that accepts POST and PUT requests and saves the
 
 If a path is specified in the request, the part after the final `/` (minus any URL parameters or such) will be treated as the filename that it should be saved to. For example:
 ```
-POST http://1.2.3.4:8123/stuff/myFile.txt?hello=garbage
+POST http://1.2.3.4:8123/stuff/myFile.txt?param=anything
 ```
 will cause the file to be saved to `myFile.txt`. 
 
@@ -43,7 +43,7 @@ Invoke-WebRequest -Uri http://1.2.3.4:8080/differentName.bin?mySecretParam -Meth
 
 Send a file to the server using curl:
 ```bash
-curl -T ./myFile.bin http://1.2.3.4:8080/differentName.bin?mySecretParam
+curl -T ./myFile.bin 1.2.3.4:8080/differentName.bin?mySecretParam
 ```
 - Also works with `curl.exe` on recent versions of Windows
 

upload-server.py

@@ -7,8 +7,13 @@
 from urllib.parse import urlparse, parse_qs
 from http.server import HTTPServer, BaseHTTPRequestHandler, SimpleHTTPRequestHandler
 
+# SECRET is set dynamically at runtime with -s
 SECRET = None
 
+# PART_SIZE is hardcoded; writes out larger files in chunks of this size to limit memory usage 
+# This also significantly speeds up large transfers, but idk why
+PART_SIZE = 256 * 1024 * 1024 #256MB
+
 class CustomHTTPRequestHandler(SimpleHTTPRequestHandler):
 
     # Ignore all GETs
@@ -54,13 +59,24 @@ def do_POST(self):
             else:
                 filePath = f"{filePath}_{i}"
 
-        # Write the request body 
+        # Write the request body to a file
         with open(filePath, 'wb') as output_file:
-            output_file.write(self.rfile.read(file_length))
+            print(f"Recieving file '{filename}' with size {file_length} from {self.client_address[0]}")
+            
+            numParts = file_length // PART_SIZE
+            if file_length % PART_SIZE != 0:
+                numParts += 1
+                
+            for i in range(numParts):
+                print(f"Writing part {i+1} of {numParts}")
+                remainingSize = file_length - (i * PART_SIZE)
+                output_file.write(self.rfile.read(min(PART_SIZE, remainingSize)))
+        
         self.send_response(201, 'Created')
         self.end_headers()
 
         print(f"File of size {file_length} bytes saved to {filePath}")
+        print()
 
     # Treat PUT just like POST
     def do_PUT(self):