Skip to content

Commit 2175544

Browse files
committed
Ensure all tests are compiled and diffed regardless of ASC_FEATURES
This change makes ASC_FEATURES only affect whether the instantiate step is executed, and not whether tests are compiled and fixtures checked.
1 parent 3412cef commit 2175544

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

tests/compiler.js

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,6 @@ async function runTest(basename) {
151151
config.features.forEach(feature => {
152152
if (!features.includes(feature) && !features.includes("*")) {
153153
missing_features.push(feature);
154-
return; // from forEach
155154
}
156155
let featureConfig = featuresConfig[feature];
157156
if (featureConfig.asc_flags) {
@@ -166,13 +165,8 @@ async function runTest(basename) {
166165
if (v8_no_flags) v8_no_flags += " ";
167166
v8_no_flags += "--no-" + flag.substring(2);
168167
});
169-
v8.setFlagsFromString(v8_flags);
170168
}
171169
});
172-
if (missing_features.length) {
173-
console.log("- " + stdoutColors.yellow("feature SKIPPED") + " (" + missing_features.join(", ") + ")\n");
174-
return prepareResult(SKIPPED, "feature not enabled: " + missing_features.join(", "));
175-
}
176170
}
177171
if (config.asc_flags) {
178172
config.asc_flags.forEach(flag => { asc_flags.push(...flag.split(" ")); });
@@ -284,6 +278,13 @@ async function runTest(basename) {
284278
}
285279
compileRelease.end(SUCCESS);
286280

281+
if (missing_features.length) {
282+
console.log("- " + stdoutColors.yellow("feature SKIPPED") + " (" + missing_features.join(", ") + ")\n");
283+
return prepareResult(SKIPPED, "feature not enabled: " + missing_features.join(", "));
284+
} else if (v8_flags) {
285+
v8.setFlagsFromString(v8_flags);
286+
}
287+
287288
const debugBuffer = fs.readFileSync(path.join(basedir, basename + ".debug.wasm"));
288289
const releaseBuffer = stdout.toBuffer();
289290
const instantiateDebug = section("instantiate debug");

0 commit comments

Comments
 (0)