Don't skip property initialization

Don not skip property initialization even if expected to be initialized
at the constructor level

Author: saulecabrera

src/compiler.ts

@@ -10181,8 +10181,9 @@ export class Compiler extends DiagnosticEmitter {
       let parameterIndex = fieldPrototype.parameterIndex;
       let typeNode = field.typeNode;
       if (typeNode) this.checkTypeSupported(fieldType, typeNode);
-      let initExpr: ExpressionRef = -1;
+      let initExpr: ExpressionRef = 0;
       const isDefiniteAssigment = field.is(CommonFlags.DEFINITE_ASSIGNMENT);
+      let definitelyInitialized = false;
 
       // if declared as a constructor parameter, use its value
       if (parameterIndex >= 0) {
@@ -10193,6 +10194,7 @@ export class Compiler extends DiagnosticEmitter {
           nativeFieldType
         );
         if (fieldType.isManaged) initExpr = this.makeRetain(initExpr);
+        definitelyInitialized = true;
 
       // fall back to use initializer if present
       } else if (initializerNode) {
@@ -10202,20 +10204,25 @@ export class Compiler extends DiagnosticEmitter {
         if (fieldType.isManaged && !this.skippedAutoreleases.has(initExpr)) {
           initExpr = this.makeRetain(initExpr);
         }
-      } else if (isDefiniteAssigment) {
+        definitelyInitialized = true;
+      } else {
         // otherwise initialize with default if marked as definite assigment
+        if (isDefiniteAssigment) {
+          definitelyInitialized = true;
+        }
         initExpr = this.makeZero(fieldType);
       }
 
-      if (initExpr >= 0) {
-        stmts.push(
-          module.store(fieldType.byteSize,
-            module.local_get(thisLocalIndex, nativeSizeType),
-            initExpr,
-            nativeFieldType,
-            field.memoryOffset
-          )
-        );
+      stmts.push(
+        module.store(fieldType.byteSize,
+          module.local_get(thisLocalIndex, nativeSizeType),
+          initExpr,
+          nativeFieldType,
+          field.memoryOffset
+        )
+      );
+
+      if (definitelyInitialized) {
         flow.setFieldFlag(field.internalName, FieldFlags.INITIALIZED);
       } else {
         flow.setFieldFlag(field.internalName, FieldFlags.NONE);

tests/compiler/class.optimized.wat

@@ -131,6 +131,18 @@
   i32.const 5
   call $~lib/rt/stub/__alloc
   local.tee $0
+  i32.const 0
+  i32.store
+  local.get $0
+  i32.const 0
+  i32.store offset=4
+  local.get $0
+  i32.const 0
+  i32.store offset=8
+  local.get $0
+  i32.const 0
+  i32.store offset=12
+  local.get $0
   i32.load
   drop
   local.get $0

tests/compiler/class.untouched.wat

@@ -479,6 +479,18 @@
    local.set $0
   end
   local.get $0
+  i32.const 0
+  i32.store
+  local.get $0
+  i32.const 0
+  i32.store offset=4
+  local.get $0
+  i32.const 0
+  i32.store offset=8
+  local.get $0
+  i32.const 0
+  i32.store offset=12
+  local.get $0
   local.tee $4
   local.get $3
   local.tee $5

tests/compiler/inlining.optimized.wat

@@ -122,12 +122,18 @@
   i32.const 1
   i32.store
   local.get $0
+  i32.const 0
+  i32.store offset=4
+  local.get $0
   i32.const 2
   i32.store offset=4
   local.get $0
   i32.const 3
   i32.store offset=8
   local.get $0
+  i32.const 0
+  i32.store offset=12
+  local.get $0
   i32.const 4
   i32.store offset=12
   local.get $0

tests/compiler/inlining.untouched.wat

@@ -422,6 +422,9 @@
   i32.const 1
   i32.store
   local.get $3
+  i32.const 0
+  i32.store offset=4
+  local.get $3
   local.get $2
   i32.store offset=4
   local.get $3
@@ -430,6 +433,9 @@
   i32.const 3
   i32.store offset=8
   local.get $1
+  i32.const 0
+  i32.store offset=12
+  local.get $1
   local.get $0
   i32.store offset=12
   local.get $1

tests/compiler/resolve-elementaccess.optimized.wat

@@ -321,6 +321,15 @@
    local.set $0
   end
   local.get $0
+  i32.const 0
+  i32.store
+  local.get $0
+  i32.const 0
+  i32.store offset=4
+  local.get $0
+  i32.const 0
+  i32.store offset=8
+  local.get $0
   i32.load
   drop
   local.get $0

tests/compiler/resolve-elementaccess.untouched.wat

@@ -413,6 +413,15 @@
    local.set $0
   end
   local.get $0
+  i32.const 0
+  i32.store
+  local.get $0
+  i32.const 0
+  i32.store offset=4
+  local.get $0
+  i32.const 0
+  i32.store offset=8
+  local.get $0
   local.tee $4
   local.get $3
   local.tee $5