refuse to export builtin functions

Author: dcodeIO

lib/loader/tests/build/default.wasm

@@ -19,7 +19,7 @@ function test(file) {
 
   // should export memory
   assert(exports.memory instanceof WebAssembly.Memory);
-  assert(typeof exports.memory.copy === "function");
+  assert(typeof exports.memory.compare === "function");
 
   // should be able to get an exported string
   assert.strictEqual(exports.__getString(exports.COLOR), "red");

lib/loader/tests/build/legacy.wasm

@@ -713,13 +713,15 @@ export class Compiler extends DiagnosticEmitter {
       }
       case ElementKind.FUNCTION: {
         let functionInstance = <Function>element;
-        let signature = functionInstance.signature;
-        if (signature.requiredParameters < signature.parameterTypes.length) {
-          // utilize trampoline to fill in omitted arguments
-          functionInstance = this.ensureTrampoline(functionInstance);
-          this.ensureBuiltinArgumentsLength();
+        if (!functionInstance.hasDecorator(DecoratorFlags.BUILTIN)) {
+          let signature = functionInstance.signature;
+          if (signature.requiredParameters < signature.parameterTypes.length) {
+            // utilize trampoline to fill in omitted arguments
+            functionInstance = this.ensureTrampoline(functionInstance);
+            this.ensureBuiltinArgumentsLength();
+          }
+          if (functionInstance.is(CommonFlags.COMPILED)) this.module.addFunctionExport(functionInstance.internalName, prefix + name);
         }
-        if (functionInstance.is(CommonFlags.COMPILED)) this.module.addFunctionExport(functionInstance.internalName, prefix + name);
         break;
       }
       case ElementKind.PROPERTY: {

lib/loader/tests/index.js

@@ -290,8 +290,8 @@ export abstract class DiagnosticEmitter {
     if (range) message = message.withRange(range);
     if (relatedRange) message.relatedRange = relatedRange;
     this.diagnostics.push(message);
-    // console.log(formatDiagnosticMessage(message, true, true) + "\n"); // temporary
-    // console.log(<string>new Error("stack").stack);
+    console.log(formatDiagnosticMessage(message, true, true) + "\n"); // temporary
+    console.log(<string>new Error("stack").stack);
   }
 
   /** Emits an overly pedantic diagnostic message. */