temp

Author: DuncanUszkay1

src/compiler.ts

@@ -1716,19 +1716,15 @@ export class Compiler extends DiagnosticEmitter {
     var type = instance.type;
     var nativeThisType = this.options.nativeSizeType;
     var nativeValueType = type.toNativeType();
-    var varTypes: NativeType[] | null = null;
     var module = this.module;
     var valueExpr = module.load(type.byteSize, type.is(TypeFlags.SIGNED),
       module.local_get(0, nativeThisType),
       nativeValueType, instance.memoryOffset
     );
 
-    if (type.isManaged) {
-      valueExpr = this.makeRetain(valueExpr, type);
-      varTypes = [ NativeType.I32 ];
-    }
+    if (type.isManaged) this.makeRetain(valueExpr, type);
 
-    instance.getterRef = module.addFunction(instance.internalGetterName, nativeThisType, nativeValueType, varTypes, valueExpr);
+    instance.getterRef = module.addFunction(instance.internalGetterName, nativeThisType, nativeValueType, null, valueExpr);
     if (instance.setterRef) {
       instance.set(CommonFlags.COMPILED);
     } else {
@@ -1748,7 +1744,7 @@ export class Compiler extends DiagnosticEmitter {
     var valueExpr: ExpressionRef;
     var varTypes: NativeType[] | null = null;
     if (type.isManaged) {
-      // Can't use makeReplace, makeRetain, or makeRelease here since there's no corresponding flow, so
+      // Can't use makeReplace here since there's no corresponding flow, so
       // 0: this, 1: value, 2: oldValue (temp)
       valueExpr = module.block(null, [
         module.if(
@@ -3624,8 +3620,7 @@ export class Compiler extends DiagnosticEmitter {
       var toSignature = toType.signatureReference;
       var fromSignature = fromType.signatureReference;
       if (toSignature !== null && fromSignature !== null && fromSignature.externalEquals(toSignature) && fromType.is(TypeFlags.IN_SCOPE_CLOSURE)) {
-        // When we convert from the closure type into a function pointer, we first
-        // update the local copy of the scope with the newest values
+        // When a closure leaves its initial scope, we copy in the closed over locals one last time
         var tempResult = this.currentFlow.getTempLocal(fromType);
         var convertExpr = module.block(null, [
           module.local_set(