Bump the minimim version of php to 8.0#727
Conversation
alecgeatches
left a comment
alecgeatches
left a comment
There was a problem hiding this comment.
Looks good! We can address the failing e2e tests (unrelated) in #726.
| * License: GPL-3 | ||
| * License URI: https://www.gnu.org/licenses/gpl-3.0.html |
There was a problem hiding this comment.
Was the license change intentional?
composer.json still says GPL v2 or later. What is it?
I'd recommend adding a proper LICENSE file to the repo.
There was a problem hiding this comment.
Thanks for catching that. We meant to make it GPL 3 as some of our other plugins have that already, so we were trying to make it consistent. I'll fix that inconsistency, and add a proper LICENSE file to the repo.
There was a problem hiding this comment.
This was an incorrect decision. A site that uses a GPLv2-only plugin can't legally be allowed to work with a version of Edit-Flow that is GPLv3 only. I've opened #804 to rectify this.
4 participants
Description
Bump the minimum version of php to 8.0, as well as the minimum WP version to 6.0. As a result of this, the packages in
composer.jsonhave been updated and the GH workflow has been modified to run against 8.0/6.0 rather than 7.4/5.9.