From 9d1c62d5be839c98d79efbc93e96b97cd5da048b Mon Sep 17 00:00:00 2001
From: jrfnl <jrfnl@users.noreply.github.com>
Date: Tue, 21 Jul 2020 23:02:04 +0200
Subject: [PATCH] RulesetTest: fix compatibility with Windows

This is probably just needed for me, but when running the ruleset tests locally on Windows, they wouldn't run and would show a `'$PHPCS_BIN' is not recognized as an internal or external command,
operable program or batch file.` error.

By not relying on (linux) CLI variable expansion, but expanding the variable to its real path value and using the literal value within the script, the tests can be run on Windows too.
---
 tests/RulesetTest.php | 18 ++++++++++++++----
 1 file changed, 14 insertions(+), 4 deletions(-)

diff --git a/tests/RulesetTest.php b/tests/RulesetTest.php
index fcf16992..0272ca5b 100644
--- a/tests/RulesetTest.php
+++ b/tests/RulesetTest.php
@@ -67,6 +67,13 @@ class RulesetTest {
 	 */
 	private $ruleset;
 
+	/**
+	 * Path to the PHPCS executable.
+	 *
+	 * @var string
+	 */
+	private $phpcs_bin = 'phpcs';
+
 	/**
 	 * String returned by PHP_CodeSniffer report for an Error.
 	 */
@@ -82,17 +89,20 @@ public function __construct( $ruleset, $expected = [] ) {
 		$this->ruleset  = $ruleset;
 		$this->expected = $expected;
 
-		// Travis support.
-		if ( false === getenv( 'PHPCS_BIN' ) ) {
+		// Travis and Windows support.
+		$phpcs_bin = getenv( 'PHPCS_BIN' );
+		if ( false === $phpcs_bin ) {
 			// phpcs:ignore
 			putenv( 'PHPCS_BIN=phpcs' );
+		} else {
+			$this->phpcs_bin = realpath( $phpcs_bin );
 		}
 
 		$output = $this->collect_phpcs_result();
 
 		if ( ! is_object( $output ) || empty( $output ) ) {
 			// phpcs:ignore WordPress.Security.EscapeOutput.OutputNotEscaped
-			printf( 'The PHPCS command checking the ruleset haven\'t returned any issues. Bailing ...' . PHP_EOL );
+			printf( 'The PHPCS command checking the ruleset hasn\'t returned any issues. Bailing ...' . PHP_EOL );
 			exit( 1 ); // Die early, if we don't have any output.
 		}
 
@@ -128,7 +138,7 @@ private function run() {
 	 * @return array Returns an associative array with keys of `totals` and `files`.
 	 */
 	private function collect_phpcs_result() {
-		$shell = sprintf( '$PHPCS_BIN --severity=1 --standard=%1$s --report=json ./%1$s/ruleset-test.inc', $this->ruleset );
+		$shell = sprintf( '%1$s --severity=1 --standard=%2$s --report=json ./%2$s/ruleset-test.inc', $this->phpcs_bin, $this->ruleset );
 		// phpcs:ignore
 		$output = shell_exec( $shell );