diff --git a/WordPressVIPMinimum/Sniffs/Compatibility/ZoninatorSniff.php b/WordPressVIPMinimum/Sniffs/Compatibility/ZoninatorSniff.php index 7d18a7f5..1dae2b96 100644 --- a/WordPressVIPMinimum/Sniffs/Compatibility/ZoninatorSniff.php +++ b/WordPressVIPMinimum/Sniffs/Compatibility/ZoninatorSniff.php @@ -22,7 +22,7 @@ class ZoninatorSniff extends Sniff { * @return array(int) */ public function register() { - return Tokens::$functionNameTokens; + return [ T_STRING ]; } diff --git a/WordPressVIPMinimum/Sniffs/Functions/CheckReturnValueSniff.php b/WordPressVIPMinimum/Sniffs/Functions/CheckReturnValueSniff.php index a95c2acf..9c7c31db 100644 --- a/WordPressVIPMinimum/Sniffs/Functions/CheckReturnValueSniff.php +++ b/WordPressVIPMinimum/Sniffs/Functions/CheckReturnValueSniff.php @@ -60,7 +60,7 @@ class CheckReturnValueSniff extends Sniff { * @return array(int) */ public function register() { - return Tokens::$functionNameTokens; + return [ T_STRING ]; } /** @@ -86,7 +86,7 @@ public function process_token( $stackPtr ) { */ private function isFunctionCall( $stackPtr ) { - if ( in_array( $this->tokens[ $stackPtr ]['code'], Tokens::$functionNameTokens, true ) === false ) { + if ( $this->tokens[ $stackPtr ]['code'] !== T_STRING ) { return false; } @@ -162,14 +162,14 @@ public function findDirectFunctionCalls( $stackPtr ) { $closeBracket = $this->tokens[ $openBracket ]['parenthesis_closer']; $startNext = $openBracket + 1; - $next = $this->phpcsFile->findNext( Tokens::$functionNameTokens, $startNext, $closeBracket, false, null, true ); + $next = $this->phpcsFile->findNext( T_STRING, $startNext, $closeBracket, false, null, true ); while ( $next ) { if ( in_array( $this->tokens[ $next ]['content'], $this->catch[ $functionName ], true ) === true ) { $message = "`%s`'s return type must be checked before calling `%s` using that value."; $data = [ $this->tokens[ $next ]['content'], $functionName ]; $this->phpcsFile->addError( $message, $next, 'DirectFunctionCall', $data ); } - $next = $this->phpcsFile->findNext( Tokens::$functionNameTokens, $next + 1, $closeBracket, false, null, true ); + $next = $this->phpcsFile->findNext( T_STRING, $next + 1, $closeBracket, false, null, true ); } } @@ -269,7 +269,7 @@ public function findNonCheckedVariables( $stackPtr ) { foreach ( $callees as $callee ) { $notFunctionsCallee = array_key_exists( $callee, $this->notFunctions ) ? (array) $this->notFunctions[ $callee ] : []; // Check whether the found token is one of the function calls (or foreach call) we are interested in. - if ( in_array( $this->tokens[ $nextFunctionCallWithVariable ]['code'], array_merge( Tokens::$functionNameTokens, $notFunctionsCallee ), true ) === true + if ( in_array( $this->tokens[ $nextFunctionCallWithVariable ]['code'], array_merge( [ T_STRING ], $notFunctionsCallee ), true ) === true && $this->tokens[ $nextFunctionCallWithVariable ]['content'] === $callee ) { $this->addNonCheckedVariableError( $nextFunctionCallWithVariable, $variableName, $callee ); @@ -278,7 +278,7 @@ public function findNonCheckedVariables( $stackPtr ) { $search = array_merge( Tokens::$emptyTokens, [ T_EQUAL ] ); $next = $this->phpcsFile->findNext( $search, $nextVariableOccurrence + 1, null, true ); - if ( in_array( $this->tokens[ $next ]['code'], Tokens::$functionNameTokens, true ) === true + if ( $this->tokens[ $next ]['code'] === T_STRING && $this->tokens[ $next ]['content'] === $callee ) { $this->addNonCheckedVariableError( $next, $variableName, $callee ); diff --git a/WordPressVIPMinimum/Sniffs/Hooks/AlwaysReturnInFilterSniff.php b/WordPressVIPMinimum/Sniffs/Hooks/AlwaysReturnInFilterSniff.php index f5ea5734..20ec8ebf 100644 --- a/WordPressVIPMinimum/Sniffs/Hooks/AlwaysReturnInFilterSniff.php +++ b/WordPressVIPMinimum/Sniffs/Hooks/AlwaysReturnInFilterSniff.php @@ -30,7 +30,7 @@ class AlwaysReturnInFilterSniff extends Sniff { * @return array(int) */ public function register() { - return Tokens::$functionNameTokens; + return [ T_STRING ]; } /** @@ -130,7 +130,7 @@ private function processString( $stackPtr, $start = 0, $end = null ) { $callbackFunctionName = substr( $this->tokens[ $stackPtr ]['content'], 1, -1 ); $callbackFunctionPtr = $this->phpcsFile->findNext( - Tokens::$functionNameTokens, + T_STRING, $start, $end, false, diff --git a/WordPressVIPMinimum/Sniffs/Hooks/PreGetPostsSniff.php b/WordPressVIPMinimum/Sniffs/Hooks/PreGetPostsSniff.php index eb1dce4e..a7d4ed6e 100644 --- a/WordPressVIPMinimum/Sniffs/Hooks/PreGetPostsSniff.php +++ b/WordPressVIPMinimum/Sniffs/Hooks/PreGetPostsSniff.php @@ -25,7 +25,7 @@ class PreGetPostsSniff extends Sniff { * @return array(int) */ public function register() { - return Tokens::$functionNameTokens; + return [ T_STRING ]; } /** @@ -120,7 +120,7 @@ private function processString( $stackPtr ) { $callbackFunctionName = substr( $this->tokens[ $stackPtr ]['content'], 1, -1 ); $callbackFunctionPtr = $this->phpcsFile->findNext( - Tokens::$functionNameTokens, + T_STRING, 0, null, false, @@ -394,7 +394,7 @@ private function isWPQueryMethodCall( $stackPtr, $method = null ) { true ); - return $next && in_array( $this->tokens[ $next ]['code'], Tokens::$functionNameTokens, true ) === true && $method === $this->tokens[ $next ]['content']; + return $next && $this->tokens[ $next ]['code'] === T_STRING && $method === $this->tokens[ $next ]['content']; } /** diff --git a/WordPressVIPMinimum/Sniffs/Performance/CacheValueOverrideSniff.php b/WordPressVIPMinimum/Sniffs/Performance/CacheValueOverrideSniff.php index 96696437..806bebef 100644 --- a/WordPressVIPMinimum/Sniffs/Performance/CacheValueOverrideSniff.php +++ b/WordPressVIPMinimum/Sniffs/Performance/CacheValueOverrideSniff.php @@ -29,7 +29,7 @@ class CacheValueOverrideSniff extends Sniff { * @return array(int) */ public function register() { - return Tokens::$functionNameTokens; + return [ T_STRING ]; } @@ -97,10 +97,6 @@ public function process_token( $stackPtr ) { */ private function isFunctionCall( $stackPtr ) { - if ( in_array( $this->tokens[ $stackPtr ]['code'], Tokens::$functionNameTokens, true ) === false ) { - return false; - } - // Find the next non-empty token. $openBracket = $this->phpcsFile->findNext( Tokens::$emptyTokens, $stackPtr + 1, null, true ); diff --git a/WordPressVIPMinimum/Sniffs/Performance/FetchingRemoteDataSniff.php b/WordPressVIPMinimum/Sniffs/Performance/FetchingRemoteDataSniff.php index 62d1d090..e3fc4330 100644 --- a/WordPressVIPMinimum/Sniffs/Performance/FetchingRemoteDataSniff.php +++ b/WordPressVIPMinimum/Sniffs/Performance/FetchingRemoteDataSniff.php @@ -24,7 +24,7 @@ class FetchingRemoteDataSniff extends Sniff { * @return array */ public function register() { - return Tokens::$functionNameTokens; + return [ T_STRING ]; } /** diff --git a/WordPressVIPMinimum/Sniffs/Performance/TaxonomyMetaInOptionsSniff.php b/WordPressVIPMinimum/Sniffs/Performance/TaxonomyMetaInOptionsSniff.php index 071dc641..c9c815be 100644 --- a/WordPressVIPMinimum/Sniffs/Performance/TaxonomyMetaInOptionsSniff.php +++ b/WordPressVIPMinimum/Sniffs/Performance/TaxonomyMetaInOptionsSniff.php @@ -51,7 +51,7 @@ class TaxonomyMetaInOptionsSniff extends Sniff { * @return array */ public function register() { - return Tokens::$functionNameTokens; + return [ T_STRING ]; } /** diff --git a/WordPressVIPMinimum/Sniffs/Security/ExitAfterRedirectSniff.php b/WordPressVIPMinimum/Sniffs/Security/ExitAfterRedirectSniff.php index 5d76976a..dfacc425 100644 --- a/WordPressVIPMinimum/Sniffs/Security/ExitAfterRedirectSniff.php +++ b/WordPressVIPMinimum/Sniffs/Security/ExitAfterRedirectSniff.php @@ -24,7 +24,7 @@ class ExitAfterRedirectSniff extends Sniff { * @return array */ public function register() { - return Tokens::$functionNameTokens; + return [ T_STRING ]; } /** diff --git a/WordPressVIPMinimum/Sniffs/Security/ProperEscapingFunctionSniff.php b/WordPressVIPMinimum/Sniffs/Security/ProperEscapingFunctionSniff.php index f94abdf2..fe973be1 100644 --- a/WordPressVIPMinimum/Sniffs/Security/ProperEscapingFunctionSniff.php +++ b/WordPressVIPMinimum/Sniffs/Security/ProperEscapingFunctionSniff.php @@ -35,7 +35,7 @@ class ProperEscapingFunctionSniff extends Sniff { * @return array */ public function register() { - return Tokens::$functionNameTokens; + return [ T_STRING ]; } /** diff --git a/WordPressVIPMinimum/Sniffs/Security/StaticStrreplaceSniff.php b/WordPressVIPMinimum/Sniffs/Security/StaticStrreplaceSniff.php index 09159a07..3d57edcc 100644 --- a/WordPressVIPMinimum/Sniffs/Security/StaticStrreplaceSniff.php +++ b/WordPressVIPMinimum/Sniffs/Security/StaticStrreplaceSniff.php @@ -24,7 +24,7 @@ class StaticStrreplaceSniff extends Sniff { * @return array */ public function register() { - return Tokens::$functionNameTokens; + return [ T_STRING ]; } /**