diff --git a/WordPress-VIP-Go/ruleset-test.inc b/WordPress-VIP-Go/ruleset-test.inc index 61e56955..a5c9f6e5 100644 --- a/WordPress-VIP-Go/ruleset-test.inc +++ b/WordPress-VIP-Go/ruleset-test.inc @@ -1,7 +1,7 @@ $loop ) { if ( flock( $fp, LOCK_EX ) ) { // Warning. diff --git a/WordPress-VIP-Go/ruleset-test.php b/WordPress-VIP-Go/ruleset-test.php index af455144..694ee5fa 100644 --- a/WordPress-VIP-Go/ruleset-test.php +++ b/WordPress-VIP-Go/ruleset-test.php @@ -118,7 +118,6 @@ 574 => 1, ], 'warnings' => [ - 4 => 1, 7 => 1, 10 => 1, 14 => 1, @@ -199,7 +198,6 @@ 322 => 1, 326 => 1, 332 => 1, - 391 => 1, 392 => 1, 394 => 1, 395 => 1, @@ -237,9 +235,6 @@ 556 => 1, ], 'messages' => [ - 4 => [ - 'File system operations only work on the `/tmp/` and `wp-content/uploads/` directories. To avoid unexpected results, please use helper functions like `get_temp_dir()` or `wp_get_upload_dir()` to get the proper directory path when using functions such as delete(). For more details, please see: https://docs.wpvip.com/technical-references/vip-go-files-system/local-file-operations/', - ], 7 => [ 'File system operations only work on the `/tmp/` and `wp-content/uploads/` directories. To avoid unexpected results, please use helper functions like `get_temp_dir()` or `wp_get_upload_dir()` to get the proper directory path when using functions such as file_put_contents(). For more details, please see: https://docs.wpvip.com/technical-references/vip-go-files-system/local-file-operations/', ], diff --git a/WordPress-VIP-Go/ruleset.xml b/WordPress-VIP-Go/ruleset.xml index dda22f86..88931954 100644 --- a/WordPress-VIP-Go/ruleset.xml +++ b/WordPress-VIP-Go/ruleset.xml @@ -7,11 +7,6 @@ - - warning - 6 - File system operations only work on the `/tmp/` and `wp-content/uploads/` directories. To avoid unexpected results, please use helper functions like `get_temp_dir()` or `wp_get_upload_dir()` to get the proper directory path when using functions such as %s(). For more details, please see: https://docs.wpvip.com/technical-references/vip-go-files-system/local-file-operations/ - warning 6 diff --git a/WordPressVIPMinimum/Sniffs/Functions/RestrictedFunctionsSniff.php b/WordPressVIPMinimum/Sniffs/Functions/RestrictedFunctionsSniff.php index 8f3bba86..026f7e0d 100644 --- a/WordPressVIPMinimum/Sniffs/Functions/RestrictedFunctionsSniff.php +++ b/WordPressVIPMinimum/Sniffs/Functions/RestrictedFunctionsSniff.php @@ -187,7 +187,6 @@ public function getGroups() { 'type' => 'error', 'message' => 'Filesystem writes are forbidden, please do not use %s().', 'functions' => [ - 'delete', 'file_put_contents', 'flock', 'fputcsv', diff --git a/WordPressVIPMinimum/Tests/Functions/RestrictedFunctionsUnitTest.inc b/WordPressVIPMinimum/Tests/Functions/RestrictedFunctionsUnitTest.inc index 3e65ae90..d6dc74ef 100644 --- a/WordPressVIPMinimum/Tests/Functions/RestrictedFunctionsUnitTest.inc +++ b/WordPressVIPMinimum/Tests/Functions/RestrictedFunctionsUnitTest.inc @@ -179,7 +179,7 @@ while ( $count > $loop ) { fclose( $fp ); // Ok. -delete(); // Error. + fputcsv(); // Error. fputs(); // Error. ftruncate(); // Error. diff --git a/WordPressVIPMinimum/Tests/Functions/RestrictedFunctionsUnitTest.php b/WordPressVIPMinimum/Tests/Functions/RestrictedFunctionsUnitTest.php index 9e399483..66479acd 100644 --- a/WordPressVIPMinimum/Tests/Functions/RestrictedFunctionsUnitTest.php +++ b/WordPressVIPMinimum/Tests/Functions/RestrictedFunctionsUnitTest.php @@ -82,7 +82,6 @@ public function getErrorList() { 174 => 1, 175 => 1, 177 => 1, - 182 => 1, 183 => 1, 184 => 1, 185 => 1, diff --git a/WordPressVIPMinimum/ruleset-test.inc b/WordPressVIPMinimum/ruleset-test.inc index 803e890f..38617dd0 100644 --- a/WordPressVIPMinimum/ruleset-test.inc +++ b/WordPressVIPMinimum/ruleset-test.inc @@ -365,7 +365,7 @@ session_status(); // Error. session_unregister(); // Error. session_unset(); // Error. session_write_close(); // Error. -delete(); // Error. + file_put_contents( $file, $text, FILE_APPEND ); // Error. while ( $count > $loop ) { if ( flock( $fp, LOCK_EX ) ) { // Error. diff --git a/WordPressVIPMinimum/ruleset-test.php b/WordPressVIPMinimum/ruleset-test.php index 19d74bf1..58e54c38 100644 --- a/WordPressVIPMinimum/ruleset-test.php +++ b/WordPressVIPMinimum/ruleset-test.php @@ -131,7 +131,6 @@ 365 => 1, 366 => 1, 367 => 1, - 368 => 1, 369 => 1, 371 => 1, 372 => 1,