Markdown: don't strip slashes in code blocks #1703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent that are in code blocks
dereksmart
added
[Type] Bug
Contributor
|
Incidentally, I'm not sure if he's back from paternity leave yet, paying attention to his /other/ baby. |
Contributor
|
I'm back today, actually! If it fixes the issue, I'm happy. Un-/re-slashing is a steady descent into insanity. 😛 |
samhotchkiss
added a commit
that referenced
this pull request
Mar 4, 2015
Markdown: don't strip slashes in code blocks
dereksmart
added a commit
that referenced
this pull request
Mar 5, 2015
Adding wp_slash caused more problems than it fixed. See #1703 for more info
Contributor
Author
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1673
Adding more strict checks whether to strip slashes when content is parsed/transform()ed for the front end, also adds slashes back for the text in the editor.
@mattwiebe might want to take a look, since this is his baby.