From d7500cad61bed15dc99bfa0601e44ca36a957791 Mon Sep 17 00:00:00 2001 From: Felix Borst Date: Fri, 29 Apr 2022 12:24:00 +0200 Subject: [PATCH 1/3] initial commit --- arm/Microsoft.Batch/batchAccounts/deploy.bicep | 1 + 1 file changed, 1 insertion(+) diff --git a/arm/Microsoft.Batch/batchAccounts/deploy.bicep b/arm/Microsoft.Batch/batchAccounts/deploy.bicep index afbe113383..5988d31c7d 100644 --- a/arm/Microsoft.Batch/batchAccounts/deploy.bicep +++ b/arm/Microsoft.Batch/batchAccounts/deploy.bicep @@ -101,6 +101,7 @@ resource batchAccount_lock 'Microsoft.Authorization/locks@2017-04-01' = if (lock scope: batchAccount } + resource batchAccount_diagnosticSettings 'Microsoft.Insights/diagnosticsettings@2021-05-01-preview' = if ((!empty(diagnosticStorageAccountId)) || (!empty(diagnosticWorkspaceId)) || (!empty(diagnosticEventHubAuthorizationRuleId)) || (!empty(diagnosticEventHubName))) { name: diagnosticSettingsName properties: { From 5f6a0fe1703e23f8cc785422151719dd0a8a0c68 Mon Sep 17 00:00:00 2001 From: Felix Borst Date: Fri, 29 Apr 2022 18:13:00 +0200 Subject: [PATCH 2/3] fixed broken link --- arm/Microsoft.Sql/managedInstances/readme.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arm/Microsoft.Sql/managedInstances/readme.md b/arm/Microsoft.Sql/managedInstances/readme.md index 1f98b8342f..65402fb4de 100644 --- a/arm/Microsoft.Sql/managedInstances/readme.md +++ b/arm/Microsoft.Sql/managedInstances/readme.md @@ -30,7 +30,7 @@ This template deploys a SQL managed instance. #### Networking -SQL Managed Instance is deployed on a virtual network to a subnet that is delagated to the SQL MI service. This network is required to satisfy the requirements explained [here](https://docs.microsoft.com/en-us/azure/sql-database/sql-database-managed-instance-connectivity-architecture#network-requirements). +SQL Managed Instance is deployed on a virtual network to a subnet that is delagated to the SQL MI service. This network is required to satisfy the requirements explained [here](https://docs.microsoft.com/en-us/azure/azure-sql/managed-instance/connectivity-architecture-overview?view=azuresql#network-requirements). SQL MI requires that the subnet have a Route Table and NSG assigned to it. The SQL MI service will automatically add Routes to the Route Table and Rules to the NSG once the SQL MI has been deployed. As a result, the parameter file for the Route Table and NSG will have to be updated afterwards with the created Routes & Rules, otherwise redeployment of the Route Table & NSG via Bicep/ARM will fail. From 847b7e1d2e79078c6ee4de9422bfdbb8845c91cf Mon Sep 17 00:00:00 2001 From: Felix Borst Date: Fri, 29 Apr 2022 18:42:51 +0200 Subject: [PATCH 3/3] removed unwanted empty line --- arm/Microsoft.Batch/batchAccounts/deploy.bicep | 1 - 1 file changed, 1 deletion(-) diff --git a/arm/Microsoft.Batch/batchAccounts/deploy.bicep b/arm/Microsoft.Batch/batchAccounts/deploy.bicep index 5988d31c7d..afbe113383 100644 --- a/arm/Microsoft.Batch/batchAccounts/deploy.bicep +++ b/arm/Microsoft.Batch/batchAccounts/deploy.bicep @@ -101,7 +101,6 @@ resource batchAccount_lock 'Microsoft.Authorization/locks@2017-04-01' = if (lock scope: batchAccount } - resource batchAccount_diagnosticSettings 'Microsoft.Insights/diagnosticsettings@2021-05-01-preview' = if ((!empty(diagnosticStorageAccountId)) || (!empty(diagnosticWorkspaceId)) || (!empty(diagnosticEventHubAuthorizationRuleId)) || (!empty(diagnosticEventHubName))) { name: diagnosticSettingsName properties: {