From fad9ab03d00be501425bb17185e5e0e171926148 Mon Sep 17 00:00:00 2001
From: MrMCake <asehr@hotmail.de>
Date: Sat, 3 Sep 2022 13:06:45 +0200
Subject: [PATCH 01/11] Updated ContainerGroups

---
 .../ms.containerinstance.containergroups.yml  |  3 +-
 .../.test/default/dependencies.bicep          | 13 ++++
 .../.test/default/deploy.test.bicep           | 62 +++++++++++++++++++
 .../containerGroups/.test/parameters.json     | 38 ------------
 .../containerGroups/readme.md                 | 16 ++---
 5 files changed, 84 insertions(+), 48 deletions(-)
 create mode 100644 modules/Microsoft.ContainerInstance/containerGroups/.test/default/dependencies.bicep
 create mode 100644 modules/Microsoft.ContainerInstance/containerGroups/.test/default/deploy.test.bicep
 delete mode 100644 modules/Microsoft.ContainerInstance/containerGroups/.test/parameters.json

diff --git a/.github/workflows/ms.containerinstance.containergroups.yml b/.github/workflows/ms.containerinstance.containergroups.yml
index 5d96b96c02..c919dc4a49 100644
--- a/.github/workflows/ms.containerinstance.containergroups.yml
+++ b/.github/workflows/ms.containerinstance.containergroups.yml
@@ -106,8 +106,7 @@ jobs:
       - name: 'Using test file [${{ matrix.moduleTestFilePaths }}]'
         uses: ./.github/actions/templates/validateModuleDeployment
         with:
-          templateFilePath: '${{ env.modulePath }}/deploy.bicep'
-          parameterFilePath: '${{ env.modulePath }}/${{ matrix.moduleTestFilePaths }}'
+          templateFilePath: '${{ env.modulePath }}/${{ matrix.moduleTestFilePaths }}'
           location: '${{ env.location }}'
           resourceGroupName: '${{ env.resourceGroupName }}'
           subscriptionId: '${{ secrets.ARM_SUBSCRIPTION_ID }}'
diff --git a/modules/Microsoft.ContainerInstance/containerGroups/.test/default/dependencies.bicep b/modules/Microsoft.ContainerInstance/containerGroups/.test/default/dependencies.bicep
new file mode 100644
index 0000000000..f7a7ab9322
--- /dev/null
+++ b/modules/Microsoft.ContainerInstance/containerGroups/.test/default/dependencies.bicep
@@ -0,0 +1,13 @@
+@description('Required. The name of the managed identity to create.')
+param managedIdentityName string
+
+@description('Optional. The location to deploy resources to.')
+param location string = resourceGroup().location
+
+resource managedIdentity 'Microsoft.ManagedIdentity/userAssignedIdentities@2018-11-30' = {
+  name: managedIdentityName
+  location: location
+}
+
+@description('The resource ID of the created managed identity')
+output managedIdentityResourceId string = managedIdentity.id
diff --git a/modules/Microsoft.ContainerInstance/containerGroups/.test/default/deploy.test.bicep b/modules/Microsoft.ContainerInstance/containerGroups/.test/default/deploy.test.bicep
new file mode 100644
index 0000000000..f1bf18c318
--- /dev/null
+++ b/modules/Microsoft.ContainerInstance/containerGroups/.test/default/deploy.test.bicep
@@ -0,0 +1,62 @@
+targetScope = 'subscription'
+
+// ========== //
+// Parameters //
+// ========== //
+@description('Optional. The name of the resource group to deploy for a testing purposes')
+@maxLength(90)
+param resourceGroupName string = 'ms.containerinstance.containergroups-${serviceShort}-rg'
+
+@description('Optional. The location to deploy resources to')
+param location string = deployment().location
+
+@description('Optional. A short identifier for the kind of deployment .Should be kept short to not run into resource-name length-constraints')
+param serviceShort string = 'cicgdef'
+
+// =========== //
+// Deployments //
+// =========== //
+
+// General resources
+// =================
+resource resourceGroup 'Microsoft.Resources/resourceGroups@2021-04-01' = {
+  name: resourceGroupName
+  location: location
+}
+
+module resourceGroupResources 'dependencies.bicep' = {
+  scope: resourceGroup
+  name: '${uniqueString(deployment().name, location)}-paramNested'
+  params: {
+    managedIdentityName: 'dep-<<namePrefix>>-msi-${serviceShort}'
+  }
+}
+
+// ============== //
+// Test Execution //
+// ============== //
+
+module testDeployment '../../deploy.bicep' = {
+  scope: resourceGroup
+  name: '${uniqueString(deployment().name)}-test-${serviceShort}'
+  params: {
+    name: '<<namePrefix>>${serviceShort}001'
+    containername: '<<namePrefix>>-az-aci-x-001'
+    image: 'mcr.microsoft.com/azuredocs/aci-helloworld'
+    lock: 'CanNotDelete'
+    ports: [
+      {
+        port: '80'
+        protocol: 'Tcp'
+      }
+      {
+        port: '443'
+        protocol: 'Tcp'
+      }
+    ]
+    systemAssignedIdentity: true
+    userAssignedIdentities: {
+      '${resourceGroupResources.outputs.managedIdentityResourceId}': {}
+    }
+  }
+}
diff --git a/modules/Microsoft.ContainerInstance/containerGroups/.test/parameters.json b/modules/Microsoft.ContainerInstance/containerGroups/.test/parameters.json
deleted file mode 100644
index cdbb1078cd..0000000000
--- a/modules/Microsoft.ContainerInstance/containerGroups/.test/parameters.json
+++ /dev/null
@@ -1,38 +0,0 @@
-{
-    "$schema": "https://schema.management.azure.com/schemas/2019-04-01/deploymentParameters.json#",
-    "contentVersion": "1.0.0.0",
-    "parameters": {
-        "name": {
-            "value": "<<namePrefix>>-az-acg-x-001"
-        },
-        "lock": {
-            "value": "CanNotDelete"
-        },
-        "containerName": {
-            "value": "<<namePrefix>>-az-aci-x-001"
-        },
-        "image": {
-            "value": "mcr.microsoft.com/azuredocs/aci-helloworld"
-        },
-        "ports": {
-            "value": [
-                {
-                    "protocol": "Tcp",
-                    "port": "80"
-                },
-                {
-                    "protocol": "Tcp",
-                    "port": "443"
-                }
-            ]
-        },
-        "systemAssignedIdentity": {
-            "value": true
-        },
-        "userAssignedIdentities": {
-            "value": {
-                "/subscriptions/<<subscriptionId>>/resourcegroups/validation-rg/providers/Microsoft.ManagedIdentity/userAssignedIdentities/adp-<<namePrefix>>-az-msi-x-001": {}
-            }
-        }
-    }
-}
diff --git a/modules/Microsoft.ContainerInstance/containerGroups/readme.md b/modules/Microsoft.ContainerInstance/containerGroups/readme.md
index 3059fba8ea..6931570fa3 100644
--- a/modules/Microsoft.ContainerInstance/containerGroups/readme.md
+++ b/modules/Microsoft.ContainerInstance/containerGroups/readme.md
@@ -179,7 +179,7 @@ The following module usage examples are retrieved from the content of the files
    >**Note**: The name of each example is based on the name of the file from which it is taken.
    >**Note**: Each example lists all the required parameters first, followed by the rest - each in alphabetical order.
 
-<h3>Example 1: Parameters</h3>
+<h3>Example 1: Default</h3>
 
 <details>
 
@@ -187,12 +187,12 @@ The following module usage examples are retrieved from the content of the files
 
 ```bicep
 module containerGroups './Microsoft.ContainerInstance/containerGroups/deploy.bicep' = {
-  name: '${uniqueString(deployment().name)}-ContainerGroups'
+  name: '${uniqueString(deployment().name)}-test-cicgdef'
   params: {
     // Required parameters
-    containerName: '<<namePrefix>>-az-aci-x-001'
+    containername: '<<namePrefix>>-az-aci-x-001'
     image: 'mcr.microsoft.com/azuredocs/aci-helloworld'
-    name: '<<namePrefix>>-az-acg-x-001'
+    name: '<<namePrefix>>cicgdef001'
     // Non-required parameters
     lock: 'CanNotDelete'
     ports: [
@@ -207,7 +207,7 @@ module containerGroups './Microsoft.ContainerInstance/containerGroups/deploy.bic
     ]
     systemAssignedIdentity: true
     userAssignedIdentities: {
-      '/subscriptions/<<subscriptionId>>/resourcegroups/validation-rg/providers/Microsoft.ManagedIdentity/userAssignedIdentities/adp-<<namePrefix>>-az-msi-x-001': {}
+      '<managedIdentityResourceId>': {}
     }
   }
 }
@@ -226,14 +226,14 @@ module containerGroups './Microsoft.ContainerInstance/containerGroups/deploy.bic
   "contentVersion": "1.0.0.0",
   "parameters": {
     // Required parameters
-    "containerName": {
+    "containername": {
       "value": "<<namePrefix>>-az-aci-x-001"
     },
     "image": {
       "value": "mcr.microsoft.com/azuredocs/aci-helloworld"
     },
     "name": {
-      "value": "<<namePrefix>>-az-acg-x-001"
+      "value": "<<namePrefix>>cicgdef001"
     },
     // Non-required parameters
     "lock": {
@@ -256,7 +256,7 @@ module containerGroups './Microsoft.ContainerInstance/containerGroups/deploy.bic
     },
     "userAssignedIdentities": {
       "value": {
-        "/subscriptions/<<subscriptionId>>/resourcegroups/validation-rg/providers/Microsoft.ManagedIdentity/userAssignedIdentities/adp-<<namePrefix>>-az-msi-x-001": {}
+        "<managedIdentityResourceId>": {}
       }
     }
   }

From f22824064857bb80da9728eb78e702845e347efd Mon Sep 17 00:00:00 2001
From: MrMCake <asehr@hotmail.de>
Date: Thu, 8 Sep 2022 19:20:58 +0200
Subject: [PATCH 02/11] Updated folder default to common.

---
 .../.test/{default => common}/dependencies.bicep                | 0
 .../containerGroups/.test/{default => common}/deploy.test.bicep | 0
 modules/Microsoft.ContainerInstance/containerGroups/readme.md   | 2 +-
 3 files changed, 1 insertion(+), 1 deletion(-)
 rename modules/Microsoft.ContainerInstance/containerGroups/.test/{default => common}/dependencies.bicep (100%)
 rename modules/Microsoft.ContainerInstance/containerGroups/.test/{default => common}/deploy.test.bicep (100%)

diff --git a/modules/Microsoft.ContainerInstance/containerGroups/.test/default/dependencies.bicep b/modules/Microsoft.ContainerInstance/containerGroups/.test/common/dependencies.bicep
similarity index 100%
rename from modules/Microsoft.ContainerInstance/containerGroups/.test/default/dependencies.bicep
rename to modules/Microsoft.ContainerInstance/containerGroups/.test/common/dependencies.bicep
diff --git a/modules/Microsoft.ContainerInstance/containerGroups/.test/default/deploy.test.bicep b/modules/Microsoft.ContainerInstance/containerGroups/.test/common/deploy.test.bicep
similarity index 100%
rename from modules/Microsoft.ContainerInstance/containerGroups/.test/default/deploy.test.bicep
rename to modules/Microsoft.ContainerInstance/containerGroups/.test/common/deploy.test.bicep
diff --git a/modules/Microsoft.ContainerInstance/containerGroups/readme.md b/modules/Microsoft.ContainerInstance/containerGroups/readme.md
index 6931570fa3..0b851bd286 100644
--- a/modules/Microsoft.ContainerInstance/containerGroups/readme.md
+++ b/modules/Microsoft.ContainerInstance/containerGroups/readme.md
@@ -179,7 +179,7 @@ The following module usage examples are retrieved from the content of the files
    >**Note**: The name of each example is based on the name of the file from which it is taken.
    >**Note**: Each example lists all the required parameters first, followed by the rest - each in alphabetical order.
 
-<h3>Example 1: Default</h3>
+<h3>Example 1: Common</h3>
 
 <details>
 

From 3fb7c5ec982246b5dbb438c8b8c8d17141aec783 Mon Sep 17 00:00:00 2001
From: MrMCake <asehr@hotmail.de>
Date: Fri, 9 Sep 2022 12:52:49 +0200
Subject: [PATCH 03/11] Update to latest

---
 .../containerGroups/.test/common/deploy.test.bicep            | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/modules/Microsoft.ContainerInstance/containerGroups/.test/common/deploy.test.bicep b/modules/Microsoft.ContainerInstance/containerGroups/.test/common/deploy.test.bicep
index f1bf18c318..82fb4f01f7 100644
--- a/modules/Microsoft.ContainerInstance/containerGroups/.test/common/deploy.test.bicep
+++ b/modules/Microsoft.ContainerInstance/containerGroups/.test/common/deploy.test.bicep
@@ -10,8 +10,8 @@ param resourceGroupName string = 'ms.containerinstance.containergroups-${service
 @description('Optional. The location to deploy resources to')
 param location string = deployment().location
 
-@description('Optional. A short identifier for the kind of deployment .Should be kept short to not run into resource-name length-constraints')
-param serviceShort string = 'cicgdef'
+@description('Optional. A short identifier for the kind of deployment. Should be kept short to not run into resource-name length-constraints')
+param serviceShort string = 'cicgcom'
 
 // =========== //
 // Deployments //

From a78fadaab7535b0474444219eddb8e2d649ba8c0 Mon Sep 17 00:00:00 2001
From: MrMCake <asehr@hotmail.de>
Date: Fri, 9 Sep 2022 13:06:07 +0200
Subject: [PATCH 04/11] Update to latest

---
 .../containerGroups/.test/common/deploy.test.bicep          | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/modules/Microsoft.ContainerInstance/containerGroups/.test/common/deploy.test.bicep b/modules/Microsoft.ContainerInstance/containerGroups/.test/common/deploy.test.bicep
index 82fb4f01f7..0933fb09f9 100644
--- a/modules/Microsoft.ContainerInstance/containerGroups/.test/common/deploy.test.bicep
+++ b/modules/Microsoft.ContainerInstance/containerGroups/.test/common/deploy.test.bicep
@@ -3,14 +3,14 @@ targetScope = 'subscription'
 // ========== //
 // Parameters //
 // ========== //
-@description('Optional. The name of the resource group to deploy for a testing purposes')
+@description('Optional. The name of the resource group to deploy for a testing purposes.')
 @maxLength(90)
 param resourceGroupName string = 'ms.containerinstance.containergroups-${serviceShort}-rg'
 
-@description('Optional. The location to deploy resources to')
+@description('Optional. The location to deploy resources to.')
 param location string = deployment().location
 
-@description('Optional. A short identifier for the kind of deployment. Should be kept short to not run into resource-name length-constraints')
+@description('Optional. A short identifier for the kind of deployment. Should be kept short to not run into resource-name length-constraints.')
 param serviceShort string = 'cicgcom'
 
 // =========== //

From 70d0827701238088e8b1be4f8d1c700eee8a110d Mon Sep 17 00:00:00 2001
From: MrMCake <asehr@hotmail.de>
Date: Fri, 9 Sep 2022 14:18:47 +0200
Subject: [PATCH 05/11] Update to latest

---
 .../Microsoft.ContainerInstance/containerGroups/readme.md   | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/modules/Microsoft.ContainerInstance/containerGroups/readme.md b/modules/Microsoft.ContainerInstance/containerGroups/readme.md
index f5ea904caa..4835dc77f7 100644
--- a/modules/Microsoft.ContainerInstance/containerGroups/readme.md
+++ b/modules/Microsoft.ContainerInstance/containerGroups/readme.md
@@ -188,12 +188,12 @@ The following module usage examples are retrieved from the content of the files
 
 ```bicep
 module containerGroups './Microsoft.ContainerInstance/containerGroups/deploy.bicep' = {
-  name: '${uniqueString(deployment().name)}-test-cicgdef'
+  name: '${uniqueString(deployment().name)}-test-cicgcom'
   params: {
     // Required parameters
     containername: '<<namePrefix>>-az-aci-x-001'
     image: 'mcr.microsoft.com/azuredocs/aci-helloworld'
-    name: '<<namePrefix>>cicgdef001'
+    name: '<<namePrefix>>cicgcom001'
     // Non-required parameters
     lock: 'CanNotDelete'
     ports: [
@@ -234,7 +234,7 @@ module containerGroups './Microsoft.ContainerInstance/containerGroups/deploy.bic
       "value": "mcr.microsoft.com/azuredocs/aci-helloworld"
     },
     "name": {
-      "value": "<<namePrefix>>cicgdef001"
+      "value": "<<namePrefix>>cicgcom001"
     },
     // Non-required parameters
     "lock": {

From 7800c0ff15748141d29b8f53d78eaf8e3c6fb34e Mon Sep 17 00:00:00 2001
From: Alexander Sehr <ASehr@hotmail.de>
Date: Mon, 19 Sep 2022 08:20:18 +0200
Subject: [PATCH 06/11] Update
 modules/Microsoft.ContainerInstance/containerGroups/.test/common/deploy.test.bicep

---
 .../containerGroups/.test/common/deploy.test.bicep              | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/modules/Microsoft.ContainerInstance/containerGroups/.test/common/deploy.test.bicep b/modules/Microsoft.ContainerInstance/containerGroups/.test/common/deploy.test.bicep
index 0933fb09f9..b23a90c9e0 100644
--- a/modules/Microsoft.ContainerInstance/containerGroups/.test/common/deploy.test.bicep
+++ b/modules/Microsoft.ContainerInstance/containerGroups/.test/common/deploy.test.bicep
@@ -3,7 +3,7 @@ targetScope = 'subscription'
 // ========== //
 // Parameters //
 // ========== //
-@description('Optional. The name of the resource group to deploy for a testing purposes.')
+@description('Optional. The name of the resource group to deploy for testing purposes.')
 @maxLength(90)
 param resourceGroupName string = 'ms.containerinstance.containergroups-${serviceShort}-rg'
 

From 20605e011609f8fc1de5876948189af8ed896f29 Mon Sep 17 00:00:00 2001
From: MrMCake <asehr@hotmail.de>
Date: Wed, 5 Oct 2022 21:57:19 +0200
Subject: [PATCH 07/11] Update to latest

---
 .../containerGroups/.test/common/dependencies.bicep             | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/modules/Microsoft.ContainerInstance/containerGroups/.test/common/dependencies.bicep b/modules/Microsoft.ContainerInstance/containerGroups/.test/common/dependencies.bicep
index f7a7ab9322..66dc10c2f2 100644
--- a/modules/Microsoft.ContainerInstance/containerGroups/.test/common/dependencies.bicep
+++ b/modules/Microsoft.ContainerInstance/containerGroups/.test/common/dependencies.bicep
@@ -9,5 +9,5 @@ resource managedIdentity 'Microsoft.ManagedIdentity/userAssignedIdentities@2018-
   location: location
 }
 
-@description('The resource ID of the created managed identity')
+@description('The resource ID of the created managed identity.')
 output managedIdentityResourceId string = managedIdentity.id

From acdcbd95acbdf9edc9a1c287cd8ff82f4d07f723 Mon Sep 17 00:00:00 2001
From: MrMCake <asehr@hotmail.de>
Date: Thu, 6 Oct 2022 22:05:09 +0200
Subject: [PATCH 08/11] Resolved conflicts

---
 .../.test/min/deploy.test.bicep               | 12 +++++++++
 .../containerGroups/readme.md                 | 26 +++++++++++++++++++
 2 files changed, 38 insertions(+)

diff --git a/modules/Microsoft.ContainerInstance/containerGroups/.test/min/deploy.test.bicep b/modules/Microsoft.ContainerInstance/containerGroups/.test/min/deploy.test.bicep
index b48c4b9d97..c14b4b46b1 100644
--- a/modules/Microsoft.ContainerInstance/containerGroups/.test/min/deploy.test.bicep
+++ b/modules/Microsoft.ContainerInstance/containerGroups/.test/min/deploy.test.bicep
@@ -39,6 +39,12 @@ module testDeployment '../../deploy.bicep' = {
         name: '<<namePrefix>>-az-aci-x-001'
         properties: {
           image: 'mcr.microsoft.com/azuredocs/aci-helloworld'
+          ports: [
+            {
+              port: '443'
+              protocol: 'Tcp'
+            }
+          ]
           resources: {
             requests: {
               cpu: 2
@@ -48,5 +54,11 @@ module testDeployment '../../deploy.bicep' = {
         }
       }
     ]
+    ipAddressPorts: [
+      {
+        protocol: 'Tcp'
+        port: 443
+      }
+    ]
   }
 }
diff --git a/modules/Microsoft.ContainerInstance/containerGroups/readme.md b/modules/Microsoft.ContainerInstance/containerGroups/readme.md
index c4cc9ece99..b2e7c597d2 100644
--- a/modules/Microsoft.ContainerInstance/containerGroups/readme.md
+++ b/modules/Microsoft.ContainerInstance/containerGroups/readme.md
@@ -345,6 +345,12 @@ module containerGroups './Microsoft.ContainerInstance/containerGroups/deploy.bic
         name: '<<namePrefix>>-az-aci-x-001'
         properties: {
           image: 'mcr.microsoft.com/azuredocs/aci-helloworld'
+          ports: [
+            {
+              port: '443'
+              protocol: 'Tcp'
+            }
+          ]
           resources: {
             requests: {
               cpu: 2
@@ -356,6 +362,12 @@ module containerGroups './Microsoft.ContainerInstance/containerGroups/deploy.bic
     ]
     name: '<<namePrefix>>cicgmin001'
     // Non-required parameters
+    ipAddressPorts: [
+      {
+        port: 443
+        protocol: 'Tcp'
+      }
+    ]
     lock: 'CanNotDelete'
   }
 }
@@ -380,6 +392,12 @@ module containerGroups './Microsoft.ContainerInstance/containerGroups/deploy.bic
           "name": "<<namePrefix>>-az-aci-x-001",
           "properties": {
             "image": "mcr.microsoft.com/azuredocs/aci-helloworld",
+            "ports": [
+              {
+                "port": "443",
+                "protocol": "Tcp"
+              }
+            ],
             "resources": {
               "requests": {
                 "cpu": 2,
@@ -394,6 +412,14 @@ module containerGroups './Microsoft.ContainerInstance/containerGroups/deploy.bic
       "value": "<<namePrefix>>cicgmin001"
     },
     // Non-required parameters
+    "ipAddressPorts": {
+      "value": [
+        {
+          "port": 443,
+          "protocol": "Tcp"
+        }
+      ]
+    },
     "lock": {
       "value": "CanNotDelete"
     }

From 0cd0ca98ccac7df80b60f23a75b5f5bfda481d7d Mon Sep 17 00:00:00 2001
From: MrMCake <asehr@hotmail.de>
Date: Thu, 6 Oct 2022 22:17:44 +0200
Subject: [PATCH 09/11] Update to latest

---
 .../.test/common/deploy.test.bicep            | 10 +++++++++
 .../containerGroups/readme.md                 | 22 +++++++++++++++++++
 2 files changed, 32 insertions(+)

diff --git a/modules/Microsoft.ContainerInstance/containerGroups/.test/common/deploy.test.bicep b/modules/Microsoft.ContainerInstance/containerGroups/.test/common/deploy.test.bicep
index 642b0f746e..98a017e298 100644
--- a/modules/Microsoft.ContainerInstance/containerGroups/.test/common/deploy.test.bicep
+++ b/modules/Microsoft.ContainerInstance/containerGroups/.test/common/deploy.test.bicep
@@ -88,6 +88,16 @@ module testDeployment '../../deploy.bicep' = {
         }
       }
     ]
+    ipAddressPorts: [
+      {
+        protocol: 'Tcp'
+        port: 80
+      }
+      {
+        protocol: 'Tcp'
+        port: 443
+      }
+    ]
     systemAssignedIdentity: true
     userAssignedIdentities: {
       '${resourceGroupResources.outputs.managedIdentityResourceId}': {}
diff --git a/modules/Microsoft.ContainerInstance/containerGroups/readme.md b/modules/Microsoft.ContainerInstance/containerGroups/readme.md
index b2e7c597d2..a66b92c86d 100644
--- a/modules/Microsoft.ContainerInstance/containerGroups/readme.md
+++ b/modules/Microsoft.ContainerInstance/containerGroups/readme.md
@@ -237,6 +237,16 @@ module containerGroups './Microsoft.ContainerInstance/containerGroups/deploy.bic
     ]
     name: '<<namePrefix>>cicgcom001'
     // Non-required parameters
+    ipAddressPorts: [
+      {
+        port: 80
+        protocol: 'Tcp'
+      }
+      {
+        port: 443
+        protocol: 'Tcp'
+      }
+    ]
     lock: 'CanNotDelete'
     systemAssignedIdentity: true
     userAssignedIdentities: {
@@ -311,6 +321,18 @@ module containerGroups './Microsoft.ContainerInstance/containerGroups/deploy.bic
       "value": "<<namePrefix>>cicgcom001"
     },
     // Non-required parameters
+    "ipAddressPorts": {
+      "value": [
+        {
+          "port": 80,
+          "protocol": "Tcp"
+        },
+        {
+          "port": 443,
+          "protocol": "Tcp"
+        }
+      ]
+    },
     "lock": {
       "value": "CanNotDelete"
     },

From 9076ffcc0b2f41c185de26f798b423bc2379ec55 Mon Sep 17 00:00:00 2001
From: MrMCake <asehr@hotmail.de>
Date: Tue, 11 Oct 2022 13:00:13 +0200
Subject: [PATCH 10/11] Update to latest

---
 .../containerGroups/.test/min/deploy.test.bicep                  | 1 -
 1 file changed, 1 deletion(-)

diff --git a/modules/Microsoft.ContainerInstance/containerGroups/.test/min/deploy.test.bicep b/modules/Microsoft.ContainerInstance/containerGroups/.test/min/deploy.test.bicep
index c14b4b46b1..8b69864c1c 100644
--- a/modules/Microsoft.ContainerInstance/containerGroups/.test/min/deploy.test.bicep
+++ b/modules/Microsoft.ContainerInstance/containerGroups/.test/min/deploy.test.bicep
@@ -33,7 +33,6 @@ module testDeployment '../../deploy.bicep' = {
   name: '${uniqueString(deployment().name)}-test-${serviceShort}'
   params: {
     name: '<<namePrefix>>${serviceShort}001'
-    lock: 'CanNotDelete'
     containers: [
       {
         name: '<<namePrefix>>-az-aci-x-001'

From 412152c576d8fb3c92c255250a1181f036719276 Mon Sep 17 00:00:00 2001
From: MrMCake <asehr@hotmail.de>
Date: Tue, 11 Oct 2022 13:01:55 +0200
Subject: [PATCH 11/11] Update to latest

---
 modules/Microsoft.ContainerInstance/containerGroups/readme.md | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/modules/Microsoft.ContainerInstance/containerGroups/readme.md b/modules/Microsoft.ContainerInstance/containerGroups/readme.md
index a66b92c86d..2250848253 100644
--- a/modules/Microsoft.ContainerInstance/containerGroups/readme.md
+++ b/modules/Microsoft.ContainerInstance/containerGroups/readme.md
@@ -390,7 +390,6 @@ module containerGroups './Microsoft.ContainerInstance/containerGroups/deploy.bic
         protocol: 'Tcp'
       }
     ]
-    lock: 'CanNotDelete'
   }
 }
 ```
@@ -441,9 +440,6 @@ module containerGroups './Microsoft.ContainerInstance/containerGroups/deploy.bic
           "protocol": "Tcp"
         }
       ]
-    },
-    "lock": {
-      "value": "CanNotDelete"
     }
   }
 }