From bbbde24b0cb923d0c25cd2bc946fa636a6f90a98 Mon Sep 17 00:00:00 2001 From: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com> Date: Mon, 6 Dec 2021 09:18:57 +1100 Subject: [PATCH 1/3] updated linter (#6) --- .github/workflows/linter.yml | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/.github/workflows/linter.yml b/.github/workflows/linter.yml index 1284dbd68c..05e966a2ae 100644 --- a/.github/workflows/linter.yml +++ b/.github/workflows/linter.yml @@ -1,6 +1,6 @@ name: '.Platform: Linter' -on: [pull_request] +on: workflow_dispatch jobs: build: @@ -27,3 +27,10 @@ jobs: DEFAULT_BRANCH: ${{ github.base_ref }} GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} FILTER_REGEX_EXCLUDE: '[global.module.tests.ps1|Get\-ModulesAsMarkdownTable.ps1]' + + - name: Link Checker + uses: lycheeverse/lychee-action@v1.1.1 + with: + args: --verbose --no-progress **/*.md **/*.html + env: + GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}} From 3fd7486a44caee81672c2ec72c1101733bc212bf Mon Sep 17 00:00:00 2001 From: Ahmad Abdalla <28486158+ahmadabdalla@users.noreply.github.com> Date: Mon, 6 Dec 2021 14:30:28 +1100 Subject: [PATCH 2/3] Users/ahmad/links (#7) --- .github/workflows/linter.yml | 8 ++++- .lycheeignore | 8 +++++ .../virtualMachineScaleSets/readme.md | 29 +++++++------------ .../virtualMachines/readme.md | 8 ++--- .../managedClusters/agentPools/readme.md | 2 +- .../managedClusters/readme.md | 4 +-- .../securityAlertPolicies/deploy.bicep | 2 +- .../servers/securityAlertPolicies/readme.md | 2 +- docs/wiki/ModulesUsage.md | 4 +-- docs/wiki/TestingDesign.md | 2 +- 10 files changed, 37 insertions(+), 32 deletions(-) create mode 100644 .lycheeignore diff --git a/.github/workflows/linter.yml b/.github/workflows/linter.yml index 05e966a2ae..218edc12c7 100644 --- a/.github/workflows/linter.yml +++ b/.github/workflows/linter.yml @@ -29,8 +29,14 @@ jobs: FILTER_REGEX_EXCLUDE: '[global.module.tests.ps1|Get\-ModulesAsMarkdownTable.ps1]' - name: Link Checker + if: always() + id: checker uses: lycheeverse/lychee-action@v1.1.1 with: - args: --verbose --no-progress **/*.md **/*.html + args: --verbose --no-progress **/*.md --exclude-file .lycheeignore --accept 200,201,403,429 env: GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}} + + - name: Link Checker Results + if: always() + run: exit ${{ steps.checker.outputs.exit_code }} diff --git a/.lycheeignore b/.lycheeignore new file mode 100644 index 0000000000..62214a16db --- /dev/null +++ b/.lycheeignore @@ -0,0 +1,8 @@ +https://foo.psd1/ +file:///github +https://mystorageaccount.blob.core.windows.net +https://mykeyvault.vault.azure.net +https://www.powershellgallery.com +https://github.com/myProject +http://validURLToConfigLocation/ +https://myCustomDependencyLocation/ diff --git a/arm/Microsoft.Compute/virtualMachineScaleSets/readme.md b/arm/Microsoft.Compute/virtualMachineScaleSets/readme.md index 4f1e419349..691dc568e6 100644 --- a/arm/Microsoft.Compute/virtualMachineScaleSets/readme.md +++ b/arm/Microsoft.Compute/virtualMachineScaleSets/readme.md @@ -197,25 +197,16 @@ The following resources are required to be able to deploy this resource. ```json -"extensionDomainJoinConfig": { - "value": { - "settings": { - "Name": ".onmicrosoft.com", - "User": "domainJoinUser02@.onmicrosoft.com", - "OUPath": "OU=Template-Test; DC=; DC=onmicrosoft; DC=com", - "Restart": true, - "Options": "" - } - } -} -``` - -Should be configured alongside: -```json -"extensionDomainJoinPassword": { - "reference": { - "keyVault": { - "id": "/subscriptions/<>/resourceGroups/validation-rg/providers/Microsoft.KeyVault/vaults/" +"windowsScriptExtensionFileData": { + "value": [ + //storage accounts with SAS token requirement + { + "uri": "https://mystorageAccount.blob.core.windows.net/avdscripts/File1.ps1", + "storageAccountId": "/subscriptions/12345678-1234-1234-1234-123456789012/resourceGroups/rgName/providers/Microsoft.Storage/storageAccounts/storageAccountName" + }, + { + "uri": "https://mystorageAccount.blob.core.windows.net/avdscripts/File2.ps1", + "storageAccountId": "/subscriptions/12345678-1234-1234-1234-123456789012/resourceGroups/rgName/providers/Microsoft.Storage/storageAccounts/storageAccountName" }, "secretName": "domainJoinUser-Password" } diff --git a/arm/Microsoft.Compute/virtualMachines/readme.md b/arm/Microsoft.Compute/virtualMachines/readme.md index 125f6fd3dd..5b2abb2edf 100644 --- a/arm/Microsoft.Compute/virtualMachines/readme.md +++ b/arm/Microsoft.Compute/virtualMachines/readme.md @@ -343,9 +343,9 @@ Only for OSType Windows "diskEncryptionSettings": { "value": { "EncryptionOperation": "EnableEncryption", - "KeyVaultURL": "https://adp-sxx-az-kv-x-001.vault.azure.net/", + "KeyVaultURL": "https://mykeyvault.vault.azure.net/", "KeyVaultResourceId": "/subscriptions/<>/resourceGroups/validation-rg/providers/Microsoft.KeyVault/vaults/adp-sxx-az-kv-x-001", - "KeyEncryptionKeyURL": "https://adp-sxx-az-kv-x-001.vault.azure.net/keys/keyEncryptionKey/685153483a1140e3856f004a753e1ab4", + "KeyEncryptionKeyURL": "https://mykeyvault.vault.azure.net/keys/keyEncryptionKey/685153483a1140e3856f004a753e1ab4", "KekVaultResourceId": "/subscriptions/<>/resourceGroups/validation-rg/providers/Microsoft.KeyVault/vaults/adp-sxx-az-kv-x-001", "KeyEncryptionAlgorithm": "RSA-OAEP", //'RSA-OAEP'/'RSA-OAEP-256'/'RSA1_5' "VolumeType": "All", //'OS'/'Data'/'All' @@ -409,11 +409,11 @@ Only for OSType Windows "value": [ //storage accounts with SAS token requirement { - "uri": "https://storageAccount.blob.core.windows.net/avdscripts/File1.ps1", + "uri": "https://mystorageaccount.blob.core.windows.net/avdscripts/File1.ps1", "storageAccountId": "/subscriptions/12345678-1234-1234-1234-123456789012/resourceGroups/rgName/providers/Microsoft.Storage/storageAccounts/storageAccountName" }, { - "uri": "https://storageAccount.blob.core.windows.net/avdscripts/File2.ps1", + "uri": "https://mystorageaccount.blob.core.windows.net/avdscripts/File2.ps1", "storageAccountId": "/subscriptions/12345678-1234-1234-1234-123456789012/resourceGroups/rgName/providers/Microsoft.Storage/storageAccounts/storageAccountName" }, //storage account with public container (no SAS token is required) OR other public URL (not a storage account) diff --git a/arm/Microsoft.ContainerService/managedClusters/agentPools/readme.md b/arm/Microsoft.ContainerService/managedClusters/agentPools/readme.md index 929311fc88..fa853264e1 100644 --- a/arm/Microsoft.ContainerService/managedClusters/agentPools/readme.md +++ b/arm/Microsoft.ContainerService/managedClusters/agentPools/readme.md @@ -48,7 +48,7 @@ For available properties check Date: Mon, 6 Dec 2021 14:40:48 +1100 Subject: [PATCH 3/3] Users/ahmad/links (#8) --- .github/workflows/linter.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/linter.yml b/.github/workflows/linter.yml index 218edc12c7..75ec6283bd 100644 --- a/.github/workflows/linter.yml +++ b/.github/workflows/linter.yml @@ -1,6 +1,6 @@ name: '.Platform: Linter' -on: workflow_dispatch +on: [pull_request] jobs: build: