From 0cd013768bd4b512880a7174afebd054aa68b8b5 Mon Sep 17 00:00:00 2001 From: Simone Bertaccini Date: Tue, 1 Feb 2022 12:57:51 +0100 Subject: [PATCH 1/4] Fix proximityPlacementGroup bug --- arm/Microsoft.Compute/availabilitySets/deploy.bicep | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/arm/Microsoft.Compute/availabilitySets/deploy.bicep b/arm/Microsoft.Compute/availabilitySets/deploy.bicep index eb668cc85e..0f0e63959f 100644 --- a/arm/Microsoft.Compute/availabilitySets/deploy.bicep +++ b/arm/Microsoft.Compute/availabilitySets/deploy.bicep @@ -33,19 +33,23 @@ param tags object = {} @description('Optional. Customer Usage Attribution ID (GUID). This GUID must be previously registered') param cuaId string = '' +var proximityPlacementGroup = { + id: proximityPlacementGroupId +} + module pid_cuaId '.bicep/nested_cuaId.bicep' = if (!empty(cuaId)) { name: 'pid-${cuaId}' params: {} } -resource availabilitySet 'Microsoft.Compute/availabilitySets@2021-04-01' = { +resource availabilitySet 'Microsoft.Compute/availabilitySets@2021-07-01' = { name: name location: location tags: tags properties: { platformFaultDomainCount: availabilitySetFaultDomain platformUpdateDomainCount: availabilitySetUpdateDomain - proximityPlacementGroup: !empty(proximityPlacementGroupId) ? proximityPlacementGroupId : null + proximityPlacementGroup: !empty(proximityPlacementGroupId) ? proximityPlacementGroup : null } sku: { name: availabilitySetSku From 21ad419dc8f916684e85717693f33344f71e1628 Mon Sep 17 00:00:00 2001 From: Simone Bertaccini Date: Tue, 1 Feb 2022 13:02:10 +0100 Subject: [PATCH 2/4] API version change --- arm/Microsoft.Compute/availabilitySets/readme.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arm/Microsoft.Compute/availabilitySets/readme.md b/arm/Microsoft.Compute/availabilitySets/readme.md index 2e8b9ad15f..787fb8a394 100644 --- a/arm/Microsoft.Compute/availabilitySets/readme.md +++ b/arm/Microsoft.Compute/availabilitySets/readme.md @@ -8,7 +8,7 @@ This template deploys an availability set | :-- | :-- | | `Microsoft.Authorization/locks` | 2017-04-01 | | `Microsoft.Authorization/roleAssignments` | 2021-04-01-preview | -| `Microsoft.Compute/availabilitySets` | 2021-04-01 | +| `Microsoft.Compute/availabilitySets` | 2021-07-01 | ## Parameters From 5b91f056bccc1dfa195f742fbb5d1a915368589a Mon Sep 17 00:00:00 2001 From: Simone Bertaccini Date: Tue, 1 Feb 2022 13:09:12 +0100 Subject: [PATCH 3/4] Documentation link api chance --- arm/Microsoft.Compute/availabilitySets/readme.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arm/Microsoft.Compute/availabilitySets/readme.md b/arm/Microsoft.Compute/availabilitySets/readme.md index 787fb8a394..f45a250756 100644 --- a/arm/Microsoft.Compute/availabilitySets/readme.md +++ b/arm/Microsoft.Compute/availabilitySets/readme.md @@ -74,6 +74,6 @@ Tag names and tag values can be provided as needed. A tag can be left without a ## Template references -- [Availabilitysets](https://docs.microsoft.com/en-us/azure/templates/Microsoft.Compute/2021-04-01/availabilitySets) +- [Availabilitysets](https://docs.microsoft.com/en-us/azure/templates/Microsoft.Compute/2021-07-01/availabilitySets) - [Locks](https://docs.microsoft.com/en-us/azure/templates/Microsoft.Authorization/2017-04-01/locks) - [Roleassignments](https://docs.microsoft.com/en-us/azure/templates/Microsoft.Authorization/roleAssignments) From b6a39a248d95e2f21e53fa5633d66f5f695d5776 Mon Sep 17 00:00:00 2001 From: Simone Bertaccini Date: Tue, 1 Feb 2022 13:43:54 +0100 Subject: [PATCH 4/4] code style consistency --- arm/Microsoft.Compute/availabilitySets/deploy.bicep | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/arm/Microsoft.Compute/availabilitySets/deploy.bicep b/arm/Microsoft.Compute/availabilitySets/deploy.bicep index 0f0e63959f..086dff0903 100644 --- a/arm/Microsoft.Compute/availabilitySets/deploy.bicep +++ b/arm/Microsoft.Compute/availabilitySets/deploy.bicep @@ -33,10 +33,6 @@ param tags object = {} @description('Optional. Customer Usage Attribution ID (GUID). This GUID must be previously registered') param cuaId string = '' -var proximityPlacementGroup = { - id: proximityPlacementGroupId -} - module pid_cuaId '.bicep/nested_cuaId.bicep' = if (!empty(cuaId)) { name: 'pid-${cuaId}' params: {} @@ -49,7 +45,9 @@ resource availabilitySet 'Microsoft.Compute/availabilitySets@2021-07-01' = { properties: { platformFaultDomainCount: availabilitySetFaultDomain platformUpdateDomainCount: availabilitySetUpdateDomain - proximityPlacementGroup: !empty(proximityPlacementGroupId) ? proximityPlacementGroup : null + proximityPlacementGroup: !empty(proximityPlacementGroupId) ? { + id: proximityPlacementGroupId + } : null } sku: { name: availabilitySetSku