diff --git a/src/azure-firewall/HISTORY.rst b/src/azure-firewall/HISTORY.rst index 7e1e9d89065..1d7c71e8acd 100644 --- a/src/azure-firewall/HISTORY.rst +++ b/src/azure-firewall/HISTORY.rst @@ -2,6 +2,10 @@ Release History =============== +1.2.1 +++++++ +* Remove msrestazure dependency + 1.2.0 ++++++ * `network firewall policy rule-collection-group collection rule add/update"`: Add parameter `--http-headers-to-insert` diff --git a/src/azure-firewall/azext_firewall/_exception_handler.py b/src/azure-firewall/azext_firewall/_exception_handler.py index fcd2e326e25..d89dc9e4bc0 100644 --- a/src/azure-firewall/azext_firewall/_exception_handler.py +++ b/src/azure-firewall/azext_firewall/_exception_handler.py @@ -5,8 +5,8 @@ def exception_handler(ex): - from msrestazure.azure_exceptions import CloudError - if isinstance(ex, CloudError): + from azure.core.exceptions import HttpResponseError + if isinstance(ex, HttpResponseError): text = getattr(ex.response, 'text', '') if len(ex.args) == 1 and isinstance(ex.args[0], str): ex.args = tuple([ex.args[0] + text]) diff --git a/src/azure-firewall/azext_firewall/_validators.py b/src/azure-firewall/azext_firewall/_validators.py index da05e2035f8..494867479c6 100644 --- a/src/azure-firewall/azext_firewall/_validators.py +++ b/src/azure-firewall/azext_firewall/_validators.py @@ -22,7 +22,7 @@ def validate_application_rule_protocols(namespace): def validate_ip_groups(cmd, namespace): - from msrestazure.tools import is_valid_resource_id, resource_id + from azure.mgmt.core.tools import is_valid_resource_id, resource_id def _validate_name_or_id(ip_group, subscription): # determine if public_ip_address is name or ID @@ -46,7 +46,7 @@ def _validate_name_or_id(ip_group, subscription): def get_public_ip_validator(): """ Retrieves a validator for public IP address. Accepting all defaults will perform a check for an existing name or ID with no ARM-required -type parameter. """ - from msrestazure.tools import is_valid_resource_id, resource_id + from azure.mgmt.core.tools import is_valid_resource_id, resource_id def simple_validator(cmd, namespace): if namespace.public_ip_address: @@ -72,7 +72,7 @@ def _validate_name_or_id(public_ip): def get_subnet_validator(): - from msrestazure.tools import is_valid_resource_id, resource_id + from azure.mgmt.core.tools import is_valid_resource_id, resource_id def simple_validator(cmd, namespace): if namespace.virtual_network_name is None: @@ -96,7 +96,7 @@ def simple_validator(cmd, namespace): def get_management_subnet_validator(): - from msrestazure.tools import is_valid_resource_id, resource_id + from azure.mgmt.core.tools import is_valid_resource_id, resource_id from knack.util import CLIError def simple_validator(cmd, namespace): @@ -130,7 +130,7 @@ def simple_validator(cmd, namespace): def get_management_public_ip_validator(): """ Retrieves a validator for public IP address. Accepting all defaults will perform a check for an existing name or ID with no ARM-required -type parameter. """ - from msrestazure.tools import is_valid_resource_id, resource_id + from azure.mgmt.core.tools import is_valid_resource_id, resource_id def simple_validator(cmd, namespace): if namespace.management_public_ip_address: @@ -156,7 +156,7 @@ def _validate_name_or_id(public_ip): def validate_firewall_policy(cmd, namespace): - from msrestazure.tools import is_valid_resource_id, resource_id + from azure.mgmt.core.tools import is_valid_resource_id, resource_id if hasattr(namespace, 'base_policy') and namespace.base_policy is not None: if not is_valid_resource_id(namespace.base_policy): @@ -178,7 +178,7 @@ def validate_firewall_policy(cmd, namespace): def validate_virtual_hub(cmd, namespace): - from msrestazure.tools import is_valid_resource_id, resource_id + from azure.mgmt.core.tools import is_valid_resource_id, resource_id if hasattr(namespace, 'virtual_hub') and namespace.virtual_hub is not None: diff --git a/src/azure-firewall/azext_firewall/custom.py b/src/azure-firewall/azext_firewall/custom.py index bea8fcb87d1..e740d7baf56 100644 --- a/src/azure-firewall/azext_firewall/custom.py +++ b/src/azure-firewall/azext_firewall/custom.py @@ -13,7 +13,7 @@ from azure.cli.core.util import sdk_no_wait from azure.cli.core.azclierror import UserFault, ServiceError, ValidationError, ArgumentUsageError from azure.cli.core.commands.client_factory import get_subscription_id -from msrestazure.tools import resource_id +from azure.mgmt.core.tools import resource_id from ._client_factory import network_client_factory from .aaz.latest.network.firewall import Create as _AzureFirewallCreate, Update as _AzureFirewallUpdate, \ Show as _AzureFirewallShow