From eda1c25bbede930601b7489a969a6932e3aa478b Mon Sep 17 00:00:00 2001 From: Jianping Zeng Date: Tue, 28 Jan 2025 10:46:41 -0800 Subject: [PATCH 1/2] fix az aks nodepool upgrade cannot set node-soak-duration to 0 --- src/aks-preview/HISTORY.rst | 4 ++++ src/aks-preview/azext_aks_preview/custom.py | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/aks-preview/HISTORY.rst b/src/aks-preview/HISTORY.rst index b86f428bfed..1dcb5aa7418 100644 --- a/src/aks-preview/HISTORY.rst +++ b/src/aks-preview/HISTORY.rst @@ -9,6 +9,10 @@ If there is no rush to release a new version, please just add a description of t To release a new version, please select a new version number (usually plus 1 to last patch version, X.Y.Z -> Major.Minor.Patch, more details in `\doc `_), and then add a new section named as the new version number in this file, the content should include the new modifications and everything from the *Pending* section. Finally, update the `VERSION` variable in `setup.py` with this new version number. +13.0.0b3 ++++++++ +* Fix `az aks nodepool upgrade` command cannot set `--node-soak-duration` to 0 + 13.0.0b2 +++++++ * `az aks create/update`: Update advanced container networking service (acns) with 2024-09-02-preview API version enablement. diff --git a/src/aks-preview/azext_aks_preview/custom.py b/src/aks-preview/azext_aks_preview/custom.py index 282a541a3bd..5a3441e0846 100644 --- a/src/aks-preview/azext_aks_preview/custom.py +++ b/src/aks-preview/azext_aks_preview/custom.py @@ -1433,7 +1433,7 @@ def aks_agentpool_upgrade(cmd, instance.upgrade_settings.max_surge = max_surge if drain_timeout: instance.upgrade_settings.drain_timeout_in_minutes = drain_timeout - if node_soak_duration: + if node_soak_duration >= 0: instance.upgrade_settings.node_soak_duration_in_minutes = node_soak_duration if undrainable_node_behavior: instance.upgrade_settings.undrainable_node_behavior = undrainable_node_behavior From d0c03945d3bf5e1a391aa65023f59e1f7f84a9bd Mon Sep 17 00:00:00 2001 From: Jianping Zeng Date: Thu, 6 Feb 2025 23:35:20 -0800 Subject: [PATCH 2/2] update setup.py version --- src/aks-preview/setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/aks-preview/setup.py b/src/aks-preview/setup.py index 736c4785c8d..33da92678be 100644 --- a/src/aks-preview/setup.py +++ b/src/aks-preview/setup.py @@ -9,7 +9,7 @@ from setuptools import setup, find_packages -VERSION = "13.0.0b3" +VERSION = "13.0.0b4" CLASSIFIERS = [ "Development Status :: 4 - Beta",