From 60341b0bee0fd7234628ccab52d16e4885563e3b Mon Sep 17 00:00:00 2001 From: Travis Prescott Date: Thu, 31 May 2018 10:17:15 -0700 Subject: [PATCH] Allow one "bubble" in the perf script. --- tools/automation/verify/verify_module_load_times.py | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/tools/automation/verify/verify_module_load_times.py b/tools/automation/verify/verify_module_load_times.py index 719ee4630c1..29f53f3cba7 100644 --- a/tools/automation/verify/verify_module_load_times.py +++ b/tools/automation/verify/verify_module_load_times.py @@ -20,7 +20,6 @@ 'vm': 25, 'batch': 25, 'storage': 50, - 'servicefabric': 30, TOTAL: 300 } @@ -94,6 +93,7 @@ def run_verifications(args): failed_mods = {} mods = sorted(results.keys()) + bubble_found = False for mod in mods: val = results[mod] mean_val = mean(val) @@ -106,7 +106,13 @@ def run_verifications(args): 'values': val } if mean_val > threshold: - failed_mods[mod] = statistics + if not bubble_found and mean_val < 30: + # This temporary measure allows one floating performance + # failure up to 30 ms. See issue #6224 and #6218. + bubble_found = True + passed_mods[mod] = statistics + else: + failed_mods[mod] = statistics else: passed_mods[mod] = statistics