From f6755aa15e1e50742aae5ba1ec314307259d68fc Mon Sep 17 00:00:00 2001 From: kevinzz6 <632604666@qq.com> Date: Thu, 3 Jul 2025 13:36:01 +0800 Subject: [PATCH 1/5] fix responseContent?.ToString() throw exception ArgumentNullException --- src/Synapse/Synapse/Common/Utils.cs | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/Synapse/Synapse/Common/Utils.cs b/src/Synapse/Synapse/Common/Utils.cs index a7be80511367..8ca98dfc3ccf 100644 --- a/src/Synapse/Synapse/Common/Utils.cs +++ b/src/Synapse/Synapse/Common/Utils.cs @@ -239,10 +239,14 @@ public static Response Poll(this Operation operation) { var result = operation.WaitForCompletionResponseAsync().Result; var responseContent = result.Content; - - if (responseContent?.ToString() != "{}" && responseContent?.ToString().IsEmptyOrWhiteSpace() == false) - { + //Fix when responseContent.lenth is 0 responseContent?.ToString() will throw exception ArgumentNullException + if (result.ContentStream.Length == 0) + { + return result; + } + else if (responseContent?.ToString() != "{}" && responseContent?.ToString().IsEmptyOrWhiteSpace() == false) + { throw new Exception(responseContent?.ToString()); } return result; From 1483dcf6b59443b32433289191c78ee7a9ea5f38 Mon Sep 17 00:00:00 2001 From: kevinzz6 <632604666@qq.com> Date: Thu, 3 Jul 2025 13:41:57 +0800 Subject: [PATCH 2/5] update changelog --- src/Synapse/Synapse/ChangeLog.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/Synapse/Synapse/ChangeLog.md b/src/Synapse/Synapse/ChangeLog.md index 54061d25c45c..db5ec8551116 100644 --- a/src/Synapse/Synapse/ChangeLog.md +++ b/src/Synapse/Synapse/ChangeLog.md @@ -20,6 +20,8 @@ ## Upcoming Release +## Version 3.2.2 +* Fixed an error when remove artifact throw `ArgumentNullException` ## Version 3.2.1 * Fixed an error of not correctly setting the cmdlet context From e92fe45ae3a4b879e84ac9b350b51e3ca7016e9f Mon Sep 17 00:00:00 2001 From: Weishu Zhao <632604666@qq.com> Date: Thu, 3 Jul 2025 13:44:58 +0800 Subject: [PATCH 3/5] Update src/Synapse/Synapse/Common/Utils.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- src/Synapse/Synapse/Common/Utils.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Synapse/Synapse/Common/Utils.cs b/src/Synapse/Synapse/Common/Utils.cs index 8ca98dfc3ccf..b9b6e09bcfbc 100644 --- a/src/Synapse/Synapse/Common/Utils.cs +++ b/src/Synapse/Synapse/Common/Utils.cs @@ -240,7 +240,7 @@ public static Response Poll(this Operation operation) var result = operation.WaitForCompletionResponseAsync().Result; var responseContent = result.Content; - //Fix when responseContent.lenth is 0 responseContent?.ToString() will throw exception ArgumentNullException + //Fix when responseContent.length is 0 responseContent?.ToString() will throw exception ArgumentNullException if (result.ContentStream.Length == 0) { return result; From 47c30a303957d3e19a059e1816f4106439ebdf94 Mon Sep 17 00:00:00 2001 From: kevinzz6 <632604666@qq.com> Date: Thu, 3 Jul 2025 14:46:17 +0800 Subject: [PATCH 4/5] check result.ContentStream == null --- src/Synapse/Synapse/Common/Utils.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Synapse/Synapse/Common/Utils.cs b/src/Synapse/Synapse/Common/Utils.cs index b9b6e09bcfbc..3bf67651ccd8 100644 --- a/src/Synapse/Synapse/Common/Utils.cs +++ b/src/Synapse/Synapse/Common/Utils.cs @@ -241,7 +241,7 @@ public static Response Poll(this Operation operation) var responseContent = result.Content; //Fix when responseContent.length is 0 responseContent?.ToString() will throw exception ArgumentNullException - if (result.ContentStream.Length == 0) + if (result.ContentStream == null || result.ContentStream.Length == 0) { return result; } From 9f9428e21a5d9c2d0dbe32a69cbf329344990027 Mon Sep 17 00:00:00 2001 From: Weishu Zhao <632604666@qq.com> Date: Thu, 3 Jul 2025 15:42:36 +0800 Subject: [PATCH 5/5] Update ChangeLog.md --- src/Synapse/Synapse/ChangeLog.md | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/Synapse/Synapse/ChangeLog.md b/src/Synapse/Synapse/ChangeLog.md index db5ec8551116..2e382a2b81c7 100644 --- a/src/Synapse/Synapse/ChangeLog.md +++ b/src/Synapse/Synapse/ChangeLog.md @@ -19,8 +19,6 @@ --> ## Upcoming Release - -## Version 3.2.2 * Fixed an error when remove artifact throw `ArgumentNullException` ## Version 3.2.1 * Fixed an error of not correctly setting the cmdlet context