Skip to content

Comments

[Automation] Generate SDK based on TypeSpec 0.20.0 DEV - with stream-style fix#41617

Closed
azure-sdk wants to merge 4 commits intoAzure:mainfrom
azure-sdk:typespec-java-generation-4075462
Closed

[Automation] Generate SDK based on TypeSpec 0.20.0 DEV - with stream-style fix#41617
azure-sdk wants to merge 4 commits intoAzure:mainfrom
azure-sdk:typespec-java-generation-4075462

Conversation

@azure-sdk
Copy link
Collaborator

@azure-sdk azure-sdk commented Aug 23, 2024

[Automation] Generate SDK based on TypeSpec 0.20.0 DEV

Emitter versions is: merge main with the Alan's fix on stream-style Azure/autorest.java#2928

CI error:

  1. openai: wip on fixing the recording in test proxy.
  2. healthinsight: due to [Automation] Generate SDK based on TypeSpec 0.20.0 DEV #41600 (comment)

Diff Highlights:

  1. There is no public client method parameter order change for existing services.
  2. There is no public API change on always allowing overriding endpoint.
  3. API view diffs are caused by @override removed from getKind() , pending on Alan's fix pr

Detailed diff summary:

Diff summary Root cause Expected? Impact Example Tsp
@override removed from getKind() refactoring on stream style for hierarchical models. N All API diffs are caused by this https://github.com/Azure/azure-sdk-for-java/pull/41617/files#diff-90b30f05da823f3aaaf96caa3a6234d229c84b3e93c10224183857a36a9c3b02L63 /
Client method: javadoc change on the return type we mrege summary and description in codegen. Y https://github.com/Azure/azure-sdk-for-java/pull/41600/files#diff-22a86c1583ab90d90851139f385f25e4184e565365883b077d8fdfa47ea1e0d2R24971 /
optional body and content-type case: protocol method javadoc added header parameter table Service team explicitly specified content-type in tsp, so we will not generate content-type javadoc before, but now we remove the content type for optional body case, so the javadoc shows content-type header Y In the impl, we will add default content type here, so runtime behavior should be the same https://github.com/Azure/azure-sdk-for-java/pull/41600/files#diff-22a86c1583ab90d90851139f385f25e4184e565365883b077d8fdfa47ea1e0d2R27136 https://github.com/Azure/azure-rest-api-specs/blob/main/specification/batch/Azure.Batch/routes.tsp#L1319
https://github.com/Azure/azure-rest-api-specs/blob/main/specification/batch/Azure.Batch/common.tsp#L13
The order of setting model property changes Due to spread parameter order change Y But we group the parameters to option bag, so no impact on method signature https://github.com/Azure/azure-sdk-for-java/pull/41600/files#diff-6d9f7ebfa44d7fa7f65cb19f90df0c1ee7460ee1ae28d0d78beb000dbad5d74aR783 https://github.com/Azure/azure-rest-api-specs/blob/main/specification/ai/Face/routes.detection.tsp
https://github.com/Azure/azure-rest-api-specs/blob/main/specification/ai/Face/models.detect.tsp
accept header's application/json value is removed previously we will add response.body.contentTypes to accept header's content type value by ourselves, in this case, response error is json, so we add application/json, but now we use TCGC to get accept header's content type value. Y This will cause CI failure, and we need to update test recordings. I updated in 1a9f4a2. https://github.com/Azure/azure-sdk-for-java/pull/41600/files#diff-2b69dc7105600fc163760d8b834bf171ed6880b198d30043f65026f68b931c59L372 https://github.com/Azure/azure-rest-api-specs/blob/main/specification/communication/Communication.Messages/routes.tsp#L46

@azure-sdk azure-sdk added the DPG label Aug 23, 2024
@azure-sdk
Copy link
Collaborator Author

azure-sdk commented Aug 23, 2024

@haolingdong-msft haolingdong-msft changed the title [Automation] Generate SDK based on TypeSpec 0.20.0 DEV [Automation] Generate SDK based on TypeSpec 0.20.0 DEV - with stream-style fix Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants