Add Key Vault API versions for sovereign clouds in smoke tests#13130
Merged
chlowell merged 1 commit intoAzure:masterfrom Aug 18, 2020
Merged
Add Key Vault API versions for sovereign clouds in smoke tests#13130chlowell merged 1 commit intoAzure:masterfrom
chlowell merged 1 commit intoAzure:masterfrom
Conversation
chlowell
added
KeyVault
test-reliability
chlowell
requested review from
annatisch,
lmazuel,
rakshith91,
shurd and
southpolesteve
as code owners
chlowell
force-pushed
the
fix-key-vault-smoketest
branch
from
175e4b3 to
e9e3d3b
Compare
Member
Author
|
/check-enforcer evaluate |
Member
Author
|
/check-enforcer override |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Smoke tests are failing in sovereign clouds because those clouds don't support Key Vault clients' default API version. Lacking a clean way to discover the supported version at runtime, this PR hardcodes known good versions.
The tests will continue to fail until #13129 merges.