From aa3c9ae14bb4785fc15431b5040540f56d35c704 Mon Sep 17 00:00:00 2001 From: jerevoss Date: Thu, 24 Aug 2023 15:58:27 -0700 Subject: [PATCH 1/4] pylint on --- sdk/monitor/azure-monitor-opentelemetry/pyproject.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/monitor/azure-monitor-opentelemetry/pyproject.toml b/sdk/monitor/azure-monitor-opentelemetry/pyproject.toml index 739b3f709776..2031fbbb52b3 100644 --- a/sdk/monitor/azure-monitor-opentelemetry/pyproject.toml +++ b/sdk/monitor/azure-monitor-opentelemetry/pyproject.toml @@ -3,5 +3,5 @@ type_check_samples = false verifytypes = false pyright = false mypy = false -pylint = false +pylint = true bandit = false From 0ad8979b9a6fbfb43cb498d3aa6d974b68081e76 Mon Sep 17 00:00:00 2001 From: jerevoss Date: Thu, 24 Aug 2023 16:45:26 -0700 Subject: [PATCH 2/4] changelog --- sdk/monitor/azure-monitor-opentelemetry/CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sdk/monitor/azure-monitor-opentelemetry/CHANGELOG.md b/sdk/monitor/azure-monitor-opentelemetry/CHANGELOG.md index 2eaaeec33b77..fbd1d209d141 100644 --- a/sdk/monitor/azure-monitor-opentelemetry/CHANGELOG.md +++ b/sdk/monitor/azure-monitor-opentelemetry/CHANGELOG.md @@ -12,6 +12,8 @@ ([#31744](https://github.com/Azure/azure-sdk-for-python/pull/31740)) - Add preview warning for Autoinstrumentation entry points ([#31767](https://github.com/Azure/azure-sdk-for-python/pull/31767)) +- Add linting back into distro + ([#31796](https://github.com/Azure/azure-sdk-for-python/pull/31796)) ### Breaking Changes From 320dfc0bb6c0a0b85e3ddbe806caae25e9764d3c Mon Sep 17 00:00:00 2001 From: jerevoss Date: Fri, 25 Aug 2023 11:32:17 -0700 Subject: [PATCH 3/4] File encoding --- .../azure/monitor/opentelemetry/diagnostics/_status_logger.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sdk/monitor/azure-monitor-opentelemetry/azure/monitor/opentelemetry/diagnostics/_status_logger.py b/sdk/monitor/azure-monitor-opentelemetry/azure/monitor/opentelemetry/diagnostics/_status_logger.py index 898c96b7afab..ad91876fad12 100644 --- a/sdk/monitor/azure-monitor-opentelemetry/azure/monitor/opentelemetry/diagnostics/_status_logger.py +++ b/sdk/monitor/azure-monitor-opentelemetry/azure/monitor/opentelemetry/diagnostics/_status_logger.py @@ -54,7 +54,9 @@ def log_status(cls, agent_initialized_successfully, reason=None): # Change to be hostname and pid status_logger_file_name = _get_status_logger_file_name(pid) with open( - join(_STATUS_LOG_PATH, status_logger_file_name), "w" + join(_STATUS_LOG_PATH, status_logger_file_name), + "w", + encoding="utf8" ) as f: f.seek(0) f.write(dumps(status_json)) From 77a4d3ff3edd2347054466231d65314a22c3c8c3 Mon Sep 17 00:00:00 2001 From: jerevoss Date: Fri, 25 Aug 2023 15:29:18 -0700 Subject: [PATCH 4/4] no-name-in-module --- .../azure/monitor/opentelemetry/_configure.py | 2 +- .../azure/monitor/opentelemetry/_constants.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sdk/monitor/azure-monitor-opentelemetry/azure/monitor/opentelemetry/_configure.py b/sdk/monitor/azure-monitor-opentelemetry/azure/monitor/opentelemetry/_configure.py index e5a833e3c685..a19510872ceb 100644 --- a/sdk/monitor/azure-monitor-opentelemetry/azure/monitor/opentelemetry/_configure.py +++ b/sdk/monitor/azure-monitor-opentelemetry/azure/monitor/opentelemetry/_configure.py @@ -34,7 +34,7 @@ SAMPLING_RATIO_ARG, ) from azure.monitor.opentelemetry._types import ConfigurationValue -from azure.monitor.opentelemetry.exporter import ( # pylint: disable=import-error +from azure.monitor.opentelemetry.exporter import ( # pylint: disable=import-error,no-name-in-module ApplicationInsightsSampler, AzureMonitorLogExporter, AzureMonitorMetricExporter, diff --git a/sdk/monitor/azure-monitor-opentelemetry/azure/monitor/opentelemetry/_constants.py b/sdk/monitor/azure-monitor-opentelemetry/azure/monitor/opentelemetry/_constants.py index 079ce1f9c024..6f1011a0d409 100644 --- a/sdk/monitor/azure-monitor-opentelemetry/azure/monitor/opentelemetry/_constants.py +++ b/sdk/monitor/azure-monitor-opentelemetry/azure/monitor/opentelemetry/_constants.py @@ -10,7 +10,7 @@ from os.path import isdir from pathlib import Path -from azure.monitor.opentelemetry.exporter._connection_string_parser import ( # pylint: disable=import-error +from azure.monitor.opentelemetry.exporter._connection_string_parser import ( # pylint: disable=import-error,no-name-in-module ConnectionStringParser, )