Conversation
Contributor
|
Looks good, except shall we preserve the fallback warning at layer creation time? (I guess if the engine is specified as |
Member
Author
|
Done. I made it LOG(INFO) since it is not a crucial issue. |
Member
Author
|
@sguada Sergio if this looks good to you I'll merge and close the other PR. |
Contributor
|
@Yangqing looks good to me |
Contributor
There was a problem hiding this comment.
This does not compile for me,
This does:
CHECK_EQ(this->pad_h_, 0);
Contributor
|
Now this commit fails tests: |
longjon
added a commit
to longjon/caffe
that referenced
this pull request
Sep 30, 2014
After BVLC#1172, some cuDNN pooling layer tests were failing due to use of padding. (Before BVLC#1172, these tests were actually testing PoolingLayer instead of CuDNNPoolingLayer via the fallback.) This commit disables many tests via commenting, so that they can be easily readded when cuDNN gains pooling padding support.
mitmul
pushed a commit
to mitmul/caffe
that referenced
this pull request
Sep 30, 2014
Pooling factory
mitmul
pushed a commit
to mitmul/caffe
that referenced
this pull request
Sep 30, 2014
After BVLC#1172, some cuDNN pooling layer tests were failing due to use of padding. (Before BVLC#1172, these tests were actually testing PoolingLayer instead of CuDNNPoolingLayer via the fallback.) This commit disables many tests via commenting, so that they can be easily readded when cuDNN gains pooling padding support.
RazvanRanca
pushed a commit
to RazvanRanca/caffe
that referenced
this pull request
Nov 4, 2014
Pooling factory
RazvanRanca
pushed a commit
to RazvanRanca/caffe
that referenced
this pull request
Nov 4, 2014
After BVLC#1172, some cuDNN pooling layer tests were failing due to use of padding. (Before BVLC#1172, these tests were actually testing PoolingLayer instead of CuDNNPoolingLayer via the fallback.) This commit disables many tests via commenting, so that they can be easily readded when cuDNN gains pooling padding support.
cbfinn
pushed a commit
to cbfinn/caffe
that referenced
this pull request
Feb 26, 2015
After BVLC#1172, some cuDNN pooling layer tests were failing due to use of padding. (Before BVLC#1172, these tests were actually testing PoolingLayer instead of CuDNNPoolingLayer via the fallback.) This commit disables many tests via commenting, so that they can be easily readded when cuDNN gains pooling padding support.
slayton58
pushed a commit
to slayton58/caffe
that referenced
this pull request
Mar 4, 2015
After BVLC#1172, some cuDNN pooling layer tests were failing due to use of padding. (Before BVLC#1172, these tests were actually testing PoolingLayer instead of CuDNNPoolingLayer via the fallback.) This commit disables many tests via commenting, so that they can be easily readded when cuDNN gains pooling padding support.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR to address the comments at #1170.