Skip to content

Comments

Added first_key and last_key to dataset#1288

Merged
sguada merged 1 commit intoBVLC:devfrom
sguada:first_last
Oct 15, 2014
Merged

Added first_key and last_key to dataset#1288
sguada merged 1 commit intoBVLC:devfrom
sguada:first_last

Conversation

@sguada
Copy link
Contributor

@sguada sguada commented Oct 15, 2014

This PR depends on #1238.

Just added two more methods to dataset to be able to know which is the first_key and last_key. This would be very useful when the keys are generated sequentially.

@kmatzen Could you take a look?

@shelhamer
Copy link
Member

@sguada before follow-ups shouldn't we first merge #1238? You'll just need to rebase this once the merge commit is in.

@sguada
Copy link
Contributor Author

sguada commented Oct 15, 2014

@shelhamer agreed, I'm waiting the confirmation from @kmatzen to merge #1238

sguada added a commit that referenced this pull request Oct 15, 2014
Added first_key and last_key to dataset
@sguada sguada merged commit 1286557 into BVLC:dev Oct 15, 2014
@sguada sguada deleted the first_last branch October 15, 2014 22:54
@shelhamer
Copy link
Member

We already recognize the beginning and end records for restarting prefetching, could you explain the use case for needing the first and last key instead?

@sguada
Copy link
Contributor Author

sguada commented Oct 18, 2014

To be able to know which is the first_key and the last_key without needing
to iterate.
In cases in which the keys are generated sequentially, that's all you need
to know the ranges of the keys, and in that way you can ask for any key in
that range.

Sergio

2014-10-18 10:06 GMT-07:00 Evan Shelhamer notifications@github.com:

We already recognize the beginning and end records for restarting
prefetching, could you explain the use case for needing the first and last
key instead?


Reply to this email directly or view it on GitHub
#1288 (comment).

RazvanRanca pushed a commit to RazvanRanca/caffe that referenced this pull request Nov 4, 2014
Added first_key and last_key to dataset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants