Fix sketchy label initialization in NetTest#1661
Merged
jeffdonahue merged 1 commit intoBVLC:devfrom Dec 31, 2014
Merged
Conversation
Previously, labels were being nonsensically filled with a zero-mean Gaussian. Now they are just set to constant zero. Note that this is not necessary for TrickyNet, neither forward nor backward are ever called.
Contributor
|
Thanks for the fix @longjon. (Merging despite Travis grey X because it was due to the GPU builds timing out; the CPU builds which run the tests pass.) |
jeffdonahue
added a commit
that referenced
this pull request
Dec 31, 2014
Fix sketchy label initialization in NetTest
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NetTest'sTinyNetuses a softmax loss layer, but initializes its labels with a zero-mean Gaussian(!). This means that labels are effectively (usually) either 0 or (invalidly) -1.This PR add a
data_fillerto make the labels always zero. Note thatTrickyNetalso uses this setup, but never calls forward or backward, so this is not an issue.