Conversation
seems that NONGEN_CXX_SRCS wasn't getting populated in OSX due to some disagreement in the regex formatting in find...give up on that and use an ugly but reliable chain of -name ... -or -name ...
Member
|
Good find @sguada and thanks for the fix @jeffdonahue. |
Contributor
|
Thanks @jeffdonahue now it works in OSX but now it detects some problems in several files currently in I will not try to fix those in my PR otherwise they will get mixed |
mitmul
pushed a commit
to mitmul/caffe
that referenced
this pull request
Sep 30, 2014
Fix 'make lint' in OSX
lukeyeager
pushed a commit
to lukeyeager/caffe
that referenced
this pull request
Jun 27, 2016
Hotfix resolving meminfo divergence corner case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to @sguada for reporting in the comment thread on #132:
Seems that NONGEN_CXX_SRCS (Makefile variable intended to list all the files we want to include in lint) was empty in OSX due to some disagreement in the regex formatting of 'find'...give up on that and use an ugly but (hopefully?) reliable chain of
-name ... -or -name ...