Merged
Conversation
shelhamer
force-pushed
the
test-reshape-harder
branch
from
57cf146 to
a371378
Compare
Contributor
There was a problem hiding this comment.
Could add an ASSERT_GT for the resulting output counts. (It's not immediately clear to me which one should give the bigger result.)
Contributor
|
Thanks for the test @shelhamer; LGTM besides above nits. |
checking large then small can mask failure since the smaller shape memory will fit within the larger shape.
Check that output spatial shape varies with input shape while the output num matches the input num.
shelhamer
force-pushed
the
test-reshape-harder
branch
from
a371378 to
b8c81bd
Compare
Member
Author
|
@jeffdonahue thanks for reviewing -- updated accordingly for merge when CI passes. |
Member
Author
|
CI failed for an irrelevant timeout issue but I've checked this independently so it's merge time. |
shelhamer
added a commit
that referenced
this pull request
Sep 24, 2015
[test] Test Reshape more rigorously
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3096.
EXPECT*instead ofCHECK*to see full results.master @ 58e4ea4 fails the new test while master @ head passes.