Randomize order of test execution by make runtest#367
Merged
jeffdonahue merged 2 commits intoBVLC:devfrom Apr 26, 2014
Merged
Conversation
jeffdonahue
added a commit
that referenced
this pull request
Apr 26, 2014
Randomize order of test execution by `make runtest`
Contributor
|
Thanks Evan! I ran the shuffled tests 5-10 times and didn't find any bugs other than the dropout gradient one you fixed. |
Merged
mitmul
pushed a commit
to mitmul/caffe
that referenced
this pull request
Sep 30, 2014
Randomize order of test execution by `make runtest`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unit tests shouldn't depend on order of execution for correctness.
The gtest flag
--gtest_shufflerandomizes the order of test execution by seeding from the current time, and this seeded is reported at the top of test output for reproducing failures.make runtestnow randomizes by default.Note: this most likely shouldn't be instantly merged. Instead, you should try this out and fix any order-dependent tests you uncover. I have yet to find any others than #264.