From 9883b045c08cda6366d69ed1d866e70d0047c648 Mon Sep 17 00:00:00 2001 From: Zack Litzsinger Date: Mon, 24 Jun 2019 14:42:43 -0400 Subject: [PATCH 1/2] disable autocomplete always for select components --- package-lock.json | 63 ++++++++----------- src/components/Select/styles/CurrentValue.js | 5 +- .../Select/styles/SearchableCurrentValue.js | 1 + 3 files changed, 29 insertions(+), 40 deletions(-) diff --git a/package-lock.json b/package-lock.json index e3ca6b09..5554595f 100644 --- a/package-lock.json +++ b/package-lock.json @@ -739,19 +739,25 @@ } }, "@babel/polyfill": { - "version": "7.4.4", - "resolved": "https://registry.npmjs.org/@babel/polyfill/-/polyfill-7.4.4.tgz", - "integrity": "sha512-WlthFLfhQQhh+A2Gn5NSFl0Huxz36x86Jn+E9OW7ibK8edKPq+KLy4apM1yDpQ8kJOVi1OVjpP4vSDLdrI04dg==", + "version": "7.0.0", + "resolved": "https://registry.npmjs.org/@babel/polyfill/-/polyfill-7.0.0.tgz", + "integrity": "sha512-dnrMRkyyr74CRelJwvgnnSUDh2ge2NCTyHVwpOdvRMHtJUyxLtMAfhBN3s64pY41zdw0kgiLPh6S20eb1NcX6Q==", "dev": true, "requires": { - "core-js": "^2.6.5", - "regenerator-runtime": "^0.13.2" + "core-js": "^2.5.7", + "regenerator-runtime": "^0.11.1" }, "dependencies": { "core-js": { - "version": "2.6.5", - "resolved": "https://registry.npmjs.org/core-js/-/core-js-2.6.5.tgz", - "integrity": "sha512-klh/kDpwX8hryYL14M9w/xei6vrv6sE8gTHDG7/T/+SEovB/G4ejwcfE/CBzO6Edsu+OETZMZ3wcX/EjUkrl5A==", + "version": "2.6.9", + "resolved": "https://registry.npmjs.org/core-js/-/core-js-2.6.9.tgz", + "integrity": "sha512-HOpZf6eXmnl7la+cUdMnLvUxKNqLUzJvgIziQ0DiF3JwSImNphIqdGqzj6hIKyX04MmV0poclQ7+wjWvxQyR2A==", + "dev": true + }, + "regenerator-runtime": { + "version": "0.11.1", + "resolved": "https://registry.npmjs.org/regenerator-runtime/-/regenerator-runtime-0.11.1.tgz", + "integrity": "sha512-MguG95oij0fC3QV3URf4V2SDYGJhJnJGqvIIgdECeODCT98wSWDAJ94SSuVpYQUoTcGUIL6L4yNB7j1DFFHSBg==", "dev": true } } @@ -7151,8 +7157,7 @@ "ansi-regex": { "version": "2.1.1", "bundled": true, - "dev": true, - "optional": true + "dev": true }, "aproba": { "version": "1.2.0", @@ -7173,14 +7178,12 @@ "balanced-match": { "version": "1.0.0", "bundled": true, - "dev": true, - "optional": true + "dev": true }, "brace-expansion": { "version": "1.1.11", "bundled": true, "dev": true, - "optional": true, "requires": { "balanced-match": "^1.0.0", "concat-map": "0.0.1" @@ -7195,20 +7198,17 @@ "code-point-at": { "version": "1.1.0", "bundled": true, - "dev": true, - "optional": true + "dev": true }, "concat-map": { "version": "0.0.1", "bundled": true, - "dev": true, - "optional": true + "dev": true }, "console-control-strings": { "version": "1.1.0", "bundled": true, - "dev": true, - "optional": true + "dev": true }, "core-util-is": { "version": "1.0.2", @@ -7325,8 +7325,7 @@ "inherits": { "version": "2.0.3", "bundled": true, - "dev": true, - "optional": true + "dev": true }, "ini": { "version": "1.3.5", @@ -7338,7 +7337,6 @@ "version": "1.0.0", "bundled": true, "dev": true, - "optional": true, "requires": { "number-is-nan": "^1.0.0" } @@ -7353,7 +7351,6 @@ "version": "3.0.4", "bundled": true, "dev": true, - "optional": true, "requires": { "brace-expansion": "^1.1.7" } @@ -7361,14 +7358,12 @@ "minimist": { "version": "0.0.8", "bundled": true, - "dev": true, - "optional": true + "dev": true }, "minipass": { "version": "2.3.5", "bundled": true, "dev": true, - "optional": true, "requires": { "safe-buffer": "^5.1.2", "yallist": "^3.0.0" @@ -7387,7 +7382,6 @@ "version": "0.5.1", "bundled": true, "dev": true, - "optional": true, "requires": { "minimist": "0.0.8" } @@ -7468,8 +7462,7 @@ "number-is-nan": { "version": "1.0.1", "bundled": true, - "dev": true, - "optional": true + "dev": true }, "object-assign": { "version": "4.1.1", @@ -7481,7 +7474,6 @@ "version": "1.4.0", "bundled": true, "dev": true, - "optional": true, "requires": { "wrappy": "1" } @@ -7567,8 +7559,7 @@ "safe-buffer": { "version": "5.1.2", "bundled": true, - "dev": true, - "optional": true + "dev": true }, "safer-buffer": { "version": "2.1.2", @@ -7604,7 +7595,6 @@ "version": "1.0.2", "bundled": true, "dev": true, - "optional": true, "requires": { "code-point-at": "^1.0.0", "is-fullwidth-code-point": "^1.0.0", @@ -7624,7 +7614,6 @@ "version": "3.0.1", "bundled": true, "dev": true, - "optional": true, "requires": { "ansi-regex": "^2.0.0" } @@ -7668,14 +7657,12 @@ "wrappy": { "version": "1.0.2", "bundled": true, - "dev": true, - "optional": true + "dev": true }, "yallist": { "version": "3.0.3", "bundled": true, - "dev": true, - "optional": true + "dev": true } } }, diff --git a/src/components/Select/styles/CurrentValue.js b/src/components/Select/styles/CurrentValue.js index ec033850..f48c9c17 100644 --- a/src/components/Select/styles/CurrentValue.js +++ b/src/components/Select/styles/CurrentValue.js @@ -60,8 +60,8 @@ const Unsearchable = forwardRef( {...(disabled || loading ? {} : getToggleButtonProps({ - ref, - }))} + ref, + }))} > {!!inputValue && diff --git a/src/components/Select/styles/SearchableCurrentValue.js b/src/components/Select/styles/SearchableCurrentValue.js index 93fba34f..1079788b 100644 --- a/src/components/Select/styles/SearchableCurrentValue.js +++ b/src/components/Select/styles/SearchableCurrentValue.js @@ -48,6 +48,7 @@ const Searchable = forwardRef( value: inputValue, })} {...rest} + autoComplete={false} inlineContent={ {!!inputValue && From 2e32d2f9a8cdf56217c0eff71531f39ba99e3f97 Mon Sep 17 00:00:00 2001 From: Zack Litzsinger Date: Thu, 8 Aug 2019 14:14:35 -0400 Subject: [PATCH 2/2] pr feedback --- src/components/Select/Select.js | 1 + src/components/Select/styles/CurrentValue.js | 1 - src/components/Select/styles/SearchableCurrentValue.js | 1 - 3 files changed, 1 insertion(+), 2 deletions(-) diff --git a/src/components/Select/Select.js b/src/components/Select/Select.js index f0171f89..7d1d1de1 100644 --- a/src/components/Select/Select.js +++ b/src/components/Select/Select.js @@ -106,6 +106,7 @@ class Select extends React.PureComponent { defaultHighlightedIndex: 0, CurrentValue: styles.CurrentValue, Options: styles.Options, + autoComplete: false, }; static styles = styles; diff --git a/src/components/Select/styles/CurrentValue.js b/src/components/Select/styles/CurrentValue.js index f48c9c17..85a31863 100644 --- a/src/components/Select/styles/CurrentValue.js +++ b/src/components/Select/styles/CurrentValue.js @@ -73,7 +73,6 @@ const Unsearchable = forwardRef( value={inputValue} hideCursor {...rest} - autoComplete={false} /> {!!inputValue && diff --git a/src/components/Select/styles/SearchableCurrentValue.js b/src/components/Select/styles/SearchableCurrentValue.js index 1079788b..93fba34f 100644 --- a/src/components/Select/styles/SearchableCurrentValue.js +++ b/src/components/Select/styles/SearchableCurrentValue.js @@ -48,7 +48,6 @@ const Searchable = forwardRef( value: inputValue, })} {...rest} - autoComplete={false} inlineContent={ {!!inputValue &&