Fix Examples#152
Merged
Merged
Conversation
- Fix bitbox import path - Shorten bitbox import/initialisation - Use the NETWORK parameter as an argument directly (rather than if-else) - Replace some forloops with forEach - Refactor OP_RETURN example to use async/await - Fix linting issues - Minor other changes
Update examples
SpicyPete
approved these changes
Nov 4, 2019
SpicyPete
left a comment
SpicyPete
left a comment
There was a problem hiding this comment.
Looks like good changes and cleanup
paOol
approved these changes
Nov 4, 2019
|
🎉 This PR is included in version 8.8.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains Rosco's work in fixing the bitbox-sdk examples. This PR does not need a version bump as it does not effect the npm library.