Fixing getTXOut#156
Merged
Merged
Conversation
Merged
christroutner
commented
Nov 18, 2019
SpendBCH
approved these changes
Nov 18, 2019
|
🎉 This PR is included in version 8.8.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this PR, the
BITBOX.Blockchain.getTxOut()call didn't work at all. This PR fixes this endpoint, adds unit tests, and also adds integration tests. It resolves the outstanding Issue #147.The getTxOut() function is important for validating that a UTXO is valid. The typical workflow is to get UTXOs from an indexer. This call to the full node should be exercised to validate these UTXO before attempting to spend them.