Move some @types to "dependencies"#159
Merged
Merged
Conversation
These @types are needed if a TS project is rebuilding bitbox-sdk from source. This would be the case even if .d.ts files were published instead of .ts files since the .d.ts file would still have references to these dependent types. Also, on a separate note. Maybe something to consider in a future release is to publish `.d.ts` files instead of the `.ts` files. I'm currently planning on doing this for `slpjs` soon, but right now I'm struggling with some strange issue preventing me from doing so.
christroutner
approved these changes
Nov 21, 2019
christroutner
left a comment
christroutner
left a comment
There was a problem hiding this comment.
I have run unit and integration tests against this PR and there were no failures.
|
🎉 This PR is included in version 8.8.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These @types are needed if a TS project is rebuilding bitbox-sdk from source. This would be the case even if .d.ts files were published instead of .ts files since the .d.ts file would still have references to these dependent types.
Also, on a separate note. Maybe something to consider in a future release is to publish
.d.tsfiles instead of the.tsfiles. I'm currently planning on doing this forslpjssoon, but right now I'm struggling with some strange issue preventing me from doing so.