From 10d631aa638e572fa1d4998ee99ca8d4aec14327 Mon Sep 17 00:00:00 2001
From: dmeidlin <14339308+dmeidlin@users.noreply.github.com>
Date: Wed, 21 Jun 2023 12:14:27 -0400
Subject: [PATCH] add check for legacy trait names in ExperimentProcessor

---
 .../importer/services/processors/ExperimentProcessor.java   | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/main/java/org/breedinginsight/brapps/importer/services/processors/ExperimentProcessor.java b/src/main/java/org/breedinginsight/brapps/importer/services/processors/ExperimentProcessor.java
index f9c79bdd9..d6aeb478f 100644
--- a/src/main/java/org/breedinginsight/brapps/importer/services/processors/ExperimentProcessor.java
+++ b/src/main/java/org/breedinginsight/brapps/importer/services/processors/ExperimentProcessor.java
@@ -841,6 +841,12 @@ private void addObsVarsToDatasetDetails(PendingImportObject<BrAPIListDetails> pi
         BrAPIListDetails details = pio.getBrAPIObject();
         referencedTraits.forEach(trait -> {
             String id = Utilities.appendProgramKey(trait.getObservationVariableName(), program.getKey());
+
+            // Don't append the key if connected to a brapi service operating with legacy data(no appended program key)
+            if (trait.getFullName() == null) {
+                id = trait.getObservationVariableName();
+            }
+
             if (!details.getData().contains(id) && ImportObjectState.EXISTING != pio.getState()) {
                 details.getData().add(id);
             }