diff --git a/src/breeding-insight/model/Scale.ts b/src/breeding-insight/model/Scale.ts index 94169fc44..5d072dc2c 100644 --- a/src/breeding-insight/model/Scale.ts +++ b/src/breeding-insight/model/Scale.ts @@ -27,14 +27,16 @@ export enum DataType { export class Scale { scaleName?: string; + units?: string; dataType?: string; categories?: Array; decimalPlaces?: number; validValueMin?: number; validValueMax?: number; - constructor(scaleName?:string, dataType?:string, categories?:Array, decimalPlaces?:number, validValueMin?:number, validValueMax?: number) { + constructor(scaleName?:string, units?:string, dataType?:string, categories?:Array, decimalPlaces?:number, validValueMin?:number, validValueMax?: number) { this.scaleName = scaleName; + this.units = units; this.dataType = dataType; if (categories) { this.categories = categories.map(category => new Category(category.label, category.value)); @@ -45,7 +47,7 @@ export class Scale { } static assign(scale: Scale) { - return new Scale(scale.scaleName, scale.dataType, scale.categories, scale.decimalPlaces, + return new Scale(scale.scaleName, scale.units, scale.dataType, scale.categories, scale.decimalPlaces, scale.validValueMin, scale.validValueMax); } @@ -71,6 +73,7 @@ export class Scale { equals(scale?: Scale): boolean { if (!scale) {return false;} return (this.scaleName === scale.scaleName) && + (this.units === scale.units) && (this.dataType === scale.dataType) && (this.decimalPlaces === scale.decimalPlaces) && (this.validValueMin === scale.validValueMin) && diff --git a/src/components/trait/forms/BaseTraitForm.vue b/src/components/trait/forms/BaseTraitForm.vue index a16b1b97c..44511d31d 100644 --- a/src/components/trait/forms/BaseTraitForm.vue +++ b/src/components/trait/forms/BaseTraitForm.vue @@ -258,11 +258,11 @@
@@ -89,7 +89,7 @@ }) export default class NumericalTraitForm extends Vue { @Prop() - private unit: string | undefined; + private units: string | undefined; @Prop() private decimalPlaces: number | undefined; @Prop() diff --git a/tests/unit/components/tables/SidePanelTable.spec.ts b/tests/unit/components/tables/SidePanelTable.spec.ts index 1e63762db..3fc56fde6 100644 --- a/tests/unit/components/tables/SidePanelTable.spec.ts +++ b/tests/unit/components/tables/SidePanelTable.spec.ts @@ -39,7 +39,7 @@ function setup() { // Mock trait response const method = new Method('Test Method', 'Computation', 'A method', '1=1'); - const scale = new Scale('Test Scale', 'Number', undefined, 3, 0, 999); + const scale = new Scale('Test Scale', 'cm', 'Number', undefined, 3, 0, 999); const level = new ProgramObservationLevel('Plant'); const range = [...Array(200).keys()]; traits = range.map((i:number) => new Trait(i.toString(), `Trait${i}`, `Trait${i}`, level, undefined, undefined, undefined, method, scale));