From 3434a527273db5b983735662032f8ccf51a019e8 Mon Sep 17 00:00:00 2001 From: cvacalares Date: Sat, 24 May 2025 16:12:32 -0700 Subject: [PATCH 1/3] Add test for BI-2390. Add function isDeleteVisible for checking the delete button of the collaborator. --- src/features/BI-2390.feature | 58 +++++++++++++++++++ .../experimentsObservationsPage.js | 3 + .../experimentsObservationsSteps.js | 4 ++ 3 files changed, 65 insertions(+) create mode 100644 src/features/BI-2390.feature diff --git a/src/features/BI-2390.feature b/src/features/BI-2390.feature new file mode 100644 index 00000000..c561fd27 --- /dev/null +++ b/src/features/BI-2390.feature @@ -0,0 +1,58 @@ +Feature: Program Administrator can see a delete button next to each collaborator + + Background: + Given a new program is created + +@debug + @BI-2390 + Scenario Outline: Program Administrator can see a delete button next to each collaborator + Given user logs in as "Cucumber Breeder" + When user selects "*" on program-selection page + And user selects "Program Administration" in top-level navigation + And user selects New User button + And user sets "Experimental Collaborator1" in Name field of User + And user sets "experimentcollaborator1@mailinator.com" in Email field of User + And user selects "Experimental Collaborator" in Role dropdown + And user selects Save button + And user pause for "5" seconds + And user selects New User button + And user sets "Experimental Collaborator2" in Name field of User + And user sets "experimentcollaborator2@mailinator.com" in Email field of User + And user selects "Experimental Collaborator" in Role dropdown + And user selects Save button + And user pause for "5" seconds + And user selects "Germplasm" in top-level navigation + And user selects "Manage Germplasm" button + And user selects "Import file" menu item + And user uploads Germplasm "GermplasmSample.xlsx" file + And user selects 'Import' button + When user sets "GermplasmSort" in List Name field of import page + When user sets "GermplasmSort" in List Description field of import page + And user selects "Confirm" button + When user selects "Ontology" in navigation + When user selects "Manage Ontology" button + When user selects "Import file" link + And user uploads Ontology "test01-ontology.xls" file + When user selects 'Import' button + When user selects "Confirm" button + And user pause for "5" seconds + When user selects "Experiments & Observations" in navigation + When user selects "Import Experiments & Observations" button + And user uploads Experiments & Observations "BI-2056.csv" file + When user selects 'Import' button + When user selects "Confirm" button + And user pause for "5" seconds + And user selects "Experiments & Observations" in top-level navigation + And user selects "New Trial DRP1" of row "1" of Experiments page + And user selects "Manage Experiment" button + And user selects "Add Collaborator" link + And user selects "Save" button + And user pause for "2" seconds + And user selects "Manage Experiment" button + And user selects "Add Collaborator" link + And user selects "Save" button + And user pause for "2" seconds + And user can see "Experimental Collaborator1(experimentcollaborator1@mailinator.com)" as Collaborator + And user can see "Experimental Collaborator2(experimentcollaborator2@mailinator.com)" as Collaborator + And user can see "Experimental Collaborator1(experimentcollaborator1@mailinator.com)" delete button of Collaborator + And user can see "Experimental Collaborator2(experimentcollaborator2@mailinator.com)" delete button of Collaborator \ No newline at end of file diff --git a/src/page_objects/experimentsObservationsPage.js b/src/page_objects/experimentsObservationsPage.js index e1577660..14ce4d80 100644 --- a/src/page_objects/experimentsObservationsPage.js +++ b/src/page_objects/experimentsObservationsPage.js @@ -23,6 +23,9 @@ module.exports = { isDeleteNotVisible: async function (collaborator) { this.assert.not.visible({selector:`//li[contains((.), '${collaborator}')]//button`, locateStrategy:"xpath"}); }, + isDeleteVisible: async function (collaborator) { + this.assert.visible({selector:`//li[contains((.), '${collaborator}')]//button`, locateStrategy:"xpath"}); + }, deleteCollaborator: async function (collaborator) { this.api.click({selector:`//li[contains((.), '${collaborator}')]//button`, locateStrategy:"xpath"}); } diff --git a/src/step_definitions/experimentsObservationsSteps.js b/src/step_definitions/experimentsObservationsSteps.js index 36780f19..8badd6e3 100644 --- a/src/step_definitions/experimentsObservationsSteps.js +++ b/src/step_definitions/experimentsObservationsSteps.js @@ -18,6 +18,10 @@ When('user can not see {string} delete button of Collaborator', async function(s await this.browser.page.experimentsObservationsPage().isDeleteNotVisible(s); }) +When('user can see {string} delete button of Collaborator', async function(s) { + await this.browser.page.experimentsObservationsPage().isDeleteVisible(s); +}) + When('user selects {string} delete button of Collaborator', async function (s) { await this.browser.page.experimentsObservationsPage().deleteCollaborator(s); }) From c28734217fd05590258bee87f588e5349729412c Mon Sep 17 00:00:00 2001 From: cvacalares Date: Tue, 27 May 2025 11:58:46 -0700 Subject: [PATCH 2/3] Remove the debug tag. --- src/features/BI-2390.feature | 1 - 1 file changed, 1 deletion(-) diff --git a/src/features/BI-2390.feature b/src/features/BI-2390.feature index c561fd27..1bb1e220 100644 --- a/src/features/BI-2390.feature +++ b/src/features/BI-2390.feature @@ -3,7 +3,6 @@ Feature: Program Administrator can see a delete button next to each collaborator Background: Given a new program is created -@debug @BI-2390 Scenario Outline: Program Administrator can see a delete button next to each collaborator Given user logs in as "Cucumber Breeder" From d9f5a05a38f1b80eefc2980b4b9081f47ebb41ff Mon Sep 17 00:00:00 2001 From: cvacalares Date: Tue, 15 Jul 2025 09:06:32 -0700 Subject: [PATCH 3/3] Change from And to Then. --- src/features/BI-2390.feature | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/features/BI-2390.feature b/src/features/BI-2390.feature index 1bb1e220..ff9747c1 100644 --- a/src/features/BI-2390.feature +++ b/src/features/BI-2390.feature @@ -51,7 +51,7 @@ Feature: Program Administrator can see a delete button next to each collaborator And user selects "Add Collaborator" link And user selects "Save" button And user pause for "2" seconds - And user can see "Experimental Collaborator1(experimentcollaborator1@mailinator.com)" as Collaborator + Then user can see "Experimental Collaborator1(experimentcollaborator1@mailinator.com)" as Collaborator And user can see "Experimental Collaborator2(experimentcollaborator2@mailinator.com)" as Collaborator And user can see "Experimental Collaborator1(experimentcollaborator1@mailinator.com)" delete button of Collaborator And user can see "Experimental Collaborator2(experimentcollaborator2@mailinator.com)" delete button of Collaborator \ No newline at end of file