From 0b9ffa81a895a02189c23cddbbb4c3a14ffcb33d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Antoine=20Del=C3=A8gue?= Date: Thu, 28 Oct 2021 19:00:21 +0200 Subject: [PATCH] :bug: Fix the null pointer error issue when deleting a code block in when trying to access it. --- opencodeblocks/graphics/view.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/opencodeblocks/graphics/view.py b/opencodeblocks/graphics/view.py index ad606233..880447f9 100644 --- a/opencodeblocks/graphics/view.py +++ b/opencodeblocks/graphics/view.py @@ -6,6 +6,7 @@ from PyQt5.QtCore import QEvent, QPointF, Qt from PyQt5.QtGui import QMouseEvent, QPainter, QWheelEvent from PyQt5.QtWidgets import QGraphicsView +from sip import isdeleted from opencodeblocks.graphics.scene import OCBScene from opencodeblocks.graphics.socket import OCBSocket @@ -142,7 +143,6 @@ def deleteSelected(self): def bring_forward(self, event: QMouseEvent): """ When a codeblock is selected, it will be drawn in front of other blocks """ - scene = self.scene() item_at_click = self.itemAt(event.pos()) if item_at_click is None: return event @@ -153,7 +153,7 @@ def bring_forward(self, event: QMouseEvent): item_at_click = item_at_click.parentItem() if isinstance(item_at_click, OCBBlock): - if self.currentSelectedBlock is not None: + if self.currentSelectedBlock is not None and not isdeleted(self.currentSelectedBlock): self.currentSelectedBlock.setZValue(0) item_at_click.setZValue(1) self.currentSelectedBlock = item_at_click