Proper checking for np.array == None#48
Merged
Merged
Conversation
The current codebase checks `np.array == None` in a lot of places, for instance for body forces in core.planqe. This causes an exception in numpy, crashing the program. This change instead uses the `np.array is None` pattern to do such checks, as it instead compares the type of the array to None, rather than the value (which == does).
jonaslindemann
approved these changes
Sep 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current codebase checks
np.array == Nonein a lot of places, for instance for body forces in core.planqe. This causes an exception in numpy, crashing the program.This change instead uses the
np.array is Nonepattern to do such checks, as it instead compares the type of the array to None, rather than the value (which == does).