From aeeaea0ac321dd6634eea364e9caee6aaddb7504 Mon Sep 17 00:00:00 2001 From: Neeraj-gagat Date: Mon, 15 Dec 2025 22:42:22 +0530 Subject: [PATCH 1/2] fixed bugs in dialog --- frontend/src/components/HomeComponents/Tasks/TaskDialog.tsx | 4 ++-- frontend/src/components/HomeComponents/Tasks/Tasks.tsx | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/frontend/src/components/HomeComponents/Tasks/TaskDialog.tsx b/frontend/src/components/HomeComponents/Tasks/TaskDialog.tsx index 80a0c500..c7788f46 100644 --- a/frontend/src/components/HomeComponents/Tasks/TaskDialog.tsx +++ b/frontend/src/components/HomeComponents/Tasks/TaskDialog.tsx @@ -91,8 +91,8 @@ export const TaskDialog = ({ data-testid={`task-row-${task.id}`} id={`task-row-${task.id}`} key={index} - className={`border-b cursor-pointer ${ - selectedIndex === index ? 'bg-muted/50' : '' + className={`border-b cursor-pointer hover:dark:bg-muted/50 hover:bg-black/15 ${ + selectedIndex === index ? 'dark:bg-muted/50 bg-black/15' : '' }`} onClick={() => { onSelectTask(task, index); diff --git a/frontend/src/components/HomeComponents/Tasks/Tasks.tsx b/frontend/src/components/HomeComponents/Tasks/Tasks.tsx index 5043fba0..808773ac 100644 --- a/frontend/src/components/HomeComponents/Tasks/Tasks.tsx +++ b/frontend/src/components/HomeComponents/Tasks/Tasks.tsx @@ -151,6 +151,7 @@ export const Tasks = ( target instanceof HTMLTextAreaElement || target instanceof HTMLSelectElement || _isDialogOpen || + isAddTaskOpen || target.isContentEditable ) { return; From 69a03c8c3864cceb934541482ed10b34147677be Mon Sep 17 00:00:00 2001 From: Neeraj-gagat Date: Mon, 15 Dec 2025 22:59:03 +0530 Subject: [PATCH 2/2] fixed #281 --- .../components/HomeComponents/Tasks/TaskDialog.tsx | 1 + .../Tasks/__tests__/TaskDialog.test.tsx | 11 ++++------- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/frontend/src/components/HomeComponents/Tasks/TaskDialog.tsx b/frontend/src/components/HomeComponents/Tasks/TaskDialog.tsx index c7788f46..a85c4702 100644 --- a/frontend/src/components/HomeComponents/Tasks/TaskDialog.tsx +++ b/frontend/src/components/HomeComponents/Tasks/TaskDialog.tsx @@ -94,6 +94,7 @@ export const TaskDialog = ({ className={`border-b cursor-pointer hover:dark:bg-muted/50 hover:bg-black/15 ${ selectedIndex === index ? 'dark:bg-muted/50 bg-black/15' : '' }`} + data-selected={selectedIndex === index} onClick={() => { onSelectTask(task, index); }} diff --git a/frontend/src/components/HomeComponents/Tasks/__tests__/TaskDialog.test.tsx b/frontend/src/components/HomeComponents/Tasks/__tests__/TaskDialog.test.tsx index acb52c8b..8961e98e 100644 --- a/frontend/src/components/HomeComponents/Tasks/__tests__/TaskDialog.test.tsx +++ b/frontend/src/components/HomeComponents/Tasks/__tests__/TaskDialog.test.tsx @@ -609,19 +609,16 @@ describe('TaskDialog Component', () => { describe('Selected State', () => { test('should highlight selected task row', () => { - const { container } = render( - - ); + render(); - const taskRow = container.querySelector('.bg-muted\\/50'); - expect(taskRow).toBeInTheDocument(); + const taskRow = screen.getByText(mockTask.description).closest('tr'); + expect(taskRow).toHaveAttribute('data-selected', 'true'); }); test('should not highlight non-selected task row', () => { render(); - const taskRow = screen.getByText(mockTask.description).closest('tr'); - expect(taskRow).not.toHaveClass('bg-muted/50'); + expect(taskRow).toHaveAttribute('data-selected', 'false'); }); });