diff --git a/java-migration/.gitignore b/java-migration/.gitignore new file mode 100644 index 0000000..2469533 --- /dev/null +++ b/java-migration/.gitignore @@ -0,0 +1,13 @@ +# Gradle +.gradle/ +build/ + +# IDE +.classpath +.project +.settings/ +.idea/ +*.iml + +# OS +.DS_Store diff --git a/java-migration/MIGRATION_NOTES.md b/java-migration/MIGRATION_NOTES.md new file mode 100644 index 0000000..9010025 --- /dev/null +++ b/java-migration/MIGRATION_NOTES.md @@ -0,0 +1,162 @@ +# Migration Notes: COBOL to Java Spring Boot + +This document records the key translation decisions made during the migration from GnuCOBOL to Java Spring Boot. + +## Data Type Translations + +### COBOL PIC Clauses to Java Types + +| COBOL Type | Example | Java Type | Notes | +|---|---|---|---| +| `PIC X(n)` | `PIC X(8)` | `String` | `.trim()` applied at data boundaries to handle COBOL space-padding | +| `PIC 9(n)` | `PIC 9(5)` | `int` or `long` | Width mapped to appropriate integer type | +| `PIC 9(n) COMP` | `PIC 999 COMP` | `BigDecimal` (via `NumericUtils.fromComp`) | Binary integer storage → BigDecimal for precision | +| `PIC COMP-2` | `ws-total COMP-2` | `BigDecimal` (via `NumericUtils.fromComp2`) | Double-precision float → BigDecimal to avoid FP errors | +| `PIC COMP-3` | Packed decimal | `BigDecimal` (via `NumericUtils.fromComp3`) | BCD packed → BigDecimal with explicit scale | +| `PIC COMP-5` | `PIC S9(4) COMP-5` | `int` | Native binary → primitive int | +| `PIC X` (single char) | `ws-sql-account-is-enabled` | `Character` | Single character fields map to Character wrapper | +| `PIC X(20)` (timestamp) | `ws-sql-account-create-dt` | `LocalDateTime` | COBOL string timestamps → Java temporal types | +| `PIC ZZ9` | Dynamic display | `String` via `NumericUtils.toDynamicDisplay` | Leading zero suppression | +| 88-level conditions | `88 ws-account-enabled VALUE 'Y'` | Boolean methods or Character comparison | Condition names → explicit comparisons | + +### REDEFINES → Inheritance / Conversion Methods + +COBOL `REDEFINES` allows multiple interpretations of the same memory area. In Java: +- **Simple redefines**: Use type conversion methods (e.g., `Integer.parseInt(stringField)`) +- **Complex redefines**: Use separate classes with conversion constructors +- **Union-type redefines**: Use Java records or sealed classes with pattern matching + +Example from `redifines/redefines.cbl`: A COMP-2 field redefining a PIC X field becomes a conversion method that parses the string representation into a BigDecimal. + +## Database Layer Translations + +### Cursor Fetch → JPA Queries + +| COBOL Pattern | Java Equivalent | +|---|---| +| `DECLARE cursor CURSOR FOR SELECT...` | Spring Data JPA method or `@Query` annotation | +| `OPEN cursor` | Implicit (JPA manages connection lifecycle) | +| `FETCH cursor INTO :host-vars` | Return value from repository method | +| `CLOSE cursor` | Implicit (JPA manages connection lifecycle) | +| `CONNECT TO :connection-string` | `application.properties` + Spring auto-configuration | +| `CONNECT RESET` | Implicit (connection pool management) | +| `SQLSTATE` / `SQLCODE` checking | Exception handling (try/catch or `@Transactional`) | + +### Specific Cursor Mappings + +| COBOL Cursor | SQL | Java Method | +|---|---|---| +| `ACCOUNT-ALL-CUR` | `SELECT ... FROM ACCOUNTS ORDER BY ID` | `findAllByOrderByIdAsc()` | +| `ACCOUNT-DISABLED-CUR` | `SELECT ... WHERE IS_ENABLED = 'N' ORDER BY ID` | `findByIsEnabledOrderByIdAsc('N')` | +| `ACCOUNT-QUERY-CUR` | `SELECT ... WHERE FIRST_NAME LIKE :val OR ...` | `searchAccounts(String)` with `@Query` | + +### Variable-Length Strings in SQL + +COBOL uses `PIC S9(4) COMP-5` + `PIC X(50)` pair for variable-length strings in WHERE clauses (sql_example.cbl lines 65-67). In Java, JPA/JDBC handles string length automatically — no special handling needed. + +## Subprogram Call Translations + +### BY CONTENT vs BY REFERENCE + +| COBOL Pattern | Java Equivalent | Semantics | +|---|---|---| +| `CALL "sub" USING BY CONTENT ws-var` | `callByContent(String value)` | Pass immutable copy — caller's variable unchanged | +| `CALL "sub" USING ws-var` (BY REFERENCE) | `callByReference(MutableString ref)` | Pass mutable wrapper — caller's variable can be modified | +| `CANCEL "sub-app"` | `cancel()` | Reset service instance state | + +### Storage Section Mapping + +| COBOL Section | Java Equivalent | Lifetime | +|---|---|---| +| WORKING-STORAGE SECTION | Instance fields | Persists between method calls until `cancel()` | +| LOCAL-STORAGE SECTION | Method-local variables | Fresh on each invocation | +| LINKAGE SECTION | Method parameters | Passed by caller | + +## File Processing Translations + +### SORT/MERGE → Java Collections + +| COBOL Statement | Java Equivalent | +|---|---| +| `MERGE fd ON ASCENDING KEY f-id USING f1 f2 GIVING f-out` | Read both files → `ArrayList.addAll()` → `Collections.sort()` → write output | +| `SORT fd ON DESCENDING KEY f-contract-id USING f-in GIVING f-out` | Read file → `sort(Comparator.reversed())` → write output | +| `SD fd-sorting-file` (sort description) | Not needed — sorting is in-memory | +| File status checking (`ws-fs-status`) | IOException handling | + +### Fixed-Width Records + +COBOL FD records use fixed-width fields defined by PIC clauses. In Java: +- Parsing: `String.substring()` with calculated offsets +- Writing: `String.format()` with width specifiers +- The `CustomerRecord.fromFixedWidth()` and `toString()` methods handle this conversion + +## Serialization Translations + +### JSON GENERATE → Jackson + +| COBOL Feature | Jackson Equivalent | +|---|---| +| `JSON GENERATE ws-output FROM ws-record` | `objectMapper.writeValueAsString(dto)` | +| `NAME OF ws-field IS "jsonName"` | `@JsonProperty("jsonName")` | +| `COUNT IN ws-count` | `json.length()` | +| Suppress blank fields | `@JsonInclude(JsonInclude.Include.NON_EMPTY)` | + +### XML GENERATE → JAXB + +| COBOL Feature | JAXB Equivalent | +|---|---| +| `XML GENERATE ws-output FROM ws-record` | `marshaller.marshal(dto, writer)` | +| `WITH XML-DECLARATION` | `Marshaller.JAXB_FRAGMENT = false` | +| `NAME OF ws-field IS "xmlName"` | `@XmlElement(name = "xmlName")` | +| `TYPE OF ws-field IS ATTRIBUTE` | `@XmlAttribute(name = "attrName")` | +| `SUPPRESS WHEN SPACES` | Set field to `null` in constructor when blank | +| `COUNT IN ws-count` | `xml.length()` | + +## Report Writer Translation + +### RD (Report Description) → ReportService + +| COBOL Feature | Java Equivalent | +|---|---| +| `RD r-report PAGE LIMIT IS 66` | `PAGE_LIMIT = 66` constant | +| `HEADING IS 1` | Header generated at start of each page | +| `FIRST DETAIL 6` | Detail lines start after 5 header lines | +| `LAST DETAIL 42` | `maxDetailsPerPage = 42 - 6 + 1 = 37` | +| `TYPE REPORT HEADING` | `generatePageHeader()` method | +| `TYPE DETAIL LINE PLUS 1` | `formatDetailLine()` method | +| `SOURCE page-counter` | `pageNumber` local variable | +| `INITIATE r-report` | Constructor / method start | +| `GENERATE report-line` | Add formatted line to list | +| `TERMINATE r-report` | Return the complete list | + +## String Operation Translations + +| COBOL Operation | Java Equivalent | Source File | +|---|---|---| +| `FUNCTION TRIM(val)` | `String.trim()` / `StringUtils.trim()` | `trim/trim.cbl` | +| `FUNCTION TRIM(val LEADING)` | `String.stripLeading()` | `trim/trim.cbl` | +| `FUNCTION TRIM(val TRAILING)` | `String.stripTrailing()` | `trim/trim.cbl` | +| `UNSTRING src DELIMITED BY delim INTO dest1 dest2` | `StringUtils.unstring()` / `String.split()` | `unstring/unstring.cbl` | +| `val IS NUMERIC` | `StringUtils.isNumeric()` (regex) | `is_numeric/is_numeric.cbl` | +| `FUNCTION NUMVAL(val)` | `StringUtils.numval()` → `BigDecimal` | `numval_test/numval_test.cbl` | +| `ACCEPT val FROM COMMAND-LINE` | `ApplicationArguments.getSourceArgs()` | `read_command_args/` | +| `INSPECT ... TALLYING ... FOR ALL` | `String.contains()` / stream count | `read_command_args/` | +| `FUNCTION UPPER-CASE(val)` | `String.toUpperCase()` | `sql_example.cbl` | +| `FUNCTION LOWER-CASE(val)` | `String.toLowerCase()` | `read_cmd_line_args.cbl` | +| `FUNCTION STORED-CHAR-LENGTH(val)` | `String.length()` (after trim) | `sql_example.cbl` | + +## Design Decisions + +1. **BigDecimal over primitives**: All financial/numeric-precision fields use `BigDecimal` to prevent floating-point errors that COBOL's packed decimal types naturally avoid. + +2. **`.trim()` at boundaries**: COBOL PIC X fields are right-padded with spaces. We apply `.trim()` when reading from database, files, or user input to normalize data. + +3. **Spring profiles for CLI vs REST**: The `cli` profile activates the interactive Scanner-based menu. The default profile runs only the REST API, providing a modern HTTP interface. + +4. **H2 for testing**: Tests use an in-memory H2 database in PostgreSQL compatibility mode, avoiding the need for a running PostgreSQL instance during CI/CD. + +5. **No ORM for file processing**: The `FileMergeService` uses plain file I/O (`java.nio.file`) rather than JPA, since the COBOL SORT/MERGE operates on sequential files, not database tables. + +6. **Mutable wrapper for by-reference**: Java strings are immutable, so we introduced `SubProgramService.MutableString` to faithfully model COBOL's CALL BY REFERENCE semantics where the called program can modify the caller's variables. + +7. **Null for SUPPRESS WHEN SPACES**: COBOL's `SUPPRESS WHEN SPACES` in XML GENERATE is implemented by setting blank fields to `null` in the DTO constructor, which causes JAXB to omit them from output. diff --git a/java-migration/README.md b/java-migration/README.md new file mode 100644 index 0000000..5d2fb6c --- /dev/null +++ b/java-migration/README.md @@ -0,0 +1,142 @@ +# COBOL-to-Java Spring Boot Migration + +This directory contains the Java Spring Boot equivalent of the COBOL programs in the parent repository. The migration preserves the original business logic while modernizing the technology stack. + +## Technology Stack + +- **Java 17+** +- **Spring Boot 3.2.x** +- **Spring Data JPA** (replaces embedded SQL / ODBC) +- **PostgreSQL** (same database as COBOL version) +- **Jackson** (replaces COBOL JSON GENERATE) +- **JAXB** (replaces COBOL XML GENERATE) +- **JUnit 5 + AssertJ** (testing) +- **H2** (in-memory database for tests) +- **Gradle** (build system) + +## Project Structure + +``` +java-migration/ +├── build.gradle +├── settings.gradle +├── README.md +├── MIGRATION_NOTES.md +├── src/ +│ ├── main/ +│ │ ├── java/com/cobolmigration/ +│ │ │ ├── CobolMigrationApplication.java # Spring Boot entry point +│ │ │ ├── model/ +│ │ │ │ ├── Account.java # JPA entity (sql_example.cbl) +│ │ │ │ ├── CustomerRecord.java # File record (merge_sort_test.cbl) +│ │ │ │ └── StudentRecord.java # Report record (report_test.cbl) +│ │ │ ├── repository/ +│ │ │ │ └── AccountRepository.java # JPA repository (3 COBOL cursors) +│ │ │ ├── service/ +│ │ │ │ ├── AccountService.java # Account CRUD (sql_example.cbl) +│ │ │ │ ├── FileMergeService.java # SORT/MERGE (merge_sort_test.cbl) +│ │ │ │ ├── SubProgramService.java # CALL patterns (sub_program/) +│ │ │ │ ├── JsonService.java # JSON gen (json_generate.cbl) +│ │ │ │ ├── XmlService.java # XML gen (xml_generate.cbl) +│ │ │ │ └── ReportService.java # Report Writer (report_test.cbl) +│ │ │ ├── dto/ +│ │ │ │ ├── RecordDto.java # JSON DTO with @JsonProperty +│ │ │ │ └── RecordXmlDto.java # XML DTO with @XmlAttribute +│ │ │ ├── util/ +│ │ │ │ ├── StringUtils.java # TRIM, UNSTRING, IS NUMERIC, NUMVAL +│ │ │ │ └── NumericUtils.java # COMP/COMP-3 handling +│ │ │ ├── cli/ +│ │ │ │ ├── AccountCli.java # Interactive menu (sql_example.cbl) +│ │ │ │ └── CommandLineArgsRunner.java # CLI args (read_cmd_line_args.cbl) +│ │ │ └── controller/ +│ │ │ └── AccountController.java # REST API alternative +│ │ └── resources/ +│ │ ├── application.properties # DB config +│ │ └── db/migration/ +│ │ └── V1__create_accounts_table.sql # Schema + seed data +│ └── test/ +│ ├── java/com/cobolmigration/ +│ │ ├── repository/AccountRepositoryTest.java +│ │ ├── service/ +│ │ │ ├── AccountServiceTest.java +│ │ │ ├── FileMergeServiceTest.java +│ │ │ ├── SubProgramServiceTest.java +│ │ │ ├── JsonServiceTest.java +│ │ │ ├── XmlServiceTest.java +│ │ │ └── ReportServiceTest.java +│ │ ├── util/ +│ │ │ ├── StringUtilsTest.java +│ │ │ └── NumericUtilsTest.java +│ │ └── controller/AccountControllerTest.java +│ └── resources/ +│ └── application-test.properties +``` + +## COBOL Module to Java Mapping + +| COBOL Module | COBOL File(s) | Java Equivalent | Description | +|---|---|---|---| +| SQL Database Access | `sql/sql_example.cbl` | `Account.java`, `AccountRepository.java`, `AccountService.java` | PostgreSQL CRUD with cursors → JPA + Spring Data | +| SQL Schema | `sql/create_test_db.sql` | `V1__create_accounts_table.sql` | Database schema and seed data | +| JSON Generation | `json_generate/json_generate.cbl` | `RecordDto.java`, `JsonService.java` | JSON GENERATE → Jackson ObjectMapper | +| XML Generation | `xml_generate/xml_generate.cbl` | `RecordXmlDto.java`, `XmlService.java` | XML GENERATE → JAXB Marshaller | +| Sort/Merge | `merge_sort/merge_sort_test.cbl` | `CustomerRecord.java`, `FileMergeService.java` | SORT/MERGE → Collections.sort + Streams | +| Report Writer | `report_writer/report_test.cbl` | `StudentRecord.java`, `ReportService.java` | RD report → String.format() | +| Subprogram Calls | `sub_program/main_app.cbl`, `sub_program/sub.cbl` | `SubProgramService.java` | CALL BY CONTENT/REFERENCE → method params | +| String Trim | `trim/trim.cbl` | `StringUtils.trim/trimLeading/trimTrailing` | FUNCTION TRIM → String.strip* | +| Unstring | `unstring/unstring.cbl` | `StringUtils.unstring()` | UNSTRING → String.split with regex | +| Is Numeric | `is_numeric/is_numeric.cbl` | `StringUtils.isNumeric()` | IS NUMERIC → regex pattern | +| Numval | `numval_test/numval_test.cbl` | `StringUtils.numval()` | FUNCTION NUMVAL → BigDecimal parsing | +| COMP Types | `comp_test/comp_test.cbl` | `NumericUtils` | COMP/COMP-2/COMP-3 → BigDecimal | +| Command Args | `read_command_args/read_cmd_line_args.cbl` | `CommandLineArgsRunner.java` | ACCEPT FROM COMMAND-LINE → ApplicationArguments | +| Terminal Menu | `sql/sql_example.cbl` (menu loop) | `AccountCli.java` | ACCEPT/DISPLAY menu → Scanner-based CLI | +| REST API | N/A (new) | `AccountController.java` | Modern HTTP alternative to terminal UI | +| Accept Input | `accept/accept.cbl`, `accept/accept_from.cbl` | Covered by CLI + Spring Boot args | ACCEPT → Scanner / ApplicationArguments | +| Secure Accept | `accept/accept-secure.cbl` | Covered by CLI (Console.readPassword) | ACCEPT SECURE → Console.readPassword | +| Display | `display_test/display_test.cbl` | Standard System.out.println | DISPLAY → println | +| Display Timing | `display_timing/display_timing.cbl` | System.nanoTime() | ACCEPT FROM TIME → Instant.now() | +| Screen Size | `screen_size/get_screen_size.cbl` | N/A (terminal-specific) | CBL_GET_SCR_SIZE → not applicable in web context | +| Mouse Input | `mouse/mouse.cbl` | N/A (terminal-specific) | Mouse drawing → not applicable | +| Search/Search All | `search/search.cbl` | Java Collections / binary search | SEARCH/SEARCH ALL → List operations | +| Redefines | `redifines/redefines.cbl` | Java inheritance / conversion methods | REDEFINES → type conversion | + +## Running the Application + +### Prerequisites +- Java 17+ +- PostgreSQL with `cobol_db_example` database (see `sql/create_test_db.sql`) + +### Build +```bash +cd java-migration +./gradlew build +``` + +### Run (REST API mode) +```bash +./gradlew bootRun +``` +The REST API will be available at `http://localhost:8080/accounts`. + +### Run (CLI mode) +```bash +./gradlew bootRun --args='--spring.profiles.active=cli' +``` + +### Run Tests +```bash +./gradlew test +``` + +## REST API Endpoints + +| Method | Endpoint | Description | COBOL Equivalent | +|---|---|---|---| +| GET | `/accounts` | List all accounts | display-all-accounts | +| GET | `/accounts/disabled` | List disabled accounts | display-disabled-accounts | +| GET | `/accounts/search?q={term}` | Search accounts | query-accounts | +| GET | `/accounts/{id}` | Get account by ID | N/A | +| POST | `/accounts` | Create new account | N/A (extended) | +| PUT | `/accounts/{id}` | Update account | N/A (extended) | +| DELETE | `/accounts/{id}` | Delete account | N/A (extended) | +| PUT | `/accounts/{id}/toggle` | Toggle enabled status | N/A (extended) | diff --git a/java-migration/build.gradle b/java-migration/build.gradle new file mode 100644 index 0000000..d6271f9 --- /dev/null +++ b/java-migration/build.gradle @@ -0,0 +1,41 @@ +plugins { + id 'java' + id 'org.springframework.boot' version '3.2.4' + id 'io.spring.dependency-management' version '1.1.4' +} + +group = 'com.cobolmigration' +version = '1.0.0-SNAPSHOT' + +java { + sourceCompatibility = JavaVersion.VERSION_17 + targetCompatibility = JavaVersion.VERSION_17 +} + +repositories { + mavenCentral() +} + +dependencies { + // Spring Boot starters + implementation 'org.springframework.boot:spring-boot-starter-data-jpa' + implementation 'org.springframework.boot:spring-boot-starter-web' + + // PostgreSQL driver + runtimeOnly 'org.postgresql:postgresql' + + // Jackson (JSON) - included via spring-boot-starter-web + // JAXB (XML) + implementation 'jakarta.xml.bind:jakarta.xml.bind-api:4.0.1' + implementation 'org.glassfish.jaxb:jaxb-runtime:4.0.4' + + // Testing + testImplementation 'org.springframework.boot:spring-boot-starter-test' + testImplementation 'com.h2database:h2' + runtimeOnly 'com.h2database:h2' + testRuntimeOnly 'org.junit.platform:junit-platform-launcher' +} + +tasks.named('test') { + useJUnitPlatform() +} diff --git a/java-migration/gradle/wrapper/gradle-wrapper.jar b/java-migration/gradle/wrapper/gradle-wrapper.jar new file mode 100644 index 0000000..e644113 Binary files /dev/null and b/java-migration/gradle/wrapper/gradle-wrapper.jar differ diff --git a/java-migration/gradle/wrapper/gradle-wrapper.properties b/java-migration/gradle/wrapper/gradle-wrapper.properties new file mode 100644 index 0000000..b82aa23 --- /dev/null +++ b/java-migration/gradle/wrapper/gradle-wrapper.properties @@ -0,0 +1,7 @@ +distributionBase=GRADLE_USER_HOME +distributionPath=wrapper/dists +distributionUrl=https\://services.gradle.org/distributions/gradle-8.7-bin.zip +networkTimeout=10000 +validateDistributionUrl=true +zipStoreBase=GRADLE_USER_HOME +zipStorePath=wrapper/dists diff --git a/java-migration/gradlew b/java-migration/gradlew new file mode 100755 index 0000000..1aa94a4 --- /dev/null +++ b/java-migration/gradlew @@ -0,0 +1,249 @@ +#!/bin/sh + +# +# Copyright © 2015-2021 the original authors. +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# https://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +############################################################################## +# +# Gradle start up script for POSIX generated by Gradle. +# +# Important for running: +# +# (1) You need a POSIX-compliant shell to run this script. If your /bin/sh is +# noncompliant, but you have some other compliant shell such as ksh or +# bash, then to run this script, type that shell name before the whole +# command line, like: +# +# ksh Gradle +# +# Busybox and similar reduced shells will NOT work, because this script +# requires all of these POSIX shell features: +# * functions; +# * expansions «$var», «${var}», «${var:-default}», «${var+SET}», +# «${var#prefix}», «${var%suffix}», and «$( cmd )»; +# * compound commands having a testable exit status, especially «case»; +# * various built-in commands including «command», «set», and «ulimit». +# +# Important for patching: +# +# (2) This script targets any POSIX shell, so it avoids extensions provided +# by Bash, Ksh, etc; in particular arrays are avoided. +# +# The "traditional" practice of packing multiple parameters into a +# space-separated string is a well documented source of bugs and security +# problems, so this is (mostly) avoided, by progressively accumulating +# options in "$@", and eventually passing that to Java. +# +# Where the inherited environment variables (DEFAULT_JVM_OPTS, JAVA_OPTS, +# and GRADLE_OPTS) rely on word-splitting, this is performed explicitly; +# see the in-line comments for details. +# +# There are tweaks for specific operating systems such as AIX, CygWin, +# Darwin, MinGW, and NonStop. +# +# (3) This script is generated from the Groovy template +# https://github.com/gradle/gradle/blob/HEAD/subprojects/plugins/src/main/resources/org/gradle/api/internal/plugins/unixStartScript.txt +# within the Gradle project. +# +# You can find Gradle at https://github.com/gradle/gradle/. +# +############################################################################## + +# Attempt to set APP_HOME + +# Resolve links: $0 may be a link +app_path=$0 + +# Need this for daisy-chained symlinks. +while + APP_HOME=${app_path%"${app_path##*/}"} # leaves a trailing /; empty if no leading path + [ -h "$app_path" ] +do + ls=$( ls -ld "$app_path" ) + link=${ls#*' -> '} + case $link in #( + /*) app_path=$link ;; #( + *) app_path=$APP_HOME$link ;; + esac +done + +# This is normally unused +# shellcheck disable=SC2034 +APP_BASE_NAME=${0##*/} +# Discard cd standard output in case $CDPATH is set (https://github.com/gradle/gradle/issues/25036) +APP_HOME=$( cd "${APP_HOME:-./}" > /dev/null && pwd -P ) || exit + +# Use the maximum available, or set MAX_FD != -1 to use that value. +MAX_FD=maximum + +warn () { + echo "$*" +} >&2 + +die () { + echo + echo "$*" + echo + exit 1 +} >&2 + +# OS specific support (must be 'true' or 'false'). +cygwin=false +msys=false +darwin=false +nonstop=false +case "$( uname )" in #( + CYGWIN* ) cygwin=true ;; #( + Darwin* ) darwin=true ;; #( + MSYS* | MINGW* ) msys=true ;; #( + NONSTOP* ) nonstop=true ;; +esac + +CLASSPATH=$APP_HOME/gradle/wrapper/gradle-wrapper.jar + + +# Determine the Java command to use to start the JVM. +if [ -n "$JAVA_HOME" ] ; then + if [ -x "$JAVA_HOME/jre/sh/java" ] ; then + # IBM's JDK on AIX uses strange locations for the executables + JAVACMD=$JAVA_HOME/jre/sh/java + else + JAVACMD=$JAVA_HOME/bin/java + fi + if [ ! -x "$JAVACMD" ] ; then + die "ERROR: JAVA_HOME is set to an invalid directory: $JAVA_HOME + +Please set the JAVA_HOME variable in your environment to match the +location of your Java installation." + fi +else + JAVACMD=java + if ! command -v java >/dev/null 2>&1 + then + die "ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH. + +Please set the JAVA_HOME variable in your environment to match the +location of your Java installation." + fi +fi + +# Increase the maximum file descriptors if we can. +if ! "$cygwin" && ! "$darwin" && ! "$nonstop" ; then + case $MAX_FD in #( + max*) + # In POSIX sh, ulimit -H is undefined. That's why the result is checked to see if it worked. + # shellcheck disable=SC2039,SC3045 + MAX_FD=$( ulimit -H -n ) || + warn "Could not query maximum file descriptor limit" + esac + case $MAX_FD in #( + '' | soft) :;; #( + *) + # In POSIX sh, ulimit -n is undefined. That's why the result is checked to see if it worked. + # shellcheck disable=SC2039,SC3045 + ulimit -n "$MAX_FD" || + warn "Could not set maximum file descriptor limit to $MAX_FD" + esac +fi + +# Collect all arguments for the java command, stacking in reverse order: +# * args from the command line +# * the main class name +# * -classpath +# * -D...appname settings +# * --module-path (only if needed) +# * DEFAULT_JVM_OPTS, JAVA_OPTS, and GRADLE_OPTS environment variables. + +# For Cygwin or MSYS, switch paths to Windows format before running java +if "$cygwin" || "$msys" ; then + APP_HOME=$( cygpath --path --mixed "$APP_HOME" ) + CLASSPATH=$( cygpath --path --mixed "$CLASSPATH" ) + + JAVACMD=$( cygpath --unix "$JAVACMD" ) + + # Now convert the arguments - kludge to limit ourselves to /bin/sh + for arg do + if + case $arg in #( + -*) false ;; # don't mess with options #( + /?*) t=${arg#/} t=/${t%%/*} # looks like a POSIX filepath + [ -e "$t" ] ;; #( + *) false ;; + esac + then + arg=$( cygpath --path --ignore --mixed "$arg" ) + fi + # Roll the args list around exactly as many times as the number of + # args, so each arg winds up back in the position where it started, but + # possibly modified. + # + # NB: a `for` loop captures its iteration list before it begins, so + # changing the positional parameters here affects neither the number of + # iterations, nor the values presented in `arg`. + shift # remove old arg + set -- "$@" "$arg" # push replacement arg + done +fi + + +# Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script. +DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"' + +# Collect all arguments for the java command: +# * DEFAULT_JVM_OPTS, JAVA_OPTS, JAVA_OPTS, and optsEnvironmentVar are not allowed to contain shell fragments, +# and any embedded shellness will be escaped. +# * For example: A user cannot expect ${Hostname} to be expanded, as it is an environment variable and will be +# treated as '${Hostname}' itself on the command line. + +set -- \ + "-Dorg.gradle.appname=$APP_BASE_NAME" \ + -classpath "$CLASSPATH" \ + org.gradle.wrapper.GradleWrapperMain \ + "$@" + +# Stop when "xargs" is not available. +if ! command -v xargs >/dev/null 2>&1 +then + die "xargs is not available" +fi + +# Use "xargs" to parse quoted args. +# +# With -n1 it outputs one arg per line, with the quotes and backslashes removed. +# +# In Bash we could simply go: +# +# readarray ARGS < <( xargs -n1 <<<"$var" ) && +# set -- "${ARGS[@]}" "$@" +# +# but POSIX shell has neither arrays nor command substitution, so instead we +# post-process each arg (as a line of input to sed) to backslash-escape any +# character that might be a shell metacharacter, then use eval to reverse +# that process (while maintaining the separation between arguments), and wrap +# the whole thing up as a single "set" statement. +# +# This will of course break if any of these variables contains a newline or +# an unmatched quote. +# + +eval "set -- $( + printf '%s\n' "$DEFAULT_JVM_OPTS $JAVA_OPTS $GRADLE_OPTS" | + xargs -n1 | + sed ' s~[^-[:alnum:]+,./:=@_]~\\&~g; ' | + tr '\n' ' ' + )" '"$@"' + +exec "$JAVACMD" "$@" diff --git a/java-migration/gradlew.bat b/java-migration/gradlew.bat new file mode 100644 index 0000000..7101f8e --- /dev/null +++ b/java-migration/gradlew.bat @@ -0,0 +1,92 @@ +@rem +@rem Copyright 2015 the original author or authors. +@rem +@rem Licensed under the Apache License, Version 2.0 (the "License"); +@rem you may not use this file except in compliance with the License. +@rem You may obtain a copy of the License at +@rem +@rem https://www.apache.org/licenses/LICENSE-2.0 +@rem +@rem Unless required by applicable law or agreed to in writing, software +@rem distributed under the License is distributed on an "AS IS" BASIS, +@rem WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +@rem See the License for the specific language governing permissions and +@rem limitations under the License. +@rem + +@if "%DEBUG%"=="" @echo off +@rem ########################################################################## +@rem +@rem Gradle startup script for Windows +@rem +@rem ########################################################################## + +@rem Set local scope for the variables with windows NT shell +if "%OS%"=="Windows_NT" setlocal + +set DIRNAME=%~dp0 +if "%DIRNAME%"=="" set DIRNAME=. +@rem This is normally unused +set APP_BASE_NAME=%~n0 +set APP_HOME=%DIRNAME% + +@rem Resolve any "." and ".." in APP_HOME to make it shorter. +for %%i in ("%APP_HOME%") do set APP_HOME=%%~fi + +@rem Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to pass JVM options to this script. +set DEFAULT_JVM_OPTS="-Xmx64m" "-Xms64m" + +@rem Find java.exe +if defined JAVA_HOME goto findJavaFromJavaHome + +set JAVA_EXE=java.exe +%JAVA_EXE% -version >NUL 2>&1 +if %ERRORLEVEL% equ 0 goto execute + +echo. 1>&2 +echo ERROR: JAVA_HOME is not set and no 'java' command could be found in your PATH. 1>&2 +echo. 1>&2 +echo Please set the JAVA_HOME variable in your environment to match the 1>&2 +echo location of your Java installation. 1>&2 + +goto fail + +:findJavaFromJavaHome +set JAVA_HOME=%JAVA_HOME:"=% +set JAVA_EXE=%JAVA_HOME%/bin/java.exe + +if exist "%JAVA_EXE%" goto execute + +echo. 1>&2 +echo ERROR: JAVA_HOME is set to an invalid directory: %JAVA_HOME% 1>&2 +echo. 1>&2 +echo Please set the JAVA_HOME variable in your environment to match the 1>&2 +echo location of your Java installation. 1>&2 + +goto fail + +:execute +@rem Setup the command line + +set CLASSPATH=%APP_HOME%\gradle\wrapper\gradle-wrapper.jar + + +@rem Execute Gradle +"%JAVA_EXE%" %DEFAULT_JVM_OPTS% %JAVA_OPTS% %GRADLE_OPTS% "-Dorg.gradle.appname=%APP_BASE_NAME%" -classpath "%CLASSPATH%" org.gradle.wrapper.GradleWrapperMain %* + +:end +@rem End local scope for the variables with windows NT shell +if %ERRORLEVEL% equ 0 goto mainEnd + +:fail +rem Set variable GRADLE_EXIT_CONSOLE if you need the _script_ return code instead of +rem the _cmd.exe /c_ return code! +set EXIT_CODE=%ERRORLEVEL% +if %EXIT_CODE% equ 0 set EXIT_CODE=1 +if not ""=="%GRADLE_EXIT_CONSOLE%" exit %EXIT_CODE% +exit /b %EXIT_CODE% + +:mainEnd +if "%OS%"=="Windows_NT" endlocal + +:omega diff --git a/java-migration/settings.gradle b/java-migration/settings.gradle new file mode 100644 index 0000000..1180a84 --- /dev/null +++ b/java-migration/settings.gradle @@ -0,0 +1 @@ +rootProject.name = 'cobol-migration' diff --git a/java-migration/src/main/java/com/cobolmigration/CobolMigrationApplication.java b/java-migration/src/main/java/com/cobolmigration/CobolMigrationApplication.java new file mode 100644 index 0000000..35e793d --- /dev/null +++ b/java-migration/src/main/java/com/cobolmigration/CobolMigrationApplication.java @@ -0,0 +1,18 @@ +package com.cobolmigration; + +import org.springframework.boot.SpringApplication; +import org.springframework.boot.autoconfigure.SpringBootApplication; + +/** + * Main Spring Boot application entry point. + * Replaces the COBOL program-id entry points across all .cbl files. + * + * @see sql/sql_example.cbl - main-procedure + */ +@SpringBootApplication +public class CobolMigrationApplication { + + public static void main(String[] args) { + SpringApplication.run(CobolMigrationApplication.class, args); + } +} diff --git a/java-migration/src/main/java/com/cobolmigration/cli/AccountCli.java b/java-migration/src/main/java/com/cobolmigration/cli/AccountCli.java new file mode 100644 index 0000000..af0c9f7 --- /dev/null +++ b/java-migration/src/main/java/com/cobolmigration/cli/AccountCli.java @@ -0,0 +1,179 @@ +package com.cobolmigration.cli; + +import com.cobolmigration.model.Account; +import com.cobolmigration.service.AccountService; +import java.util.List; +import java.util.Optional; +import java.util.Scanner; +import org.springframework.boot.CommandLineRunner; +import org.springframework.context.annotation.Profile; +import org.springframework.stereotype.Component; + +/** + * Interactive command-line interface replacing the terminal menu from sql_example.cbl. + * + *

COBOL menu mapping (sql_example.cbl lines 158-185): + *

+ * + * @see sql/sql_example.cbl + */ +@Component +@Profile("cli") +public class AccountCli implements CommandLineRunner { + + private final AccountService accountService; + + public AccountCli(AccountService accountService) { + this.accountService = accountService; + } + + @Override + public void run(String... args) throws Exception { + Scanner scanner = new Scanner(System.in); + + System.out.println(); + System.out.println("COBOL SQL DB Example Program (Java Migration)"); + System.out.println("----------------------------------------------"); + System.out.println(); + + boolean running = true; + while (running) { + System.out.println(); + System.out.println("1) Display all accounts"); + System.out.println("2) Display disabled accounts"); + System.out.println("3) Query accounts"); + System.out.println("4) Add account"); + System.out.println("5) Update account"); + System.out.println("6) Delete account"); + System.out.println("7) Toggle account enabled"); + System.out.println("8) Exit"); + System.out.print("Selection: "); + + String choice = scanner.nextLine().trim(); + + switch (choice) { + case "1" -> displayAllAccounts(); + case "2" -> displayDisabledAccounts(); + case "3" -> queryAccounts(scanner); + case "4" -> addAccount(scanner); + case "5" -> updateAccount(scanner); + case "6" -> deleteAccount(scanner); + case "7" -> toggleAccountEnabled(scanner); + case "8" -> running = false; + default -> System.out.println("Please make a selection between 1-8"); + } + } + + System.out.println("Disconnected."); + System.out.println(); + } + + private void displayAllAccounts() { + List accounts = accountService.getAllAccounts(); + displayAccountResults(accounts); + } + + private void displayDisabledAccounts() { + List accounts = accountService.getDisabledAccounts(); + displayAccountResults(accounts); + } + + private void queryAccounts(Scanner scanner) { + boolean searchAgain = true; + while (searchAgain) { + System.out.println(); + System.out.print("Enter search value: "); + String searchTerm = scanner.nextLine(); + + List accounts = accountService.searchAccounts(searchTerm); + displayAccountResults(accounts); + + System.out.println(); + System.out.print("Search again? (Y/[N]) "); + String answer = scanner.nextLine().trim().toUpperCase(); + searchAgain = "Y".equals(answer); + } + } + + private void addAccount(Scanner scanner) { + System.out.print("First name: "); + String firstName = scanner.nextLine(); + System.out.print("Last name: "); + String lastName = scanner.nextLine(); + System.out.print("Phone: "); + String phone = scanner.nextLine(); + System.out.print("Address: "); + String address = scanner.nextLine(); + + Account account = accountService.addAccount(firstName, lastName, phone, address); + System.out.println("Account added with ID: " + account.getId()); + } + + private void updateAccount(Scanner scanner) { + System.out.print("Account ID to update: "); + Long id = Long.parseLong(scanner.nextLine().trim()); + System.out.print("New first name: "); + String firstName = scanner.nextLine(); + System.out.print("New last name: "); + String lastName = scanner.nextLine(); + System.out.print("New phone: "); + String phone = scanner.nextLine(); + System.out.print("New address: "); + String address = scanner.nextLine(); + + Optional updated = accountService.updateAccount(id, firstName, lastName, phone, address); + if (updated.isPresent()) { + System.out.println("Account updated."); + } else { + System.out.println("Account not found."); + } + } + + private void deleteAccount(Scanner scanner) { + System.out.print("Account ID to delete: "); + Long id = Long.parseLong(scanner.nextLine().trim()); + + if (accountService.deleteAccount(id)) { + System.out.println("Account deleted."); + } else { + System.out.println("Account not found."); + } + } + + private void toggleAccountEnabled(Scanner scanner) { + System.out.print("Account ID to toggle: "); + Long id = Long.parseLong(scanner.nextLine().trim()); + + Optional toggled = accountService.toggleAccountEnabled(id); + if (toggled.isPresent()) { + System.out.println("Account enabled status toggled to: " + toggled.get().getIsEnabled()); + } else { + System.out.println("Account not found."); + } + } + + /** + * Displays account results in a table format matching the COBOL + * display-account-results paragraph (sql_example.cbl lines 400-430). + */ + private void displayAccountResults(List accounts) { + System.out.println(); + System.out.println("ACCOUNTS:"); + System.out.println(); + System.out.println(" ID | First | Last | Phone | Address | Enabled "); + System.out.println("------|----------|----------|------------|------------------------|---------"); + + for (Account account : accounts) { + System.out.println(account.toString()); + } + } +} diff --git a/java-migration/src/main/java/com/cobolmigration/cli/CommandLineArgsRunner.java b/java-migration/src/main/java/com/cobolmigration/cli/CommandLineArgsRunner.java new file mode 100644 index 0000000..e95c60a --- /dev/null +++ b/java-migration/src/main/java/com/cobolmigration/cli/CommandLineArgsRunner.java @@ -0,0 +1,62 @@ +package com.cobolmigration.cli; + +import org.springframework.boot.ApplicationArguments; +import org.springframework.context.annotation.Profile; +import org.springframework.stereotype.Component; + +/** + * Command-line argument handler replacing read_command_args/read_cmd_line_args.cbl. + * + *

COBOL equivalent (read_cmd_line_args.cbl): + *

+ *   ACCEPT ws-cmd-args FROM COMMAND-LINE
+ *   INSPECT FUNCTION LOWER-CASE(ws-cmd-args)
+ *       TALLYING ws-test-arg-count FOR ALL "--test"
+ * 
+ * + *

Uses Spring Boot's {@link ApplicationArguments} instead of COBOL's + * ACCEPT FROM COMMAND-LINE. + * + * @see read_command_args/read_cmd_line_args.cbl + */ +@Component +@Profile("cli") +public class CommandLineArgsRunner { + + private final ApplicationArguments applicationArguments; + + public CommandLineArgsRunner(ApplicationArguments applicationArguments) { + this.applicationArguments = applicationArguments; + } + + /** + * Checks if the "--test" argument was provided on the command line. + * Replaces the COBOL INSPECT TALLYING pattern. + * + * @return true if --test was passed + */ + public boolean hasTestArg() { + return applicationArguments.containsOption("test") + || applicationArguments.getNonOptionArgs().stream() + .anyMatch(arg -> arg.equalsIgnoreCase("--test")); + } + + /** + * Returns the full command line arguments as a single string, + * equivalent to COBOL's ACCEPT ws-cmd-args FROM COMMAND-LINE. + * + * @return concatenated command line arguments + */ + public String getFullCommandLine() { + return String.join(" ", applicationArguments.getSourceArgs()); + } + + /** + * Returns all non-option arguments. + * + * @return array of non-option arguments + */ + public String[] getNonOptionArgs() { + return applicationArguments.getNonOptionArgs().toArray(new String[0]); + } +} diff --git a/java-migration/src/main/java/com/cobolmigration/controller/AccountController.java b/java-migration/src/main/java/com/cobolmigration/controller/AccountController.java new file mode 100644 index 0000000..a928753 --- /dev/null +++ b/java-migration/src/main/java/com/cobolmigration/controller/AccountController.java @@ -0,0 +1,128 @@ +package com.cobolmigration.controller; + +import com.cobolmigration.model.Account; +import com.cobolmigration.service.AccountService; +import java.util.List; +import org.springframework.http.HttpStatus; +import org.springframework.http.ResponseEntity; +import org.springframework.web.bind.annotation.DeleteMapping; +import org.springframework.web.bind.annotation.GetMapping; +import org.springframework.web.bind.annotation.PathVariable; +import org.springframework.web.bind.annotation.PostMapping; +import org.springframework.web.bind.annotation.PutMapping; +import org.springframework.web.bind.annotation.RequestBody; +import org.springframework.web.bind.annotation.RequestMapping; +import org.springframework.web.bind.annotation.RequestParam; +import org.springframework.web.bind.annotation.RestController; + +/** + * REST API layer providing a modern alternative to the COBOL terminal UI. + * Maps the account operations from sql/sql_example.cbl to HTTP endpoints. + * + *

Endpoint mapping: + *

    + *
  • GET /accounts → display-all-accounts (ACCOUNT-ALL-CUR)
  • + *
  • GET /accounts/disabled → display-disabled-accounts (ACCOUNT-DISABLED-CUR)
  • + *
  • GET /accounts/search?q= → query-accounts (ACCOUNT-QUERY-CUR)
  • + *
  • GET /accounts/{id} → single account lookup
  • + *
  • POST /accounts → add account
  • + *
  • PUT /accounts/{id} → update account
  • + *
  • DELETE /accounts/{id} → delete account
  • + *
  • PUT /accounts/{id}/toggle → toggle enabled status
  • + *
+ * + * @see sql/sql_example.cbl + */ +@RestController +@RequestMapping("/accounts") +public class AccountController { + + private final AccountService accountService; + + public AccountController(AccountService accountService) { + this.accountService = accountService; + } + + /** + * GET /accounts - Display all accounts ordered by ID. + */ + @GetMapping + public List getAllAccounts() { + return accountService.getAllAccounts(); + } + + /** + * GET /accounts/disabled - Display disabled accounts. + */ + @GetMapping("/disabled") + public List getDisabledAccounts() { + return accountService.getDisabledAccounts(); + } + + /** + * GET /accounts/search?q={term} - Search accounts across all text fields. + */ + @GetMapping("/search") + public List searchAccounts(@RequestParam("q") String searchTerm) { + return accountService.searchAccounts(searchTerm); + } + + /** + * GET /accounts/{id} - Get a single account by ID. + */ + @GetMapping("/{id}") + public ResponseEntity getAccountById(@PathVariable Long id) { + return accountService.getAccountById(id) + .map(ResponseEntity::ok) + .orElse(ResponseEntity.notFound().build()); + } + + /** + * POST /accounts - Add a new account. + */ + @PostMapping + public ResponseEntity addAccount(@RequestBody Account account) { + Account created = accountService.addAccount( + account.getFirstName(), + account.getLastName(), + account.getPhone(), + account.getAddress()); + return ResponseEntity.status(HttpStatus.CREATED).body(created); + } + + /** + * PUT /accounts/{id} - Update an existing account. + */ + @PutMapping("/{id}") + public ResponseEntity updateAccount(@PathVariable Long id, + @RequestBody Account account) { + return accountService.updateAccount(id, + account.getFirstName(), + account.getLastName(), + account.getPhone(), + account.getAddress()) + .map(ResponseEntity::ok) + .orElse(ResponseEntity.notFound().build()); + } + + /** + * DELETE /accounts/{id} - Delete an account. + */ + @DeleteMapping("/{id}") + public ResponseEntity deleteAccount(@PathVariable Long id) { + if (accountService.deleteAccount(id)) { + return ResponseEntity.noContent().build(); + } + return ResponseEntity.notFound().build(); + } + + /** + * PUT /accounts/{id}/toggle - Toggle the enabled status. + */ + @PutMapping("/{id}/toggle") + public ResponseEntity toggleAccountEnabled(@PathVariable Long id) { + return accountService.toggleAccountEnabled(id) + .map(ResponseEntity::ok) + .orElse(ResponseEntity.notFound().build()); + } +} diff --git a/java-migration/src/main/java/com/cobolmigration/dto/RecordDto.java b/java-migration/src/main/java/com/cobolmigration/dto/RecordDto.java new file mode 100644 index 0000000..7b7f51c --- /dev/null +++ b/java-migration/src/main/java/com/cobolmigration/dto/RecordDto.java @@ -0,0 +1,78 @@ +package com.cobolmigration.dto; + +import com.fasterxml.jackson.annotation.JsonInclude; +import com.fasterxml.jackson.annotation.JsonProperty; + +/** + * DTO with Jackson annotations mapping the COBOL NAME OF renames from + * json_generate/json_generate.cbl. + * + *

COBOL field mapping (json_generate.cbl lines 45-48): + *

    + *
  • ws-record-name IS "name" → {@code @JsonProperty("name")}
  • + *
  • ws-record-value IS "value" → {@code @JsonProperty("value")}
  • + *
  • ws-record-blank (suppressed when spaces) → + * {@code @JsonInclude(JsonInclude.Include.NON_EMPTY)}
  • + *
  • ws-record-flag IS "enabled" → {@code @JsonProperty("enabled")}
  • + *
+ * + * @see json_generate/json_generate.cbl + */ +@JsonInclude(JsonInclude.Include.NON_EMPTY) +public class RecordDto { + + @JsonProperty("name") + private String name; + + @JsonProperty("value") + private String value; + + @JsonProperty("blank") + @JsonInclude(JsonInclude.Include.NON_EMPTY) + private String blank; + + @JsonProperty("enabled") + private String enabled; + + public RecordDto() { + } + + public RecordDto(String name, String value, String blank, String enabled) { + this.name = name; + this.value = value; + this.blank = blank; + this.enabled = enabled; + } + + public String getName() { + return name; + } + + public void setName(String name) { + this.name = name; + } + + public String getValue() { + return value; + } + + public void setValue(String value) { + this.value = value; + } + + public String getBlank() { + return blank; + } + + public void setBlank(String blank) { + this.blank = blank; + } + + public String getEnabled() { + return enabled; + } + + public void setEnabled(String enabled) { + this.enabled = enabled; + } +} diff --git a/java-migration/src/main/java/com/cobolmigration/dto/RecordXmlDto.java b/java-migration/src/main/java/com/cobolmigration/dto/RecordXmlDto.java new file mode 100644 index 0000000..fcb171b --- /dev/null +++ b/java-migration/src/main/java/com/cobolmigration/dto/RecordXmlDto.java @@ -0,0 +1,82 @@ +package com.cobolmigration.dto; + +import jakarta.xml.bind.annotation.XmlAccessType; +import jakarta.xml.bind.annotation.XmlAccessorType; +import jakarta.xml.bind.annotation.XmlAttribute; +import jakarta.xml.bind.annotation.XmlElement; +import jakarta.xml.bind.annotation.XmlRootElement; + +/** + * DTO with JAXB annotations for XML serialization, mapping the COBOL XML GENERATE + * from xml_generate/xml_generate.cbl. + * + *

COBOL XML mapping (xml_generate.cbl lines 45-50): + *

    + *
  • ws-record-name IS "name" → {@code @XmlElement(name = "name")}
  • + *
  • ws-record-value IS "value" → {@code @XmlElement(name = "value")}
  • + *
  • ws-record-blank (SUPPRESS WHEN SPACES) → null check in marshalling
  • + *
  • ws-record-flag IS "enabled", TYPE IS ATTRIBUTE → + * {@code @XmlAttribute(name = "enabled")}
  • + *
+ * + * @see xml_generate/xml_generate.cbl + */ +@XmlRootElement(name = "ws-record") +@XmlAccessorType(XmlAccessType.FIELD) +public class RecordXmlDto { + + @XmlElement(name = "name") + private String name; + + @XmlElement(name = "value") + private String value; + + @XmlElement(name = "blank", nillable = false) + private String blank; + + @XmlAttribute(name = "enabled") + private String enabled; + + public RecordXmlDto() { + } + + public RecordXmlDto(String name, String value, String blank, String enabled) { + this.name = name; + this.value = value; + // SUPPRESS WHEN SPACES: if blank is all spaces or empty, set to null + this.blank = (blank != null && !blank.trim().isEmpty()) ? blank : null; + this.enabled = enabled; + } + + public String getName() { + return name; + } + + public void setName(String name) { + this.name = name; + } + + public String getValue() { + return value; + } + + public void setValue(String value) { + this.value = value; + } + + public String getBlank() { + return blank; + } + + public void setBlank(String blank) { + this.blank = (blank != null && !blank.trim().isEmpty()) ? blank : null; + } + + public String getEnabled() { + return enabled; + } + + public void setEnabled(String enabled) { + this.enabled = enabled; + } +} diff --git a/java-migration/src/main/java/com/cobolmigration/model/Account.java b/java-migration/src/main/java/com/cobolmigration/model/Account.java new file mode 100644 index 0000000..ce751d7 --- /dev/null +++ b/java-migration/src/main/java/com/cobolmigration/model/Account.java @@ -0,0 +1,146 @@ +package com.cobolmigration.model; + +import jakarta.persistence.Column; +import jakarta.persistence.Entity; +import jakarta.persistence.GeneratedValue; +import jakarta.persistence.GenerationType; +import jakarta.persistence.Id; +import jakarta.persistence.Table; +import java.time.LocalDateTime; + +/** + * JPA entity mapping from the COBOL ws-sql-account-record in sql/sql_example.cbl. + * + *

COBOL field mapping: + *

    + *
  • ws-sql-account-id (PIC 9(5)) → id (Long, auto-generated)
  • + *
  • ws-sql-account-first-name (PIC X(8)) → firstName (String)
  • + *
  • ws-sql-account-last-name (PIC X(8)) → lastName (String)
  • + *
  • ws-sql-account-phone (PIC X(10)) → phone (String)
  • + *
  • ws-sql-account-address (PIC X(22)) → address (String)
  • + *
  • ws-sql-account-is-enabled (PIC X) → isEnabled (Character, 'Y'/'N')
  • + *
  • ws-sql-account-create-dt (PIC X(20)) → createDt (LocalDateTime)
  • + *
  • ws-sql-account-mod-dt (PIC X(20)) → modDt (LocalDateTime)
  • + *
+ * + * @see sql/sql_example.cbl lines 44-52 + * @see sql/create_test_db.sql + */ +@Entity +@Table(name = "accounts") +public class Account { + + @Id + @GeneratedValue(strategy = GenerationType.IDENTITY) + private Long id; + + @Column(name = "first_name", nullable = false) + private String firstName; + + @Column(name = "last_name", nullable = false) + private String lastName; + + @Column(name = "phone", nullable = false) + private String phone; + + @Column(name = "address", nullable = false) + private String address; + + @Column(name = "is_enabled", nullable = false, length = 1) + private Character isEnabled; + + @Column(name = "create_dt") + private LocalDateTime createDt; + + @Column(name = "mod_dt") + private LocalDateTime modDt; + + public Account() { + } + + public Account(String firstName, String lastName, String phone, + String address, Character isEnabled) { + this.firstName = firstName; + this.lastName = lastName; + this.phone = phone; + this.address = address; + this.isEnabled = isEnabled; + this.createDt = LocalDateTime.now(); + this.modDt = LocalDateTime.now(); + } + + public Long getId() { + return id; + } + + public void setId(Long id) { + this.id = id; + } + + public String getFirstName() { + return firstName; + } + + public void setFirstName(String firstName) { + this.firstName = firstName; + } + + public String getLastName() { + return lastName; + } + + public void setLastName(String lastName) { + this.lastName = lastName; + } + + public String getPhone() { + return phone; + } + + public void setPhone(String phone) { + this.phone = phone; + } + + public String getAddress() { + return address; + } + + public void setAddress(String address) { + this.address = address; + } + + public Character getIsEnabled() { + return isEnabled; + } + + public void setIsEnabled(Character isEnabled) { + this.isEnabled = isEnabled; + } + + public LocalDateTime getCreateDt() { + return createDt; + } + + public void setCreateDt(LocalDateTime createDt) { + this.createDt = createDt; + } + + public LocalDateTime getModDt() { + return modDt; + } + + public void setModDt(LocalDateTime modDt) { + this.modDt = modDt; + } + + @Override + public String toString() { + return String.format("%-5d | %-8s | %-8s | %-10s | %-22s | %c", + id != null ? id : 0, + firstName != null ? firstName.trim() : "", + lastName != null ? lastName.trim() : "", + phone != null ? phone.trim() : "", + address != null ? address.trim() : "", + isEnabled != null ? isEnabled : ' '); + } +} diff --git a/java-migration/src/main/java/com/cobolmigration/model/CustomerRecord.java b/java-migration/src/main/java/com/cobolmigration/model/CustomerRecord.java new file mode 100644 index 0000000..f7efd90 --- /dev/null +++ b/java-migration/src/main/java/com/cobolmigration/model/CustomerRecord.java @@ -0,0 +1,112 @@ +package com.cobolmigration.model; + +/** + * Model mapping from the COBOL FD customer record layout in merge_sort/merge_sort_test.cbl. + * + *

COBOL field mapping: + *

    + *
  • f-customer-id (PIC 9(5)) → customerId (int)
  • + *
  • f-customer-last-name (PIC X(50)) → lastName (String)
  • + *
  • f-customer-first-name (PIC X(50)) → firstName (String)
  • + *
  • f-customer-contract-id (PIC 9(5)) → contractId (int)
  • + *
  • f-customer-comment (PIC X(25)) → comment (String)
  • + *
+ * + * @see merge_sort/merge_sort_test.cbl lines 40-46 + */ +public class CustomerRecord implements Comparable { + + private int customerId; + private String lastName; + private String firstName; + private int contractId; + private String comment; + + public CustomerRecord() { + } + + public CustomerRecord(int customerId, String lastName, String firstName, + int contractId, String comment) { + this.customerId = customerId; + this.lastName = lastName; + this.firstName = firstName; + this.contractId = contractId; + this.comment = comment; + } + + public int getCustomerId() { + return customerId; + } + + public void setCustomerId(int customerId) { + this.customerId = customerId; + } + + public String getLastName() { + return lastName; + } + + public void setLastName(String lastName) { + this.lastName = lastName; + } + + public String getFirstName() { + return firstName; + } + + public void setFirstName(String firstName) { + this.firstName = firstName; + } + + public int getContractId() { + return contractId; + } + + public void setContractId(int contractId) { + this.contractId = contractId; + } + + public String getComment() { + return comment; + } + + public void setComment(String comment) { + this.comment = comment; + } + + @Override + public int compareTo(CustomerRecord other) { + return Integer.compare(this.customerId, other.customerId); + } + + @Override + public String toString() { + return String.format("%-5d%-50s%-50s%-5d%-25s", + customerId, + lastName != null ? lastName : "", + firstName != null ? firstName : "", + contractId, + comment != null ? comment : ""); + } + + /** + * Parses a fixed-width record line matching the COBOL FD layout. + * Total width: 5 + 50 + 50 + 5 + 25 = 135 characters. + * + * @param line the fixed-width line to parse + * @return a CustomerRecord parsed from the line + */ + public static CustomerRecord fromFixedWidth(String line) { + if (line == null || line.length() < 110) { + throw new IllegalArgumentException("Line too short for customer record: " + line); + } + String padded = String.format("%-135s", line); + CustomerRecord record = new CustomerRecord(); + record.setCustomerId(Integer.parseInt(padded.substring(0, 5).trim())); + record.setLastName(padded.substring(5, 55).trim()); + record.setFirstName(padded.substring(55, 105).trim()); + record.setContractId(Integer.parseInt(padded.substring(105, 110).trim())); + record.setComment(padded.substring(110, 135).trim()); + return record; + } +} diff --git a/java-migration/src/main/java/com/cobolmigration/model/StudentRecord.java b/java-migration/src/main/java/com/cobolmigration/model/StudentRecord.java new file mode 100644 index 0000000..5bf1ea5 --- /dev/null +++ b/java-migration/src/main/java/com/cobolmigration/model/StudentRecord.java @@ -0,0 +1,91 @@ +package com.cobolmigration.model; + +/** + * Model mapping from the COBOL FD student record layout in report_writer/report_test.cbl. + * + *

COBOL field mapping: + *

    + *
  • f-test-student-id (PIC 9(6)) → studentId (int)
  • + *
  • f-test-student-name (PIC X(20)) → studentName (String)
  • + *
  • f-test-major (PIC XXX) → major (String)
  • + *
  • f-test-num-courses (PIC 99) → numCourses (int)
  • + *
+ * + * @see report_writer/report_test.cbl lines 24-28 + */ +public class StudentRecord { + + private int studentId; + private String studentName; + private String major; + private int numCourses; + + public StudentRecord() { + } + + public StudentRecord(int studentId, String studentName, String major, int numCourses) { + this.studentId = studentId; + this.studentName = studentName; + this.major = major; + this.numCourses = numCourses; + } + + public int getStudentId() { + return studentId; + } + + public void setStudentId(int studentId) { + this.studentId = studentId; + } + + public String getStudentName() { + return studentName; + } + + public void setStudentName(String studentName) { + this.studentName = studentName; + } + + public String getMajor() { + return major; + } + + public void setMajor(String major) { + this.major = major; + } + + public int getNumCourses() { + return numCourses; + } + + public void setNumCourses(int numCourses) { + this.numCourses = numCourses; + } + + /** + * Parses a fixed-width record line matching the COBOL FD layout. + * Total width: 6 + 20 + 3 + 2 = 31 characters. + * + * @param line the fixed-width line to parse + * @return a StudentRecord parsed from the line + */ + public static StudentRecord fromFixedWidth(String line) { + if (line == null || line.length() < 31) { + throw new IllegalArgumentException("Line too short for student record: " + line); + } + StudentRecord record = new StudentRecord(); + record.setStudentId(Integer.parseInt(line.substring(0, 6).trim())); + record.setStudentName(line.substring(6, 26).trim()); + record.setMajor(line.substring(26, 29).trim()); + record.setNumCourses(Integer.parseInt(line.substring(29, 31).trim())); + return record; + } + + @Override + public String toString() { + return String.format("%-6d%-20s%-3s%02d", studentId, + studentName != null ? studentName : "", + major != null ? major : "", + numCourses); + } +} diff --git a/java-migration/src/main/java/com/cobolmigration/repository/AccountRepository.java b/java-migration/src/main/java/com/cobolmigration/repository/AccountRepository.java new file mode 100644 index 0000000..1761df6 --- /dev/null +++ b/java-migration/src/main/java/com/cobolmigration/repository/AccountRepository.java @@ -0,0 +1,51 @@ +package com.cobolmigration.repository; + +import com.cobolmigration.model.Account; +import java.util.List; +import org.springframework.data.jpa.repository.JpaRepository; +import org.springframework.data.jpa.repository.Query; +import org.springframework.data.repository.query.Param; +import org.springframework.stereotype.Repository; + +/** + * Spring Data JPA repository replacing the three COBOL cursors defined in + * sql/sql_example.cbl (lines 118-153). + * + *

Cursor mapping: + *

    + *
  • ACCOUNT-ALL-CUR → {@link #findAllByOrderByIdAsc()}
  • + *
  • ACCOUNT-DISABLED-CUR → {@link #findByIsEnabledOrderByIdAsc(Character)}
  • + *
  • ACCOUNT-QUERY-CUR → {@link #searchAccounts(String)}
  • + *
+ * + * @see sql/sql_example.cbl + */ +@Repository +public interface AccountRepository extends JpaRepository { + + /** + * Replaces ACCOUNT-ALL-CUR: SELECT ... FROM ACCOUNTS ORDER BY ID. + */ + List findAllByOrderByIdAsc(); + + /** + * Replaces ACCOUNT-DISABLED-CUR: SELECT ... FROM ACCOUNTS WHERE IS_ENABLED = ? ORDER BY ID. + */ + List findByIsEnabledOrderByIdAsc(Character isEnabled); + + /** + * Replaces ACCOUNT-QUERY-CUR: searches across firstName, lastName, phone, and address + * using LIKE with wildcards. The COBOL version wraps the search term with '%' wildcards + * (sql_example.cbl lines 333-337). + * + * @param searchTerm the search term (wildcards should be included by the caller) + * @return matching accounts ordered by ID + */ + @Query("SELECT a FROM Account a WHERE " + + "a.firstName LIKE :searchTerm OR " + + "a.lastName LIKE :searchTerm OR " + + "a.phone LIKE :searchTerm OR " + + "a.address LIKE :searchTerm " + + "ORDER BY a.id ASC") + List searchAccounts(@Param("searchTerm") String searchTerm); +} diff --git a/java-migration/src/main/java/com/cobolmigration/service/AccountService.java b/java-migration/src/main/java/com/cobolmigration/service/AccountService.java new file mode 100644 index 0000000..9e294dd --- /dev/null +++ b/java-migration/src/main/java/com/cobolmigration/service/AccountService.java @@ -0,0 +1,126 @@ +package com.cobolmigration.service; + +import com.cobolmigration.model.Account; +import com.cobolmigration.repository.AccountRepository; +import java.time.LocalDateTime; +import java.util.List; +import java.util.Optional; +import org.springframework.stereotype.Service; +import org.springframework.transaction.annotation.Transactional; + +/** + * Service encapsulating the business logic from sql_example.cbl's procedure division. + * + *

Operations mapped from COBOL paragraphs: + *

    + *
  • display-all-accounts → {@link #getAllAccounts()}
  • + *
  • display-disabled-accounts → {@link #getDisabledAccounts()}
  • + *
  • query-accounts → {@link #searchAccounts(String)}
  • + *
  • (implicit INSERT) → {@link #addAccount(String, String, String, String)}
  • + *
  • (implicit UPDATE) → {@link #updateAccount(Long, String, String, String, String)}
  • + *
  • (implicit DELETE) → {@link #deleteAccount(Long)}
  • + *
  • (toggle IS_ENABLED) → {@link #toggleAccountEnabled(Long)}
  • + *
+ * + * @see sql/sql_example.cbl + */ +@Service +@Transactional +public class AccountService { + + private final AccountRepository accountRepository; + + public AccountService(AccountRepository accountRepository) { + this.accountRepository = accountRepository; + } + + /** + * Display all accounts ordered by ID. + * Replaces the display-all-accounts paragraph using ACCOUNT-ALL-CUR. + */ + @Transactional(readOnly = true) + public List getAllAccounts() { + return accountRepository.findAllByOrderByIdAsc(); + } + + /** + * Display disabled accounts (IS_ENABLED = 'N') ordered by ID. + * Replaces the display-disabled-accounts paragraph using ACCOUNT-DISABLED-CUR. + */ + @Transactional(readOnly = true) + public List getDisabledAccounts() { + return accountRepository.findByIsEnabledOrderByIdAsc('N'); + } + + /** + * Query accounts by search term across firstName, lastName, phone, and address. + * Replaces the query-accounts paragraph using ACCOUNT-QUERY-CUR. + * The COBOL version wraps the search term with '%' wildcards (lines 333-337). + * + * @param searchTerm the raw search term (wildcards are added automatically) + */ + @Transactional(readOnly = true) + public List searchAccounts(String searchTerm) { + String wildcardTerm = "%" + searchTerm.trim() + "%"; + return accountRepository.searchAccounts(wildcardTerm); + } + + /** + * Add a new account. New accounts default to enabled ('Y'). + */ + public Account addAccount(String firstName, String lastName, + String phone, String address) { + Account account = new Account( + firstName.trim(), lastName.trim(), + phone.trim(), address.trim(), 'Y'); + return accountRepository.save(account); + } + + /** + * Update an existing account's fields and set mod_dt. + */ + public Optional updateAccount(Long id, String firstName, String lastName, + String phone, String address) { + return accountRepository.findById(id).map(account -> { + account.setFirstName(firstName.trim()); + account.setLastName(lastName.trim()); + account.setPhone(phone.trim()); + account.setAddress(address.trim()); + account.setModDt(LocalDateTime.now()); + return accountRepository.save(account); + }); + } + + /** + * Delete an account by ID. + * + * @return true if the account existed and was deleted + */ + public boolean deleteAccount(Long id) { + if (accountRepository.existsById(id)) { + accountRepository.deleteById(id); + return true; + } + return false; + } + + /** + * Toggle the IS_ENABLED field between 'Y' and 'N'. + * Maps the COBOL 88-level condition values ws-account-enabled/ws-account-disabled. + */ + public Optional toggleAccountEnabled(Long id) { + return accountRepository.findById(id).map(account -> { + account.setIsEnabled(account.getIsEnabled() == 'Y' ? 'N' : 'Y'); + account.setModDt(LocalDateTime.now()); + return accountRepository.save(account); + }); + } + + /** + * Find a single account by ID. + */ + @Transactional(readOnly = true) + public Optional getAccountById(Long id) { + return accountRepository.findById(id); + } +} diff --git a/java-migration/src/main/java/com/cobolmigration/service/FileMergeService.java b/java-migration/src/main/java/com/cobolmigration/service/FileMergeService.java new file mode 100644 index 0000000..c3af8f0 --- /dev/null +++ b/java-migration/src/main/java/com/cobolmigration/service/FileMergeService.java @@ -0,0 +1,96 @@ +package com.cobolmigration.service; + +import com.cobolmigration.model.CustomerRecord; +import java.io.IOException; +import java.nio.file.Files; +import java.nio.file.Path; +import java.util.ArrayList; +import java.util.Comparator; +import java.util.List; +import java.util.stream.Collectors; +import org.springframework.stereotype.Service; + +/** + * Service replacing the SORT/MERGE logic from merge_sort/merge_sort_test.cbl. + * + *

COBOL operation mapping: + *

    + *
  • MERGE fd-sorting-file ON ASCENDING KEY f-customer-id + * USING fd-test-file-1 fd-test-file-2 GIVING fd-merged-file + * → {@link #mergeFiles(Path, Path, Path)}
  • + *
  • SORT fd-sorting-file ON DESCENDING KEY f-customer-contract-id + * USING fd-merged-file GIVING fd-sorted-contract-id + * → {@link #sortByContractIdDescending(Path, Path)}
  • + *
+ * + * @see merge_sort/merge_sort_test.cbl + */ +@Service +public class FileMergeService { + + /** + * Merges two input files and sorts by customer ID ascending. + * Replaces the COBOL MERGE statement (merge_sort_test.cbl lines 107-110). + * + * @param inputFile1 path to the first input file (East region) + * @param inputFile2 path to the second input file (West region) + * @param outputFile path to the merged output file + * @return the list of merged and sorted records + * @throws IOException if file I/O fails + */ + public List mergeFiles(Path inputFile1, Path inputFile2, Path outputFile) + throws IOException { + List records1 = readRecords(inputFile1); + List records2 = readRecords(inputFile2); + + List merged = new ArrayList<>(); + merged.addAll(records1); + merged.addAll(records2); + + // Sort ascending by customer ID (matches COBOL: ON ASCENDING KEY f-customer-id) + merged.sort(Comparator.comparingInt(CustomerRecord::getCustomerId)); + + writeRecords(outputFile, merged); + return merged; + } + + /** + * Sorts a file by contract ID in descending order. + * Replaces the COBOL SORT statement (merge_sort_test.cbl lines 142-145). + * + * @param inputFile path to the input file (merged output) + * @param outputFile path to the sorted output file + * @return the list of sorted records + * @throws IOException if file I/O fails + */ + public List sortByContractIdDescending(Path inputFile, Path outputFile) + throws IOException { + List records = readRecords(inputFile); + + // Sort descending by contract ID (matches COBOL: ON DESCENDING KEY f-customer-contract-id) + records.sort(Comparator.comparingInt(CustomerRecord::getContractId).reversed()); + + writeRecords(outputFile, records); + return records; + } + + /** + * Reads customer records from a fixed-width file. + */ + public List readRecords(Path filePath) throws IOException { + return Files.readAllLines(filePath).stream() + .filter(line -> !line.isBlank()) + .map(CustomerRecord::fromFixedWidth) + .collect(Collectors.toList()); + } + + /** + * Writes customer records to a fixed-width file. + */ + public void writeRecords(Path filePath, List records) throws IOException { + List lines = records.stream() + .map(CustomerRecord::toString) + .collect(Collectors.toList()); + Files.write(filePath, lines); + } +} diff --git a/java-migration/src/main/java/com/cobolmigration/service/JsonService.java b/java-migration/src/main/java/com/cobolmigration/service/JsonService.java new file mode 100644 index 0000000..b523c8f --- /dev/null +++ b/java-migration/src/main/java/com/cobolmigration/service/JsonService.java @@ -0,0 +1,76 @@ +package com.cobolmigration.service; + +import com.cobolmigration.dto.RecordDto; +import com.fasterxml.jackson.core.JsonProcessingException; +import com.fasterxml.jackson.databind.ObjectMapper; +import org.springframework.stereotype.Service; + +/** + * Service generating JSON from record objects. + * Replaces the COBOL JSON GENERATE statement from json_generate/json_generate.cbl. + * + *

COBOL equivalent (json_generate.cbl lines 42-54): + *

+ *   JSON GENERATE ws-json-output FROM ws-record
+ *       COUNT IN ws-json-char-count
+ *       NAME OF ws-record-name IS "name", ...
+ * 
+ * + * @see json_generate/json_generate.cbl + */ +@Service +public class JsonService { + + private final ObjectMapper objectMapper; + + public JsonService(ObjectMapper objectMapper) { + this.objectMapper = objectMapper; + } + + /** + * Generates JSON from a RecordDto. + * Returns a result containing the JSON string and its character count, + * matching the COBOL COUNT IN behavior. + * + * @param record the record to serialize + * @return the generated JSON string + * @throws JsonProcessingException if serialization fails + */ + public String generateJson(RecordDto record) throws JsonProcessingException { + return objectMapper.writeValueAsString(record); + } + + /** + * Generates JSON and returns the character count alongside the output, + * matching the COBOL COUNT IN ws-json-char-count behavior. + * + * @param record the record to serialize + * @return a JsonResult containing the JSON string and character count + * @throws JsonProcessingException if serialization fails + */ + public JsonResult generateJsonWithCount(RecordDto record) throws JsonProcessingException { + String json = objectMapper.writeValueAsString(record); + return new JsonResult(json, json.length()); + } + + /** + * Result holder matching COBOL's dual output of JSON content and character count. + */ + public static class JsonResult { + private final String json; + private final int charCount; + + public JsonResult(String json, int charCount) { + this.json = json; + this.charCount = charCount; + } + + public String getJson() { + return json; + } + + public int getCharCount() { + return charCount; + } + } +} diff --git a/java-migration/src/main/java/com/cobolmigration/service/ReportService.java b/java-migration/src/main/java/com/cobolmigration/service/ReportService.java new file mode 100644 index 0000000..a2d8604 --- /dev/null +++ b/java-migration/src/main/java/com/cobolmigration/service/ReportService.java @@ -0,0 +1,109 @@ +package com.cobolmigration.service; + +import com.cobolmigration.model.StudentRecord; +import java.util.ArrayList; +import java.util.List; +import org.springframework.stereotype.Service; + +/** + * Service replacing the COBOL Report Writer (RD) from report_writer/report_test.cbl. + * + *

COBOL Report Writer mapping: + *

    + *
  • RD r-test-report PAGE LIMIT IS 66 → {@code PAGE_LIMIT = 66}
  • + *
  • HEADING IS 1 → header at line 1
  • + *
  • FIRST DETAIL 6 → first detail line at position 6
  • + *
  • LAST DETAIL 42 → maximum detail lines per page
  • + *
  • FOOTING 52 → page footing position
  • + *
  • report-header TYPE REPORT HEADING: "Customer Order Report" at col 44, + * "PAGE" + page-counter at col 100
  • + *
  • report-line TYPE DETAIL: student-id at col 4, name at col 15, + * major at col 40, num-courses at col 46
  • + *
+ * + * @see report_writer/report_test.cbl + */ +@Service +public class ReportService { + + private static final int PAGE_LIMIT = 66; + private static final int FIRST_DETAIL_LINE = 6; + private static final int LAST_DETAIL_LINE = 42; + private static final String REPORT_TITLE = "Customer Order Report"; + + /** + * Generates a formatted text report from a list of student records. + * Produces page headers with title and page numbers, and detail lines + * with student ID, name, major, and number of courses. + * + * @param records the student records to include in the report + * @return the formatted report as a list of lines + */ + public List generateReport(List records) { + List reportLines = new ArrayList<>(); + int pageNumber = 1; + int detailLineCount = 0; + int maxDetailsPerPage = LAST_DETAIL_LINE - FIRST_DETAIL_LINE + 1; + + // Generate first page header + reportLines.addAll(generatePageHeader(pageNumber)); + + for (StudentRecord record : records) { + // Check if we need a new page + if (detailLineCount >= maxDetailsPerPage) { + // Pad remaining lines to reach page limit + while (reportLines.size() % PAGE_LIMIT != 0) { + reportLines.add(""); + } + pageNumber++; + reportLines.addAll(generatePageHeader(pageNumber)); + detailLineCount = 0; + } + + // Generate detail line (report_test.cbl lines 59-63) + reportLines.add(formatDetailLine(record)); + detailLineCount++; + } + + return reportLines; + } + + /** + * Generates the page header matching the COBOL report-header definition. + * Line 1: "Customer Order Report" at column 44 + * Line 2: "PAGE" at column 100, page number at column 105 + * Lines 3-5: blank (spacing before first detail at line 6) + */ + private List generatePageHeader(int pageNumber) { + List header = new ArrayList<>(); + + // Line 1: Report title at column 44 (report_test.cbl lines 48-50) + header.add(String.format("%-43s%s", "", REPORT_TITLE)); + + // Line 2: PAGE + number at column 100 (report_test.cbl lines 52-57) + header.add(String.format("%-99s%s%3d", "", "PAGE", pageNumber)); + + // Lines 3-5: blank lines before first detail + header.add(""); + header.add(""); + header.add(""); + + return header; + } + + /** + * Formats a single detail line matching the COBOL report-line definition. + * Column layout (report_test.cbl lines 59-63): + * col 4: student-id (PIC 9(6)) + * col 15: student-name (PIC X(20)) + * col 40: major (PIC XXX) + * col 46: num-courses (PIC 99) + */ + private String formatDetailLine(StudentRecord record) { + return String.format(" %-6d %-20s %-3s %02d", + record.getStudentId(), + record.getStudentName() != null ? record.getStudentName() : "", + record.getMajor() != null ? record.getMajor() : "", + record.getNumCourses()); + } +} diff --git a/java-migration/src/main/java/com/cobolmigration/service/SubProgramService.java b/java-migration/src/main/java/com/cobolmigration/service/SubProgramService.java new file mode 100644 index 0000000..08f24a0 --- /dev/null +++ b/java-migration/src/main/java/com/cobolmigration/service/SubProgramService.java @@ -0,0 +1,175 @@ +package com.cobolmigration.service; + +import org.springframework.stereotype.Service; + +/** + * Service replacing the CALL by-content/by-reference pattern from + * sub_program/main_app.cbl and sub_program/sub.cbl. + * + *

COBOL subprogram semantics mapping: + *

    + *
  • CALL "sub-app" USING BY CONTENT ws-item-1 BY CONTENT ws-item-2 + * → Pass immutable/copied values (Java: pass String copies)
  • + *
  • CALL "sub-app" USING ws-item-1 ws-item-2 (BY REFERENCE, default) + * → Pass mutable objects (Java: pass mutable wrapper)
  • + *
  • CANCEL "sub-app" → Reset working-storage (Java: {@link #cancel()})
  • + *
+ * + *

COBOL storage section mapping: + *

    + *
  • WORKING-STORAGE SECTION → Instance fields (persist between calls)
  • + *
  • LOCAL-STORAGE SECTION → Method-local variables (fresh each call)
  • + *
  • LINKAGE SECTION → Method parameters
  • + *
+ * + * @see sub_program/main_app.cbl + * @see sub_program/sub.cbl + */ +@Service +public class SubProgramService { + + // Working-storage: persists between calls until cancel() is invoked + private String wsTestItem1 = ""; + private String wsTestItem2 = ""; + + /** + * Mutable wrapper for by-reference parameter passing. + * In COBOL, CALL BY REFERENCE allows the subprogram to modify the caller's variables + * (sub_program/main_app.cbl lines 47-48). + */ + public static class MutableString { + private String value; + + public MutableString(String value) { + this.value = value; + } + + public String getValue() { + return value; + } + + public void setValue(String value) { + this.value = value; + } + + @Override + public String toString() { + return value; + } + } + + /** + * Result from a subprogram call, containing the working-storage and local-storage + * values at the start and end of execution. + */ + public static class SubProgramResult { + private final String wsItem1AtStart; + private final String wsItem2AtStart; + private final String wsItem1AtEnd; + private final String wsItem2AtEnd; + private final String outputItem1; + private final String outputItem2; + + public SubProgramResult(String wsItem1AtStart, String wsItem2AtStart, + String wsItem1AtEnd, String wsItem2AtEnd, + String outputItem1, String outputItem2) { + this.wsItem1AtStart = wsItem1AtStart; + this.wsItem2AtStart = wsItem2AtStart; + this.wsItem1AtEnd = wsItem1AtEnd; + this.wsItem2AtEnd = wsItem2AtEnd; + this.outputItem1 = outputItem1; + this.outputItem2 = outputItem2; + } + + public String getWsItem1AtStart() { return wsItem1AtStart; } + public String getWsItem2AtStart() { return wsItem2AtStart; } + public String getWsItem1AtEnd() { return wsItem1AtEnd; } + public String getWsItem2AtEnd() { return wsItem2AtEnd; } + public String getOutputItem1() { return outputItem1; } + public String getOutputItem2() { return outputItem2; } + } + + /** + * Call by content: passes copies of the values. + * The caller's variables are NOT modified (main_app.cbl lines 35-38). + * + * @param item1 first value (immutable copy) + * @param item2 second value (immutable copy) + * @return the result showing working-storage state + */ + public SubProgramResult callByContent(String item1, String item2) { + // Local-storage: fresh on each call (sub.cbl lines 23-25) + String lsTestItem1 = ""; + String lsTestItem2 = ""; + + String wsAtStart1 = wsTestItem1; + String wsAtStart2 = wsTestItem2; + + // Move linkage values to working-storage and local-storage (sub.cbl lines 45-48) + wsTestItem1 = item1; + wsTestItem2 = item2; + lsTestItem1 = item1; + lsTestItem2 = item2; + + // By content: replacements don't affect caller (sub.cbl lines 52-53) + // We return the replaced values but the caller's original strings are unchanged + return new SubProgramResult(wsAtStart1, wsAtStart2, + wsTestItem1, wsTestItem2, + "replace1", "replace2"); + } + + /** + * Call by reference: passes mutable references. + * The caller's variables CAN be modified (main_app.cbl lines 47-49). + * + * @param item1 first value (mutable reference) + * @param item2 second value (mutable reference) + * @return the result showing working-storage state + */ + public SubProgramResult callByReference(MutableString item1, MutableString item2) { + // Local-storage: fresh on each call + String lsTestItem1 = ""; + String lsTestItem2 = ""; + + String wsAtStart1 = wsTestItem1; + String wsAtStart2 = wsTestItem2; + + // Move linkage values to working-storage and local-storage + wsTestItem1 = item1.getValue(); + wsTestItem2 = item2.getValue(); + lsTestItem1 = item1.getValue(); + lsTestItem2 = item2.getValue(); + + // By reference: modifications are visible to the caller (sub.cbl lines 52-53) + item1.setValue("replace1"); + item2.setValue("replace2"); + + return new SubProgramResult(wsAtStart1, wsAtStart2, + wsTestItem1, wsTestItem2, + item1.getValue(), item2.getValue()); + } + + /** + * Cancel/reset the subprogram. + * Replaces CANCEL "sub-app" (main_app.cbl line 55) which resets + * all WORKING-STORAGE variables to their initial values. + */ + public void cancel() { + wsTestItem1 = ""; + wsTestItem2 = ""; + } + + /** + * Returns current working-storage item 1 value for inspection. + */ + public String getWsTestItem1() { + return wsTestItem1; + } + + /** + * Returns current working-storage item 2 value for inspection. + */ + public String getWsTestItem2() { + return wsTestItem2; + } +} diff --git a/java-migration/src/main/java/com/cobolmigration/service/XmlService.java b/java-migration/src/main/java/com/cobolmigration/service/XmlService.java new file mode 100644 index 0000000..b41c297 --- /dev/null +++ b/java-migration/src/main/java/com/cobolmigration/service/XmlService.java @@ -0,0 +1,84 @@ +package com.cobolmigration.service; + +import com.cobolmigration.dto.RecordXmlDto; +import jakarta.xml.bind.JAXBContext; +import jakarta.xml.bind.JAXBException; +import jakarta.xml.bind.Marshaller; +import java.io.StringWriter; +import org.springframework.stereotype.Service; + +/** + * Service generating XML from record objects with XML declaration header. + * Replaces the COBOL XML GENERATE statement from xml_generate/xml_generate.cbl. + * + *

COBOL equivalent (xml_generate.cbl lines 41-56): + *

+ *   XML GENERATE ws-xml-output FROM ws-record
+ *       COUNT IN ws-xml-char-count
+ *       WITH XML-DECLARATION
+ *       NAME OF ws-record-name IS "name", ...
+ *       TYPE OF ws-record-flag IS ATTRIBUTE
+ *       SUPPRESS WHEN SPACES
+ * 
+ * + * @see xml_generate/xml_generate.cbl + */ +@Service +public class XmlService { + + /** + * Generates XML from a RecordXmlDto with XML declaration. + * The XML declaration header matches the COBOL WITH XML-DECLARATION option. + * The enabled field is rendered as an attribute (TYPE IS ATTRIBUTE). + * Fields with only spaces are suppressed (SUPPRESS WHEN SPACES). + * + * @param record the record to serialize + * @return the generated XML string + * @throws JAXBException if marshalling fails + */ + public String generateXml(RecordXmlDto record) throws JAXBException { + JAXBContext context = JAXBContext.newInstance(RecordXmlDto.class); + Marshaller marshaller = context.createMarshaller(); + marshaller.setProperty(Marshaller.JAXB_FORMATTED_OUTPUT, Boolean.FALSE); + // WITH XML-DECLARATION: include the header + marshaller.setProperty(Marshaller.JAXB_FRAGMENT, Boolean.FALSE); + + StringWriter writer = new StringWriter(); + marshaller.marshal(record, writer); + return writer.toString(); + } + + /** + * Generates XML and returns the character count alongside the output, + * matching the COBOL COUNT IN ws-xml-char-count behavior. + * + * @param record the record to serialize + * @return an XmlResult containing the XML string and character count + * @throws JAXBException if marshalling fails + */ + public XmlResult generateXmlWithCount(RecordXmlDto record) throws JAXBException { + String xml = generateXml(record); + return new XmlResult(xml, xml.length()); + } + + /** + * Result holder matching COBOL's dual output of XML content and character count. + */ + public static class XmlResult { + private final String xml; + private final int charCount; + + public XmlResult(String xml, int charCount) { + this.xml = xml; + this.charCount = charCount; + } + + public String getXml() { + return xml; + } + + public int getCharCount() { + return charCount; + } + } +} diff --git a/java-migration/src/main/java/com/cobolmigration/util/NumericUtils.java b/java-migration/src/main/java/com/cobolmigration/util/NumericUtils.java new file mode 100644 index 0000000..4c74ce9 --- /dev/null +++ b/java-migration/src/main/java/com/cobolmigration/util/NumericUtils.java @@ -0,0 +1,119 @@ +package com.cobolmigration.util; + +import java.math.BigDecimal; +import java.math.RoundingMode; + +/** + * Utility class replacing COBOL COMP/COMP-3 numeric handling from comp_test/comp_test.cbl. + * + *

In COBOL, numeric storage types include: + *

    + *
  • COMP (binary) - stored as binary integer, used for subscripts and calculations
  • + *
  • COMP-2 (double-precision floating point) - used in numval_test/numval_test.cbl
  • + *
  • COMP-3 (packed decimal) - BCD encoding for financial calculations
  • + *
  • COMP-5 (native binary) - used in sql_example.cbl for variable-length strings
  • + *
  • DISPLAY (default) - stored as characters, one byte per digit
  • + *
+ * + *

In Java, we use BigDecimal for precision-sensitive calculations, replacing all + * COMP variants to avoid floating-point precision loss. + * + * @see comp_test/comp_test.cbl + * @see numval_test/numval_test.cbl + */ +public final class NumericUtils { + + private NumericUtils() { + // Utility class - prevent instantiation + } + + /** + * Converts a COBOL COMP (binary) value representation to BigDecimal. + * In COBOL, COMP stores values as binary integers (comp_test.cbl line 13: PIC 999 COMP). + * + * @param value the integer value + * @return BigDecimal representation + */ + public static BigDecimal fromComp(int value) { + return BigDecimal.valueOf(value); + } + + /** + * Converts a COBOL COMP-2 (double-precision float) value to BigDecimal. + * Used in numval_test.cbl (line 17: ws-total COMP-2). + * + * @param value the double value + * @return BigDecimal representation with controlled precision + */ + public static BigDecimal fromComp2(double value) { + return BigDecimal.valueOf(value); + } + + /** + * Converts a COBOL COMP-3 (packed decimal) conceptual value to BigDecimal. + * COMP-3 stores two digits per byte in BCD format. + * In Java, BigDecimal natively handles decimal precision. + * + * @param value the string representation of the packed decimal value + * @param scale the number of decimal places implied by the COBOL PIC clause + * @return BigDecimal with the correct scale + */ + public static BigDecimal fromComp3(String value, int scale) { + BigDecimal result = new BigDecimal(value.trim()); + return result.setScale(scale, RoundingMode.HALF_UP); + } + + /** + * Formats a BigDecimal to a COBOL DISPLAY format string. + * Replaces the COBOL MOVE of COMP to DISPLAY (comp_test.cbl lines 27-28). + * + * @param value the BigDecimal to format + * @param width the total character width (PIC 999 = width 3) + * @return zero-padded string representation + */ + public static String toDisplay(BigDecimal value, int width) { + if (value == null) { + return "0".repeat(width); + } + long longVal = value.longValue(); + return String.format("%0" + width + "d", longVal); + } + + /** + * Formats a BigDecimal to a COBOL dynamic display format (suppressed leading zeros). + * Replaces the PIC ZZ9 format (comp_test.cbl line 17). + * + * @param value the BigDecimal to format + * @param width the total character width + * @return right-justified string with leading spaces instead of zeros + */ + public static String toDynamicDisplay(BigDecimal value, int width) { + if (value == null) { + return " ".repeat(width - 1) + "0"; + } + return String.format("%" + width + "d", value.longValue()); + } + + /** + * Multiplies two values, equivalent to COBOL MULTIPLY ... GIVING. + * Uses BigDecimal for precision (comp_test.cbl line 24). + * + * @param a first operand + * @param b second operand + * @return product as BigDecimal + */ + public static BigDecimal multiply(BigDecimal a, BigDecimal b) { + return a.multiply(b); + } + + /** + * Adds two values, equivalent to COBOL ADD or COMPUTE. + * + * @param a first operand + * @param b second operand + * @return sum as BigDecimal + */ + public static BigDecimal add(BigDecimal a, BigDecimal b) { + return a.add(b); + } +} diff --git a/java-migration/src/main/java/com/cobolmigration/util/StringUtils.java b/java-migration/src/main/java/com/cobolmigration/util/StringUtils.java new file mode 100644 index 0000000..d3faefc --- /dev/null +++ b/java-migration/src/main/java/com/cobolmigration/util/StringUtils.java @@ -0,0 +1,159 @@ +package com.cobolmigration.util; + +import java.math.BigDecimal; +import java.util.ArrayList; +import java.util.List; +import java.util.regex.Pattern; + +/** + * Utility class replacing COBOL string/data operations: + *

    + *
  • TRIM intrinsic function → {@link #trim(String)}, {@link #trimLeading(String)}, + * {@link #trimTrailing(String)} (from trim/trim.cbl)
  • + *
  • UNSTRING statement → {@link #unstring(String, String...)} (from unstring/unstring.cbl)
  • + *
  • IS NUMERIC class condition → {@link #isNumeric(String)} (from is_numeric/is_numeric.cbl)
  • + *
  • NUMVAL intrinsic function → {@link #numval(String)} (from numval_test/numval_test.cbl)
  • + *
+ * + * @see trim/trim.cbl + * @see unstring/unstring.cbl + * @see is_numeric/is_numeric.cbl + * @see numval_test/numval_test.cbl + */ +public final class StringUtils { + + private static final Pattern NUMERIC_PATTERN = Pattern.compile("-?\\d+(\\.\\d+)?"); + + private StringUtils() { + // Utility class - prevent instantiation + } + + /** + * Replaces COBOL FUNCTION TRIM(value). + * Removes both leading and trailing spaces, equivalent to COBOL's default TRIM. + * + * @see trim/trim.cbl line 23 + */ + public static String trim(String value) { + if (value == null) { + return ""; + } + return value.trim(); + } + + /** + * Replaces COBOL FUNCTION TRIM(value LEADING). + * Removes leading spaces only. + * + * @see trim/trim.cbl line 24 + */ + public static String trimLeading(String value) { + if (value == null) { + return ""; + } + return value.stripLeading(); + } + + /** + * Replaces COBOL FUNCTION TRIM(value TRAILING). + * Removes trailing spaces only. + * + * @see trim/trim.cbl line 25 + */ + public static String trimTrailing(String value) { + if (value == null) { + return ""; + } + return value.stripTrailing(); + } + + /** + * Replaces the COBOL UNSTRING statement with multiple delimiters. + * Splits a source string by one or more delimiter patterns. + * + *

In COBOL, UNSTRING splits a source string into destination fields + * based on specified delimiters (unstring/unstring.cbl lines 58-61). + * + * @param source the source string to split + * @param delimiters one or more delimiter strings + * @return list of parts after splitting + * @see unstring/unstring.cbl + */ + public static List unstring(String source, String... delimiters) { + if (source == null || delimiters == null || delimiters.length == 0) { + List result = new ArrayList<>(); + if (source != null) { + result.add(source); + } + return result; + } + + // Build a regex pattern from all delimiters, escaping special regex chars + StringBuilder patternBuilder = new StringBuilder(); + for (int i = 0; i < delimiters.length; i++) { + if (i > 0) { + patternBuilder.append("|"); + } + patternBuilder.append(Pattern.quote(delimiters[i])); + } + + String[] parts = source.split(patternBuilder.toString(), -1); + List result = new ArrayList<>(); + for (String part : parts) { + result.add(part); + } + return result; + } + + /** + * Replaces the COBOL IS NUMERIC class condition. + * In COBOL, a PIC X field IS NUMERIC only if all characters are contiguous digits + * (is_numeric/is_numeric.cbl). Spaces cause the test to fail unless the value is trimmed first. + * + * @param value the string to test + * @return true if the trimmed value represents a valid number + * @see is_numeric/is_numeric.cbl + */ + public static boolean isNumeric(String value) { + if (value == null || value.trim().isEmpty()) { + return false; + } + return NUMERIC_PATTERN.matcher(value.trim()).matches(); + } + + /** + * Replaces the COBOL FUNCTION NUMVAL(value). + * Converts an alphanumeric PIC X value to a numeric BigDecimal. + * In COBOL, NUMVAL converts a string representation of a number to its numeric + * equivalent (numval_test/numval_test.cbl line 28). + * + * @param value the string to parse + * @return the numeric value as BigDecimal + * @throws NumberFormatException if the value cannot be parsed + * @see numval_test/numval_test.cbl + */ + public static BigDecimal numval(String value) { + if (value == null || value.trim().isEmpty()) { + throw new NumberFormatException("Cannot parse null or empty value"); + } + return new BigDecimal(value.trim()); + } + + /** + * Pads a string to a fixed width with trailing spaces, mimicking COBOL's PIC X(n) behavior. + * COBOL alphanumeric fields are always space-padded to their defined length. + * + * @param value the string to pad + * @param width the target width + * @return the padded string + */ + public static String padRight(String value, int width) { + if (value == null) { + return " ".repeat(width); + } + if (value.length() >= width) { + return value.substring(0, width); + } + return value + " ".repeat(width - value.length()); + } +} diff --git a/java-migration/src/main/resources/application-h2.properties b/java-migration/src/main/resources/application-h2.properties new file mode 100644 index 0000000..3b95ffe --- /dev/null +++ b/java-migration/src/main/resources/application-h2.properties @@ -0,0 +1,13 @@ +# H2 in-memory database for local testing without PostgreSQL +spring.datasource.url=jdbc:h2:mem:testdb;DB_CLOSE_DELAY=-1;MODE=PostgreSQL +spring.datasource.username=sa +spring.datasource.password= +spring.datasource.driver-class-name=org.h2.Driver + +spring.jpa.hibernate.ddl-auto=create +spring.jpa.show-sql=true +spring.jpa.properties.hibernate.dialect=org.hibernate.dialect.H2Dialect +spring.jpa.defer-datasource-initialization=true + +spring.sql.init.mode=always +spring.sql.init.data-locations=classpath:data-h2.sql diff --git a/java-migration/src/main/resources/application.properties b/java-migration/src/main/resources/application.properties new file mode 100644 index 0000000..37190e3 --- /dev/null +++ b/java-migration/src/main/resources/application.properties @@ -0,0 +1,16 @@ +# PostgreSQL connection configuration +# Maps from the COBOL connection string in sql/sql_example.cbl lines 35-42: +# DRIVER={PostgreSQL Unicode};SERVER=localhost;PORT=5432; +# DATABASE=cobol_db_example;UID=postgres;PWD=password; +spring.datasource.url=jdbc:postgresql://localhost:5432/cobol_db_example +spring.datasource.username=postgres +spring.datasource.password=password +spring.datasource.driver-class-name=org.postgresql.Driver + +# JPA/Hibernate settings +spring.jpa.hibernate.ddl-auto=validate +spring.jpa.show-sql=false +spring.jpa.properties.hibernate.dialect=org.hibernate.dialect.PostgreSQLDialect + +# Initialize schema from migration scripts +spring.sql.init.mode=never diff --git a/java-migration/src/main/resources/data-h2.sql b/java-migration/src/main/resources/data-h2.sql new file mode 100644 index 0000000..ac1ac01 --- /dev/null +++ b/java-migration/src/main/resources/data-h2.sql @@ -0,0 +1,33 @@ +-- Seed data for H2 testing profile (same as sql/create_test_db.sql) +INSERT INTO accounts (first_name, last_name, phone, address, is_enabled, create_dt, mod_dt) +VALUES ('John', 'Tester', '15555550100', '123 Fake St, Nowhere', 'Y', NOW(), NOW()); + +INSERT INTO accounts (first_name, last_name, phone, address, is_enabled, create_dt, mod_dt) +VALUES ('Mike', 'Tester1', '15555550121', '122 Real St, Nowhere', 'Y', NOW(), NOW()); + +INSERT INTO accounts (first_name, last_name, phone, address, is_enabled, create_dt, mod_dt) +VALUES ('Mary', 'Tester2', '15555550132', '121 ABC St, Nowhere', 'Y', NOW(), NOW()); + +INSERT INTO accounts (first_name, last_name, phone, address, is_enabled, create_dt, mod_dt) +VALUES ('Jack', 'Tester3', '15555550143', '120 Rock St, Nowhere', 'Y', NOW(), NOW()); + +INSERT INTO accounts (first_name, last_name, phone, address, is_enabled, create_dt, mod_dt) +VALUES ('Bob', 'Tester4', '15555550154', '119 Truck St, Nowhere', 'N', NOW(), NOW()); + +INSERT INTO accounts (first_name, last_name, phone, address, is_enabled, create_dt, mod_dt) +VALUES ('Paula', 'Tester5', '1555550165', '118 Car St, Nowhere', 'N', NOW(), NOW()); + +INSERT INTO accounts (first_name, last_name, phone, address, is_enabled, create_dt, mod_dt) +VALUES ('James', 'Tester6', '1555550176', '117 Land St, Nowhere', 'Y', NOW(), NOW()); + +INSERT INTO accounts (first_name, last_name, phone, address, is_enabled, create_dt, mod_dt) +VALUES ('Jane', 'Tester7', '1555550187', '116 Sea St, Nowhere', 'Y', NOW(), NOW()); + +INSERT INTO accounts (first_name, last_name, phone, address, is_enabled, create_dt, mod_dt) +VALUES ('Bill', 'Tester8', '1555550198', '115 Dock St, Nowhere', 'N', NOW(), NOW()); + +INSERT INTO accounts (first_name, last_name, phone, address, is_enabled, create_dt, mod_dt) +VALUES ('Lucy', 'Tester9', '1555550209', '114 Beach St, Nowhere', 'Y', NOW(), NOW()); + +INSERT INTO accounts (first_name, last_name, phone, address, is_enabled, create_dt, mod_dt) +VALUES ('Richard', 'Tester10', '1555550210', '113 Water St, Nowhere', 'Y', NOW(), NOW()); diff --git a/java-migration/src/main/resources/db/migration/V1__create_accounts_table.sql b/java-migration/src/main/resources/db/migration/V1__create_accounts_table.sql new file mode 100644 index 0000000..88bcc3e --- /dev/null +++ b/java-migration/src/main/resources/db/migration/V1__create_accounts_table.sql @@ -0,0 +1,49 @@ +-- Database schema migration for the COBOL-to-Java migration. +-- Reference: sql/create_test_db.sql from the COBOL project. + +CREATE TABLE IF NOT EXISTS accounts ( + id SERIAL NOT NULL, + first_name VARCHAR NOT NULL, + last_name VARCHAR NOT NULL, + phone VARCHAR NOT NULL, + address VARCHAR NOT NULL, + is_enabled VARCHAR(1) NOT NULL DEFAULT 'N', + create_dt TIMESTAMP DEFAULT NOW(), + mod_dt TIMESTAMP DEFAULT NOW(), + PRIMARY KEY (id) +); + +-- Populate fake account data (same as the COBOL create_test_db.sql). + +INSERT INTO accounts (first_name, last_name, phone, address, is_enabled, create_dt, mod_dt) +VALUES ('John', 'Tester', '15555550100', '123 Fake St, Nowhere', 'Y', NOW(), NOW()); + +INSERT INTO accounts (first_name, last_name, phone, address, is_enabled, create_dt, mod_dt) +VALUES ('Mike', 'Tester1', '15555550121', '122 Real St, Nowhere', 'Y', NOW(), NOW()); + +INSERT INTO accounts (first_name, last_name, phone, address, is_enabled, create_dt, mod_dt) +VALUES ('Mary', 'Tester2', '15555550132', '121 ABC St, Nowhere', 'Y', NOW(), NOW()); + +INSERT INTO accounts (first_name, last_name, phone, address, is_enabled, create_dt, mod_dt) +VALUES ('Jack', 'Tester3', '15555550143', '120 Rock St, Nowhere', 'Y', NOW(), NOW()); + +INSERT INTO accounts (first_name, last_name, phone, address, is_enabled, create_dt, mod_dt) +VALUES ('Bob', 'Tester4', '15555550154', '119 Truck St, Nowhere', 'N', NOW(), NOW()); + +INSERT INTO accounts (first_name, last_name, phone, address, is_enabled, create_dt, mod_dt) +VALUES ('Paula', 'Tester5', '1555550165', '118 Car St, Nowhere', 'N', NOW(), NOW()); + +INSERT INTO accounts (first_name, last_name, phone, address, is_enabled, create_dt, mod_dt) +VALUES ('James', 'Tester6', '1555550176', '117 Land St, Nowhere', 'Y', NOW(), NOW()); + +INSERT INTO accounts (first_name, last_name, phone, address, is_enabled, create_dt, mod_dt) +VALUES ('Jane', 'Tester7', '1555550187', '116 Sea St, Nowhere', 'Y', NOW(), NOW()); + +INSERT INTO accounts (first_name, last_name, phone, address, is_enabled, create_dt, mod_dt) +VALUES ('Bill', 'Tester8', '1555550198', '115 Dock St, Nowhere', 'N', NOW(), NOW()); + +INSERT INTO accounts (first_name, last_name, phone, address, is_enabled, create_dt, mod_dt) +VALUES ('Lucy', 'Tester9', '1555550209', '114 Beach St, Nowhere', 'Y', NOW(), NOW()); + +INSERT INTO accounts (first_name, last_name, phone, address, is_enabled, create_dt, mod_dt) +VALUES ('Richard', 'Tester10', '1555550210', '113 Water St, Nowhere', 'Y', NOW(), NOW()); diff --git a/java-migration/src/test/java/com/cobolmigration/controller/AccountControllerTest.java b/java-migration/src/test/java/com/cobolmigration/controller/AccountControllerTest.java new file mode 100644 index 0000000..af84474 --- /dev/null +++ b/java-migration/src/test/java/com/cobolmigration/controller/AccountControllerTest.java @@ -0,0 +1,164 @@ +package com.cobolmigration.controller; + +import com.cobolmigration.model.Account; +import com.cobolmigration.service.AccountService; +import com.fasterxml.jackson.databind.ObjectMapper; +import java.util.List; +import java.util.Optional; +import org.junit.jupiter.api.DisplayName; +import org.junit.jupiter.api.Test; +import org.springframework.beans.factory.annotation.Autowired; +import org.springframework.boot.test.autoconfigure.web.servlet.WebMvcTest; +import org.springframework.boot.test.mock.mockito.MockBean; +import org.springframework.http.MediaType; +import org.springframework.test.web.servlet.MockMvc; + +import static org.mockito.ArgumentMatchers.any; +import static org.mockito.ArgumentMatchers.anyLong; +import static org.mockito.ArgumentMatchers.anyString; +import static org.mockito.Mockito.when; +import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.delete; +import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.get; +import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.post; +import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.put; +import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.jsonPath; +import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status; + +/** + * Integration tests for AccountController REST endpoints. + */ +@WebMvcTest(AccountController.class) +class AccountControllerTest { + + @Autowired + private MockMvc mockMvc; + + @MockBean + private AccountService accountService; + + @Autowired + private ObjectMapper objectMapper; + + @Test + @DisplayName("GET /accounts returns all accounts") + void testGetAllAccounts() throws Exception { + Account account = createTestAccount(1L, "John", "Tester", 'Y'); + when(accountService.getAllAccounts()).thenReturn(List.of(account)); + + mockMvc.perform(get("/accounts")) + .andExpect(status().isOk()) + .andExpect(jsonPath("$[0].firstName").value("John")) + .andExpect(jsonPath("$[0].lastName").value("Tester")); + } + + @Test + @DisplayName("GET /accounts/disabled returns disabled accounts") + void testGetDisabledAccounts() throws Exception { + Account account = createTestAccount(1L, "Bob", "Tester4", 'N'); + when(accountService.getDisabledAccounts()).thenReturn(List.of(account)); + + mockMvc.perform(get("/accounts/disabled")) + .andExpect(status().isOk()) + .andExpect(jsonPath("$[0].firstName").value("Bob")) + .andExpect(jsonPath("$[0].isEnabled").value("N")); + } + + @Test + @DisplayName("GET /accounts/search?q=term searches accounts") + void testSearchAccounts() throws Exception { + Account account = createTestAccount(1L, "John", "Tester", 'Y'); + when(accountService.searchAccounts("John")).thenReturn(List.of(account)); + + mockMvc.perform(get("/accounts/search").param("q", "John")) + .andExpect(status().isOk()) + .andExpect(jsonPath("$[0].firstName").value("John")); + } + + @Test + @DisplayName("GET /accounts/{id} returns account by ID") + void testGetAccountById() throws Exception { + Account account = createTestAccount(1L, "John", "Tester", 'Y'); + when(accountService.getAccountById(1L)).thenReturn(Optional.of(account)); + + mockMvc.perform(get("/accounts/1")) + .andExpect(status().isOk()) + .andExpect(jsonPath("$.firstName").value("John")); + } + + @Test + @DisplayName("GET /accounts/{id} returns 404 for nonexistent ID") + void testGetAccountByIdNotFound() throws Exception { + when(accountService.getAccountById(999L)).thenReturn(Optional.empty()); + + mockMvc.perform(get("/accounts/999")) + .andExpect(status().isNotFound()); + } + + @Test + @DisplayName("POST /accounts creates a new account") + void testAddAccount() throws Exception { + Account created = createTestAccount(1L, "Jane", "Doe", 'Y'); + when(accountService.addAccount(anyString(), anyString(), anyString(), anyString())) + .thenReturn(created); + + Account request = new Account("Jane", "Doe", "5551234567", "456 St", 'Y'); + + mockMvc.perform(post("/accounts") + .contentType(MediaType.APPLICATION_JSON) + .content(objectMapper.writeValueAsString(request))) + .andExpect(status().isCreated()) + .andExpect(jsonPath("$.firstName").value("Jane")); + } + + @Test + @DisplayName("PUT /accounts/{id} updates an existing account") + void testUpdateAccount() throws Exception { + Account updated = createTestAccount(1L, "Updated", "Name", 'Y'); + when(accountService.updateAccount(anyLong(), anyString(), anyString(), anyString(), anyString())) + .thenReturn(Optional.of(updated)); + + Account request = new Account("Updated", "Name", "9999999999", "New Address", 'Y'); + + mockMvc.perform(put("/accounts/1") + .contentType(MediaType.APPLICATION_JSON) + .content(objectMapper.writeValueAsString(request))) + .andExpect(status().isOk()) + .andExpect(jsonPath("$.firstName").value("Updated")); + } + + @Test + @DisplayName("DELETE /accounts/{id} deletes an account") + void testDeleteAccount() throws Exception { + when(accountService.deleteAccount(1L)).thenReturn(true); + + mockMvc.perform(delete("/accounts/1")) + .andExpect(status().isNoContent()); + } + + @Test + @DisplayName("DELETE /accounts/{id} returns 404 for nonexistent ID") + void testDeleteAccountNotFound() throws Exception { + when(accountService.deleteAccount(999L)).thenReturn(false); + + mockMvc.perform(delete("/accounts/999")) + .andExpect(status().isNotFound()); + } + + @Test + @DisplayName("PUT /accounts/{id}/toggle toggles enabled status") + void testToggleAccountEnabled() throws Exception { + Account toggled = createTestAccount(1L, "John", "Tester", 'N'); + when(accountService.toggleAccountEnabled(1L)).thenReturn(Optional.of(toggled)); + + mockMvc.perform(put("/accounts/1/toggle")) + .andExpect(status().isOk()) + .andExpect(jsonPath("$.isEnabled").value("N")); + } + + private Account createTestAccount(Long id, String firstName, String lastName, + Character isEnabled) { + Account account = new Account(firstName, lastName, "5551234567", "123 Test St", isEnabled); + account.setId(id); + return account; + } +} diff --git a/java-migration/src/test/java/com/cobolmigration/repository/AccountRepositoryTest.java b/java-migration/src/test/java/com/cobolmigration/repository/AccountRepositoryTest.java new file mode 100644 index 0000000..8640c8a --- /dev/null +++ b/java-migration/src/test/java/com/cobolmigration/repository/AccountRepositoryTest.java @@ -0,0 +1,105 @@ +package com.cobolmigration.repository; + +import com.cobolmigration.model.Account; +import java.util.List; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.DisplayName; +import org.junit.jupiter.api.Test; +import org.springframework.beans.factory.annotation.Autowired; +import org.springframework.boot.test.autoconfigure.orm.jpa.DataJpaTest; +import org.springframework.test.context.ActiveProfiles; + +import static org.assertj.core.api.Assertions.assertThat; + +/** + * Integration tests for AccountRepository validating all three query patterns + * that replace the COBOL cursors in sql/sql_example.cbl. + */ +@DataJpaTest +@ActiveProfiles("test") +class AccountRepositoryTest { + + @Autowired + private AccountRepository accountRepository; + + @BeforeEach + void setUp() { + accountRepository.deleteAll(); + + // Seed test data matching sql/create_test_db.sql + accountRepository.save(new Account("John", "Tester", "15555550100", "123 Fake St, Nowhere", 'Y')); + accountRepository.save(new Account("Mike", "Tester1", "15555550121", "122 Real St, Nowhere", 'Y')); + accountRepository.save(new Account("Mary", "Tester2", "15555550132", "121 ABC St, Nowhere", 'Y')); + accountRepository.save(new Account("Bob", "Tester4", "15555550154", "119 Truck St, Nowhere", 'N')); + accountRepository.save(new Account("Paula", "Tester5", "1555550165", "118 Car St, Nowhere", 'N')); + accountRepository.save(new Account("Bill", "Tester8", "1555550198", "115 Dock St, Nowhere", 'N')); + } + + @Test + @DisplayName("findAllByOrderByIdAsc replaces ACCOUNT-ALL-CUR: returns all accounts sorted by ID") + void testFindAllByOrderByIdAsc() { + List accounts = accountRepository.findAllByOrderByIdAsc(); + + assertThat(accounts).hasSize(6); + // Verify ordering by ID ascending + for (int i = 1; i < accounts.size(); i++) { + assertThat(accounts.get(i).getId()) + .isGreaterThan(accounts.get(i - 1).getId()); + } + } + + @Test + @DisplayName("findByIsEnabledOrderByIdAsc replaces ACCOUNT-DISABLED-CUR: returns only disabled accounts") + void testFindByIsEnabledDisabled() { + List disabledAccounts = accountRepository.findByIsEnabledOrderByIdAsc('N'); + + assertThat(disabledAccounts).hasSize(3); + assertThat(disabledAccounts).allMatch(a -> a.getIsEnabled() == 'N'); + assertThat(disabledAccounts).extracting(Account::getFirstName) + .containsExactly("Bob", "Paula", "Bill"); + } + + @Test + @DisplayName("findByIsEnabledOrderByIdAsc returns enabled accounts when queried with 'Y'") + void testFindByIsEnabledEnabled() { + List enabledAccounts = accountRepository.findByIsEnabledOrderByIdAsc('Y'); + + assertThat(enabledAccounts).hasSize(3); + assertThat(enabledAccounts).allMatch(a -> a.getIsEnabled() == 'Y'); + } + + @Test + @DisplayName("searchAccounts replaces ACCOUNT-QUERY-CUR: searches across firstName, lastName, phone, address") + void testSearchAccountsByFirstName() { + List results = accountRepository.searchAccounts("%John%"); + + assertThat(results).hasSize(1); + assertThat(results.get(0).getFirstName()).isEqualTo("John"); + } + + @Test + @DisplayName("searchAccounts finds matches in lastName field") + void testSearchAccountsByLastName() { + List results = accountRepository.searchAccounts("%Tester%"); + + // All accounts have "Tester" in their last name + assertThat(results).hasSize(6); + } + + @Test + @DisplayName("searchAccounts finds matches in address field") + void testSearchAccountsByAddress() { + List results = accountRepository.searchAccounts("%Fake%"); + + assertThat(results).hasSize(1); + assertThat(results.get(0).getAddress()).contains("Fake"); + } + + @Test + @DisplayName("searchAccounts returns empty list for no matches") + void testSearchAccountsNoResults() { + List results = accountRepository.searchAccounts("%NONEXISTENT%"); + + assertThat(results).isEmpty(); + } +} diff --git a/java-migration/src/test/java/com/cobolmigration/service/AccountServiceTest.java b/java-migration/src/test/java/com/cobolmigration/service/AccountServiceTest.java new file mode 100644 index 0000000..a963249 --- /dev/null +++ b/java-migration/src/test/java/com/cobolmigration/service/AccountServiceTest.java @@ -0,0 +1,119 @@ +package com.cobolmigration.service; + +import com.cobolmigration.model.Account; +import com.cobolmigration.repository.AccountRepository; +import java.util.List; +import java.util.Optional; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.DisplayName; +import org.junit.jupiter.api.Test; +import org.springframework.beans.factory.annotation.Autowired; +import org.springframework.boot.test.autoconfigure.orm.jpa.DataJpaTest; +import org.springframework.context.annotation.Import; +import org.springframework.test.context.ActiveProfiles; + +import static org.assertj.core.api.Assertions.assertThat; + +/** + * Unit tests for AccountService validating business logic from sql_example.cbl. + */ +@DataJpaTest +@ActiveProfiles("test") +@Import(AccountService.class) +class AccountServiceTest { + + @Autowired + private AccountService accountService; + + @Autowired + private AccountRepository accountRepository; + + @BeforeEach + void setUp() { + accountRepository.deleteAll(); + accountRepository.save(new Account("John", "Tester", "15555550100", "123 Fake St", 'Y')); + accountRepository.save(new Account("Bob", "Tester4", "15555550154", "119 Truck St", 'N')); + } + + @Test + @DisplayName("getAllAccounts returns all accounts ordered by ID") + void testGetAllAccounts() { + List accounts = accountService.getAllAccounts(); + assertThat(accounts).hasSize(2); + } + + @Test + @DisplayName("getDisabledAccounts returns only disabled accounts") + void testGetDisabledAccounts() { + List disabled = accountService.getDisabledAccounts(); + assertThat(disabled).hasSize(1); + assertThat(disabled.get(0).getFirstName()).isEqualTo("Bob"); + } + + @Test + @DisplayName("searchAccounts wraps term with wildcards and finds matches") + void testSearchAccounts() { + List results = accountService.searchAccounts("Tester"); + assertThat(results).hasSize(2); + } + + @Test + @DisplayName("addAccount creates a new enabled account") + void testAddAccount() { + Account added = accountService.addAccount("Jane", "Doe", "5551234567", "456 New St"); + assertThat(added.getId()).isNotNull(); + assertThat(added.getIsEnabled()).isEqualTo('Y'); + assertThat(added.getCreateDt()).isNotNull(); + } + + @Test + @DisplayName("updateAccount modifies existing account fields") + void testUpdateAccount() { + Account existing = accountRepository.findAllByOrderByIdAsc().get(0); + Optional updated = accountService.updateAccount( + existing.getId(), "Updated", "Name", "9999999999", "New Address"); + + assertThat(updated).isPresent(); + assertThat(updated.get().getFirstName()).isEqualTo("Updated"); + assertThat(updated.get().getModDt()).isNotNull(); + } + + @Test + @DisplayName("updateAccount returns empty for nonexistent ID") + void testUpdateNonexistentAccount() { + Optional result = accountService.updateAccount( + 99999L, "X", "Y", "Z", "W"); + assertThat(result).isEmpty(); + } + + @Test + @DisplayName("deleteAccount removes an existing account") + void testDeleteAccount() { + Account existing = accountRepository.findAllByOrderByIdAsc().get(0); + boolean deleted = accountService.deleteAccount(existing.getId()); + assertThat(deleted).isTrue(); + assertThat(accountRepository.findById(existing.getId())).isEmpty(); + } + + @Test + @DisplayName("deleteAccount returns false for nonexistent ID") + void testDeleteNonexistentAccount() { + boolean deleted = accountService.deleteAccount(99999L); + assertThat(deleted).isFalse(); + } + + @Test + @DisplayName("toggleAccountEnabled flips Y to N and vice versa") + void testToggleAccountEnabled() { + Account enabledAccount = accountRepository.findAllByOrderByIdAsc().get(0); + assertThat(enabledAccount.getIsEnabled()).isEqualTo('Y'); + + Optional toggled = accountService.toggleAccountEnabled(enabledAccount.getId()); + assertThat(toggled).isPresent(); + assertThat(toggled.get().getIsEnabled()).isEqualTo('N'); + + Optional toggledBack = accountService.toggleAccountEnabled(enabledAccount.getId()); + assertThat(toggledBack).isPresent(); + assertThat(toggledBack.get().getIsEnabled()).isEqualTo('Y'); + } +} diff --git a/java-migration/src/test/java/com/cobolmigration/service/FileMergeServiceTest.java b/java-migration/src/test/java/com/cobolmigration/service/FileMergeServiceTest.java new file mode 100644 index 0000000..781ada8 --- /dev/null +++ b/java-migration/src/test/java/com/cobolmigration/service/FileMergeServiceTest.java @@ -0,0 +1,83 @@ +package com.cobolmigration.service; + +import com.cobolmigration.model.CustomerRecord; +import java.io.IOException; +import java.nio.file.Files; +import java.nio.file.Path; +import java.util.List; +import org.junit.jupiter.api.DisplayName; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.io.TempDir; + +import static org.assertj.core.api.Assertions.assertThat; + +/** + * Tests for FileMergeService validating SORT/MERGE logic from merge_sort/merge_sort_test.cbl. + */ +class FileMergeServiceTest { + + private final FileMergeService fileMergeService = new FileMergeService(); + + @TempDir + Path tempDir; + + @Test + @DisplayName("mergeFiles merges two files and sorts by customer ID ascending") + void testMergeFiles() throws IOException { + // Create test data matching merge_sort_test.cbl create-test-data paragraph + Path file1 = tempDir.resolve("test-file-1.txt"); + Path file2 = tempDir.resolve("test-file-2.txt"); + Path outputFile = tempDir.resolve("merge-output.txt"); + + // East region data (file 1) - matches lines 185-259 + Files.writeString(file1, buildRecord(1, "last-1", "first-1", 5423, "comment-1") + "\n" + + buildRecord(5, "last-5", "first-5", 12323, "comment-5") + "\n" + + buildRecord(10, "last-10", "first-10", 653, "comment-10") + "\n"); + + // West region data (file 2) - matches lines 272-333 + Files.writeString(file2, buildRecord(999, "last-999", "first-999", 1610, "comment-99") + "\n" + + buildRecord(3, "last-03", "first-03", 3331, "comment-03") + "\n"); + + List merged = fileMergeService.mergeFiles(file1, file2, outputFile); + + assertThat(merged).hasSize(5); + // Verify ascending order by customer ID + assertThat(merged.get(0).getCustomerId()).isEqualTo(1); + assertThat(merged.get(1).getCustomerId()).isEqualTo(3); + assertThat(merged.get(2).getCustomerId()).isEqualTo(5); + assertThat(merged.get(3).getCustomerId()).isEqualTo(10); + assertThat(merged.get(4).getCustomerId()).isEqualTo(999); + + // Verify output file was written + assertThat(Files.exists(outputFile)).isTrue(); + assertThat(Files.readAllLines(outputFile)).hasSize(5); + } + + @Test + @DisplayName("sortByContractIdDescending sorts by contract ID in descending order") + void testSortByContractIdDescending() throws IOException { + Path inputFile = tempDir.resolve("input.txt"); + Path outputFile = tempDir.resolve("sorted-output.txt"); + + Files.writeString(inputFile, + buildRecord(1, "last-1", "first-1", 5423, "comment-1") + "\n" + + buildRecord(3, "last-03", "first-03", 3331, "comment-03") + "\n" + + buildRecord(5, "last-5", "first-5", 12323, "comment-5") + "\n" + + buildRecord(10, "last-10", "first-10", 653, "comment-10") + "\n"); + + List sorted = fileMergeService.sortByContractIdDescending(inputFile, outputFile); + + assertThat(sorted).hasSize(4); + // Verify descending order by contract ID + assertThat(sorted.get(0).getContractId()).isEqualTo(12323); + assertThat(sorted.get(1).getContractId()).isEqualTo(5423); + assertThat(sorted.get(2).getContractId()).isEqualTo(3331); + assertThat(sorted.get(3).getContractId()).isEqualTo(653); + } + + private String buildRecord(int customerId, String lastName, String firstName, + int contractId, String comment) { + return String.format("%-5d%-50s%-50s%-5d%-25s", + customerId, lastName, firstName, contractId, comment); + } +} diff --git a/java-migration/src/test/java/com/cobolmigration/service/JsonServiceTest.java b/java-migration/src/test/java/com/cobolmigration/service/JsonServiceTest.java new file mode 100644 index 0000000..5fa42d2 --- /dev/null +++ b/java-migration/src/test/java/com/cobolmigration/service/JsonServiceTest.java @@ -0,0 +1,67 @@ +package com.cobolmigration.service; + +import com.cobolmigration.dto.RecordDto; +import com.fasterxml.jackson.databind.ObjectMapper; +import org.junit.jupiter.api.DisplayName; +import org.junit.jupiter.api.Test; + +import static org.assertj.core.api.Assertions.assertThat; + +/** + * Tests for JsonService validating JSON generation matching json_generate/json_generate.cbl. + */ +class JsonServiceTest { + + private final JsonService jsonService = new JsonService(new ObjectMapper()); + + @Test + @DisplayName("generateJson produces correct JSON with renamed fields") + void testGenerateJson() throws Exception { + // Match the COBOL example data (json_generate.cbl lines 38-40) + RecordDto record = new RecordDto("Test Name", "Test Value", null, "true"); + + String json = jsonService.generateJson(record); + + assertThat(json).contains("\"name\":"); + assertThat(json).contains("\"Test Name\""); + assertThat(json).contains("\"value\":"); + assertThat(json).contains("\"Test Value\""); + assertThat(json).contains("\"enabled\":"); + assertThat(json).contains("\"true\""); + // Blank field should be suppressed (null/empty) + assertThat(json).doesNotContain("\"blank\""); + } + + @Test + @DisplayName("generateJsonWithCount returns character count matching COBOL COUNT IN") + void testGenerateJsonWithCount() throws Exception { + RecordDto record = new RecordDto("Test Name", "Test Value", null, "true"); + + JsonService.JsonResult result = jsonService.generateJsonWithCount(record); + + assertThat(result.getJson()).isNotEmpty(); + assertThat(result.getCharCount()).isEqualTo(result.getJson().length()); + assertThat(result.getCharCount()).isGreaterThan(0); + } + + @Test + @DisplayName("generateJson suppresses blank field when empty (SUPPRESS WHEN SPACES equivalent)") + void testSuppressBlankField() throws Exception { + RecordDto record = new RecordDto("Name", "Value", "", "false"); + + String json = jsonService.generateJson(record); + + assertThat(json).doesNotContain("\"blank\""); + } + + @Test + @DisplayName("generateJson includes blank field when non-empty") + void testNonEmptyBlankField() throws Exception { + RecordDto record = new RecordDto("Name", "Value", "NotBlank", "false"); + + String json = jsonService.generateJson(record); + + assertThat(json).contains("\"blank\""); + assertThat(json).contains("\"NotBlank\""); + } +} diff --git a/java-migration/src/test/java/com/cobolmigration/service/ReportServiceTest.java b/java-migration/src/test/java/com/cobolmigration/service/ReportServiceTest.java new file mode 100644 index 0000000..bd28140 --- /dev/null +++ b/java-migration/src/test/java/com/cobolmigration/service/ReportServiceTest.java @@ -0,0 +1,91 @@ +package com.cobolmigration.service; + +import com.cobolmigration.model.StudentRecord; +import java.util.Arrays; +import java.util.List; +import org.junit.jupiter.api.DisplayName; +import org.junit.jupiter.api.Test; + +import static org.assertj.core.api.Assertions.assertThat; + +/** + * Tests for ReportService validating report formatting matching report_writer/report_test.cbl. + */ +class ReportServiceTest { + + private final ReportService reportService = new ReportService(); + + @Test + @DisplayName("generateReport includes page header with report title") + void testReportHeader() { + List records = List.of( + new StudentRecord(123456, "Test Student", "CSC", 5)); + + List report = reportService.generateReport(records); + + // Header should contain the report title + assertThat(report.get(0)).contains("Customer Order Report"); + } + + @Test + @DisplayName("generateReport includes page number in header") + void testPageNumber() { + List records = List.of( + new StudentRecord(123456, "Test Student", "CSC", 5)); + + List report = reportService.generateReport(records); + + // Second line should contain PAGE and page number + assertThat(report.get(1)).contains("PAGE"); + assertThat(report.get(1)).contains("1"); + } + + @Test + @DisplayName("generateReport includes detail lines with student data") + void testDetailLines() { + List records = List.of( + new StudentRecord(334500, "Test Name", "PHY", 12), + new StudentRecord(112233, "Another Name", "CSC", 8)); + + List report = reportService.generateReport(records); + + // Detail lines start after 5 header lines + String detailLine1 = report.get(5); + assertThat(detailLine1).contains("334500"); + assertThat(detailLine1).contains("Test Name"); + assertThat(detailLine1).contains("PHY"); + assertThat(detailLine1).contains("12"); + + String detailLine2 = report.get(6); + assertThat(detailLine2).contains("112233"); + assertThat(detailLine2).contains("Another Name"); + } + + @Test + @DisplayName("generateReport handles empty record list") + void testEmptyRecords() { + List report = reportService.generateReport(List.of()); + + // Should still have a page header + assertThat(report).isNotEmpty(); + assertThat(report.get(0)).contains("Customer Order Report"); + } + + @Test + @DisplayName("generateReport creates new page when exceeding max details per page") + void testPageBreak() { + // Create enough records to trigger a page break (>37 detail lines) + StudentRecord[] records = new StudentRecord[40]; + for (int i = 0; i < 40; i++) { + records[i] = new StudentRecord(100000 + i, "Student " + i, "CSC", i % 20); + } + + List report = reportService.generateReport(Arrays.asList(records)); + + // Should contain two page headers + long pageHeaderCount = report.stream() + .filter(line -> line.contains("Customer Order Report")) + .count(); + assertThat(pageHeaderCount).isEqualTo(2); + } +} diff --git a/java-migration/src/test/java/com/cobolmigration/service/SubProgramServiceTest.java b/java-migration/src/test/java/com/cobolmigration/service/SubProgramServiceTest.java new file mode 100644 index 0000000..e5acdbf --- /dev/null +++ b/java-migration/src/test/java/com/cobolmigration/service/SubProgramServiceTest.java @@ -0,0 +1,86 @@ +package com.cobolmigration.service; + +import com.cobolmigration.service.SubProgramService.MutableString; +import com.cobolmigration.service.SubProgramService.SubProgramResult; +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.DisplayName; +import org.junit.jupiter.api.Test; + +import static org.assertj.core.api.Assertions.assertThat; + +/** + * Tests for SubProgramService validating CALL by-content/by-reference patterns + * from sub_program/main_app.cbl and sub_program/sub.cbl. + */ +class SubProgramServiceTest { + + private SubProgramService subProgramService; + + @BeforeEach + void setUp() { + subProgramService = new SubProgramService(); + } + + @Test + @DisplayName("callByContent does not modify caller's variables (CALL BY CONTENT)") + void testCallByContent() { + String item1 = "value1"; + String item2 = "value2"; + + SubProgramResult result = subProgramService.callByContent(item1, item2); + + // Working-storage was empty at start (first call) + assertThat(result.getWsItem1AtStart()).isEmpty(); + assertThat(result.getWsItem2AtStart()).isEmpty(); + + // Working-storage was updated during call + assertThat(result.getWsItem1AtEnd()).isEqualTo("value1"); + assertThat(result.getWsItem2AtEnd()).isEqualTo("value2"); + + // Caller's variables are NOT modified (by content = copy) + assertThat(item1).isEqualTo("value1"); + assertThat(item2).isEqualTo("value2"); + } + + @Test + @DisplayName("callByReference modifies caller's variables (CALL BY REFERENCE)") + void testCallByReference() { + MutableString item1 = new MutableString("value1"); + MutableString item2 = new MutableString("value2"); + + SubProgramResult result = subProgramService.callByReference(item1, item2); + + // Caller's variables ARE modified (by reference) + assertThat(item1.getValue()).isEqualTo("replace1"); + assertThat(item2.getValue()).isEqualTo("replace2"); + } + + @Test + @DisplayName("working-storage persists between calls until cancel") + void testWorkingStoragePersistence() { + // First call sets working-storage values + subProgramService.callByContent("first1", "first2"); + assertThat(subProgramService.getWsTestItem1()).isEqualTo("first1"); + + // Second call sees working-storage from first call + SubProgramResult result = subProgramService.callByContent("second1", "second2"); + assertThat(result.getWsItem1AtStart()).isEqualTo("first1"); + assertThat(result.getWsItem2AtStart()).isEqualTo("first2"); + } + + @Test + @DisplayName("cancel resets working-storage (CANCEL 'sub-app')") + void testCancel() { + subProgramService.callByContent("value1", "value2"); + assertThat(subProgramService.getWsTestItem1()).isEqualTo("value1"); + + subProgramService.cancel(); + + assertThat(subProgramService.getWsTestItem1()).isEmpty(); + assertThat(subProgramService.getWsTestItem2()).isEmpty(); + + // After cancel, working-storage starts empty again + SubProgramResult result = subProgramService.callByContent("new1", "new2"); + assertThat(result.getWsItem1AtStart()).isEmpty(); + } +} diff --git a/java-migration/src/test/java/com/cobolmigration/service/XmlServiceTest.java b/java-migration/src/test/java/com/cobolmigration/service/XmlServiceTest.java new file mode 100644 index 0000000..00efa35 --- /dev/null +++ b/java-migration/src/test/java/com/cobolmigration/service/XmlServiceTest.java @@ -0,0 +1,84 @@ +package com.cobolmigration.service; + +import com.cobolmigration.dto.RecordXmlDto; +import org.junit.jupiter.api.DisplayName; +import org.junit.jupiter.api.Test; + +import static org.assertj.core.api.Assertions.assertThat; + +/** + * Tests for XmlService validating XML generation matching xml_generate/xml_generate.cbl. + */ +class XmlServiceTest { + + private final XmlService xmlService = new XmlService(); + + @Test + @DisplayName("generateXml includes XML declaration header (WITH XML-DECLARATION)") + void testXmlDeclaration() throws Exception { + RecordXmlDto record = new RecordXmlDto("Test Name", "Test Value", null, "true"); + + String xml = xmlService.generateXml(record); + + assertThat(xml).startsWith(""); + } + + @Test + @DisplayName("generateXml suppresses blank field when spaces (SUPPRESS WHEN SPACES)") + void testSuppressWhenSpaces() throws Exception { + RecordXmlDto record = new RecordXmlDto("Test Name", "Test Value", " ", "true"); + + String xml = xmlService.generateXml(record); + + // Blank field with only spaces should be suppressed (set to null in constructor) + assertThat(xml).doesNotContain(""); + } + + @Test + @DisplayName("generateXml includes blank field when non-empty") + void testBlankFieldPresent() throws Exception { + RecordXmlDto record = new RecordXmlDto("Name", "Value", "NonBlank", "false"); + + String xml = xmlService.generateXml(record); + + assertThat(xml).contains("NonBlank"); + } + + @Test + @DisplayName("generateXml includes name and value elements with renamed tags") + void testElementNames() throws Exception { + RecordXmlDto record = new RecordXmlDto("Test Name", "Test Value", null, "true"); + + String xml = xmlService.generateXml(record); + + assertThat(xml).contains(""); + assertThat(xml).contains("Test Name"); + assertThat(xml).contains(""); + assertThat(xml).contains("Test Value"); + } + + @Test + @DisplayName("generateXmlWithCount returns character count matching COBOL COUNT IN") + void testGenerateXmlWithCount() throws Exception { + RecordXmlDto record = new RecordXmlDto("Test Name", "Test Value", null, "true"); + + XmlService.XmlResult result = xmlService.generateXmlWithCount(record); + + assertThat(result.getXml()).isNotEmpty(); + assertThat(result.getCharCount()).isEqualTo(result.getXml().length()); + assertThat(result.getCharCount()).isGreaterThan(0); + } +} diff --git a/java-migration/src/test/java/com/cobolmigration/util/NumericUtilsTest.java b/java-migration/src/test/java/com/cobolmigration/util/NumericUtilsTest.java new file mode 100644 index 0000000..9fd7172 --- /dev/null +++ b/java-migration/src/test/java/com/cobolmigration/util/NumericUtilsTest.java @@ -0,0 +1,80 @@ +package com.cobolmigration.util; + +import java.math.BigDecimal; +import org.junit.jupiter.api.DisplayName; +import org.junit.jupiter.api.Test; + +import static org.assertj.core.api.Assertions.assertThat; + +/** + * Tests for NumericUtils validating replacements for COBOL COMP/COMP-3 numeric handling. + * + * @see comp_test/comp_test.cbl + */ +class NumericUtilsTest { + + @Test + @DisplayName("fromComp converts integer to BigDecimal (COMP PIC 999)") + void testFromComp() { + BigDecimal result = NumericUtils.fromComp(24); + assertThat(result).isEqualByComparingTo(new BigDecimal("24")); + } + + @Test + @DisplayName("fromComp2 converts double to BigDecimal (COMP-2)") + void testFromComp2() { + BigDecimal result = NumericUtils.fromComp2(123.456); + assertThat(result).isEqualByComparingTo(new BigDecimal("123.456")); + } + + @Test + @DisplayName("fromComp3 parses string with scale (COMP-3)") + void testFromComp3() { + BigDecimal result = NumericUtils.fromComp3("12345", 2); + assertThat(result).isEqualByComparingTo(new BigDecimal("12345.00")); + assertThat(result.scale()).isEqualTo(2); + } + + @Test + @DisplayName("toDisplay formats to zero-padded string (PIC 999)") + void testToDisplay() { + String result = NumericUtils.toDisplay(new BigDecimal("24"), 3); + assertThat(result).isEqualTo("024"); + } + + @Test + @DisplayName("toDynamicDisplay formats with leading spaces (PIC ZZ9)") + void testToDynamicDisplay() { + String result = NumericUtils.toDynamicDisplay(new BigDecimal("24"), 3); + assertThat(result).isEqualTo(" 24"); + } + + @Test + @DisplayName("multiply performs COBOL MULTIPLY...GIVING operation") + void testMultiply() { + // Mirrors comp_test.cbl: MOVE 12 TO ws-comp-val, MULTIPLY ws-comp-val BY 2 + BigDecimal result = NumericUtils.multiply(new BigDecimal("12"), new BigDecimal("2")); + assertThat(result).isEqualByComparingTo(new BigDecimal("24")); + } + + @Test + @DisplayName("add performs COBOL ADD/COMPUTE operation") + void testAdd() { + BigDecimal result = NumericUtils.add(new BigDecimal("100"), new BigDecimal("200")); + assertThat(result).isEqualByComparingTo(new BigDecimal("300")); + } + + @Test + @DisplayName("toDisplay handles null value") + void testToDisplayNull() { + String result = NumericUtils.toDisplay(null, 3); + assertThat(result).isEqualTo("000"); + } + + @Test + @DisplayName("toDynamicDisplay handles null value") + void testToDynamicDisplayNull() { + String result = NumericUtils.toDynamicDisplay(null, 3); + assertThat(result).isEqualTo(" 0"); + } +} diff --git a/java-migration/src/test/java/com/cobolmigration/util/StringUtilsTest.java b/java-migration/src/test/java/com/cobolmigration/util/StringUtilsTest.java new file mode 100644 index 0000000..2fe0ae8 --- /dev/null +++ b/java-migration/src/test/java/com/cobolmigration/util/StringUtilsTest.java @@ -0,0 +1,172 @@ +package com.cobolmigration.util; + +import java.math.BigDecimal; +import java.util.List; +import org.junit.jupiter.api.DisplayName; +import org.junit.jupiter.api.Test; + +import static org.assertj.core.api.Assertions.assertThat; +import static org.assertj.core.api.Assertions.assertThatThrownBy; + +/** + * Tests for StringUtils validating replacements for COBOL TRIM, UNSTRING, + * IS NUMERIC, and NUMVAL operations. + */ +class StringUtilsTest { + + // --- TRIM tests (from trim/trim.cbl) --- + + @Test + @DisplayName("trim removes both leading and trailing spaces") + void testTrim() { + assertThat(StringUtils.trim(" hello world ")).isEqualTo("hello world"); + } + + @Test + @DisplayName("trimLeading removes only leading spaces") + void testTrimLeading() { + assertThat(StringUtils.trimLeading(" hello world ")) + .isEqualTo("hello world "); + } + + @Test + @DisplayName("trimTrailing removes only trailing spaces") + void testTrimTrailing() { + assertThat(StringUtils.trimTrailing(" hello world ")) + .isEqualTo(" hello world"); + } + + @Test + @DisplayName("trim handles null input") + void testTrimNull() { + assertThat(StringUtils.trim(null)).isEqualTo(""); + } + + @Test + @DisplayName("trim handles string literal with spaces") + void testTrimStringLiteral() { + assertThat(StringUtils.trim(" String literal ")).isEqualTo("String literal"); + } + + // --- UNSTRING tests (from unstring/unstring.cbl) --- + + @Test + @DisplayName("unstring splits by single space delimiter") + void testUnstringSingleDelimiter() { + List parts = StringUtils.unstring("Hello World", " "); + assertThat(parts).containsExactly("Hello", "World"); + } + + @Test + @DisplayName("unstring splits by multiple delimiters") + void testUnstringMultipleDelimiters() { + List parts = StringUtils.unstring("AC!D|E", "<", ">", "!", "|"); + assertThat(parts).containsExactly("A", "B", "C", "D", "E"); + } + + @Test + @DisplayName("unstring handles source with no delimiters") + void testUnstringNoDelimiters() { + List parts = StringUtils.unstring("Hello"); + assertThat(parts).containsExactly("Hello"); + } + + @Test + @DisplayName("unstring handles null source") + void testUnstringNull() { + List parts = StringUtils.unstring(null, " "); + assertThat(parts).isEmpty(); + } + + @Test + @DisplayName("unstring with comma and dot delimiters for formatted numbers") + void testUnstringFormattedNumber() { + // Mirrors unstring.cbl Example 6: unstring formatted number + List parts = StringUtils.unstring("123,456.12", ",", "."); + assertThat(parts).containsExactly("123", "456", "12"); + } + + // --- IS NUMERIC tests (from is_numeric/is_numeric.cbl) --- + + @Test + @DisplayName("isNumeric returns true for digit-only string") + void testIsNumericDigits() { + assertThat(StringUtils.isNumeric("12345")).isTrue(); + } + + @Test + @DisplayName("isNumeric returns true for decimal number") + void testIsNumericDecimal() { + assertThat(StringUtils.isNumeric("123.45")).isTrue(); + } + + @Test + @DisplayName("isNumeric returns true for negative number") + void testIsNumericNegative() { + assertThat(StringUtils.isNumeric("-42")).isTrue(); + } + + @Test + @DisplayName("isNumeric returns false for string with letters") + void testIsNumericWithLetters() { + assertThat(StringUtils.isNumeric("abc")).isFalse(); + } + + @Test + @DisplayName("isNumeric returns false for empty/null input") + void testIsNumericEmpty() { + assertThat(StringUtils.isNumeric("")).isFalse(); + assertThat(StringUtils.isNumeric(null)).isFalse(); + } + + @Test + @DisplayName("isNumeric handles trimmed value with spaces") + void testIsNumericWithSpaces() { + // Mirrors the is_numeric.cbl process-trim paragraph + assertThat(StringUtils.isNumeric(" 123 ")).isTrue(); + } + + // --- NUMVAL tests (from numval_test/numval_test.cbl) --- + + @Test + @DisplayName("numval parses string to BigDecimal") + void testNumval() { + BigDecimal result = StringUtils.numval("42"); + assertThat(result).isEqualByComparingTo(new BigDecimal("42")); + } + + @Test + @DisplayName("numval handles decimal values") + void testNumvalDecimal() { + BigDecimal result = StringUtils.numval("123.45"); + assertThat(result).isEqualByComparingTo(new BigDecimal("123.45")); + } + + @Test + @DisplayName("numval trims spaces before parsing") + void testNumvalWithSpaces() { + BigDecimal result = StringUtils.numval(" 100 "); + assertThat(result).isEqualByComparingTo(new BigDecimal("100")); + } + + @Test + @DisplayName("numval throws exception for non-numeric input") + void testNumvalInvalid() { + assertThatThrownBy(() -> StringUtils.numval("abc")) + .isInstanceOf(NumberFormatException.class); + } + + // --- padRight tests --- + + @Test + @DisplayName("padRight pads to specified width") + void testPadRight() { + assertThat(StringUtils.padRight("Hello", 10)).isEqualTo("Hello "); + } + + @Test + @DisplayName("padRight truncates if longer than width") + void testPadRightTruncate() { + assertThat(StringUtils.padRight("Hello World", 5)).isEqualTo("Hello"); + } +} diff --git a/java-migration/src/test/resources/application-test.properties b/java-migration/src/test/resources/application-test.properties new file mode 100644 index 0000000..307f16d --- /dev/null +++ b/java-migration/src/test/resources/application-test.properties @@ -0,0 +1,11 @@ +# Test configuration using H2 in-memory database +spring.datasource.url=jdbc:h2:mem:testdb;DB_CLOSE_DELAY=-1;MODE=PostgreSQL +spring.datasource.username=sa +spring.datasource.password= +spring.datasource.driver-class-name=org.h2.Driver + +spring.jpa.hibernate.ddl-auto=create-drop +spring.jpa.show-sql=true +spring.jpa.properties.hibernate.dialect=org.hibernate.dialect.H2Dialect + +spring.sql.init.mode=never