From 8de88ad636b0d0b9b61263ca1a3c3473d807a0c0 Mon Sep 17 00:00:00 2001 From: Jesse Schalken Date: Fri, 10 Nov 2023 16:06:18 +1100 Subject: [PATCH] Remove host-only node from runfiles of nodejs_binary to improve host!=target cache hits Signed-off-by: Jordan Mele --- internal/node/node.bzl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/node/node.bzl b/internal/node/node.bzl index 311bb626..514684e1 100755 --- a/internal/node/node.bzl +++ b/internal/node/node.bzl @@ -243,7 +243,7 @@ fi # # Rules such as nodejs_image should use only ctx.toolchains["@build_bazel_rules_nodejs//toolchains/node:toolchain_type"].nodeinfo # when building the image as that will reflect the selected --platform. - node_tool_files = ctx.files._node[:] + node_tool_files = [] node_tool_files.extend(ctx.toolchains["@build_bazel_rules_nodejs//toolchains/node:toolchain_type"].nodeinfo.tool_files) node_tool_files.append(ctx.file._link_modules_script)