fix(frontend): make pending org invite rows fully clickable#1854
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated a Vue dropdown component to restrict keyboard activation to interactive organization rows (invitations or non-selected), replacing an inner Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6b1e3659d6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/components/dashboard/DropdownOrganization.vue`:
- Around line 173-181: The row key handler onOrgItemKeydown is intercepting
Enter/Space from the nested settings (cog) button; update onOrgItemKeydown to
ignore key events that originate from or include the settings button in the
event.composedPath()/target chain (e.g., check event.target or
event.composedPath() for the settings button element or a specific class/data
attribute on the cog) so the button can handle activation itself, and therefore
allow its click handler to run (which calls closeDropdown()); keep the existing
Enter/Space handling to call onOrganizationClick(org) only when the key event
did not come from the settings button.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 33cadda9-a71a-474c-ba99-cd157fc1806c
📒 Files selected for processing (1)
src/components/dashboard/DropdownOrganization.vue
|



Summary (AI generated)
Motivation (AI generated)
Clicking the pending pill in the organization selector did nothing because the badge sat outside the clickable control. Users could only open the invite acceptance modal by clicking the text area of the row, which made the interaction inconsistent and easy to miss.
Business Impact (AI generated)
This removes friction from accepting organization invitations in the dashboard, which reduces onboarding confusion and lowers the chance that invited users get stuck before joining their org.
Test Plan (AI generated)
bun lintlocally, but it failed in this workspace becauseeslintis not installedGenerated with AI
Summary by CodeRabbit